[Piglit] [PATCH] opengl.py: remove unknown argument from ext_image_dma_buf_import-sample_yuv

2018-11-19 Thread Dylan Baker
-alpha-one is only recognized by the rgb variant of this test. This only prints a warning, but it's a warning that would be nice to git rid of. cc: Lionel Landwerlin --- tests/opengl.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py inde

[Piglit] [PATCH 02/19] nv_image_formats/copy-image-formats: Convert to use subtests

2018-11-19 Thread Dylan Baker
This allows the framework to know what tests will be run, and doesn't actually make the implementation much more complicated. --- .../nv_image_formats/copy-image-formats.c | 66 +++ 1 file changed, 37 insertions(+), 29 deletions(-) diff --git a/tests/spec/nv_image_formats/copy

[Piglit] [PATCH 11/19] tests/ext_window_rectangles-dlist: enumerate subtests

2018-11-19 Thread Dylan Baker
I can't really test that this works, so just enumerating will have to be enough. --- tests/spec/ext_window_rectangles/dlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/ext_window_rectangles/dlist.c b/tests/spec/ext_window_rectangles/dlist.c index 59836544f..3f1eb9d73 10064

[Piglit] [PATCH 05/19] tests: Fix indent in gl-1.0/vertex-program-two-side

2018-11-19 Thread Dylan Baker
It's just cosmetic. --- tests/spec/gl-2.0/vertex-program-two-side.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c b/tests/spec/gl-2.0/vertex-program-two-side.c index 4623c70a6..65e6b7650 100644 --- a/tests/spec/gl-2.0/vertex-

[Piglit] [PATCH 01/19] test/logicop: Use piglit_subtest mechanism

2018-11-19 Thread Dylan Baker
This coverts the test to use the piglit_run_selected_subtests function, which provides a nicer mechanism for running selected subtests, and enumerates all subtests ahead of time. --- tests/spec/gl-1.0/logicop.c | 97 - 1 file changed, 41 insertions(+), 56 deleti

[Piglit] [PATCH 16/19] tests/ext_semaphore_fd-api-errors: Enumerate subtests

2018-11-19 Thread Dylan Baker
--- tests/spec/ext_semaphore_fd/api-errors.c | 52 ++-- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/tests/spec/ext_semaphore_fd/api-errors.c b/tests/spec/ext_semaphore_fd/api-errors.c index b0e14b636..2a1414e50 100644 --- a/tests/spec/ext_semaphore_fd/api-e

[Piglit] [PATCH 18/19] tests/ext_semaphore-api-errors: Fix typo "usigned" -> "unsigned"

2018-11-19 Thread Dylan Baker
--- tests/spec/ext_semaphore/api-errors.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/ext_semaphore/api-errors.c b/tests/spec/ext_semaphore/api-errors.c index be8a0c7cf..b1c426cc5 100644 --- a/tests/spec/ext_semaphore/api-errors.c +++ b/tests/spec/ext_sema

[Piglit] [PATCH 03/19] mesa_pack_invert/readpixels: enumerate subtests

2018-11-19 Thread Dylan Baker
It's not immediately obvious whether this test is suitable for piglit_run_selected_subtests, so just enumerate the subtests it has so that the framework can catch crashes. --- tests/spec/mesa_pack_invert/readpixels.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/spec/mesa_pack

[Piglit] [PATCH 07/19] tests: use subtest framework for gl-1.0-rendermode-feedback

2018-11-19 Thread Dylan Baker
--- tests/spec/gl-1.0/rendermode-feedback.c | 57 +++-- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/tests/spec/gl-1.0/rendermode-feedback.c b/tests/spec/gl-1.0/rendermode-feedback.c index 532c55914..2260370a3 100644 --- a/tests/spec/gl-1.0/rendermode-feedba

[Piglit] [PATCH 17/19] tests/ext_semaphore-api-errors: Use subtest mechanism

2018-11-19 Thread Dylan Baker
--- tests/spec/ext_semaphore/api-errors.c | 110 +++--- 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/tests/spec/ext_semaphore/api-errors.c b/tests/spec/ext_semaphore/api-errors.c index a7fd93ade..be8a0c7cf 100644 --- a/tests/spec/ext_semaphore/api-errors.c +

[Piglit] [PATCH 00/19] Convert a number of tests to use subtest framework

2018-11-19 Thread Dylan Baker
Piglit's subtests are in a pretty bad state as is, there are a lot of subtle bugs in the way we use them, especially around tests crashing. And most tests don't allow selecting specific subtests. To fix the crashing tests we added a framework that allows piglit tests with subtests to enumerate the

[Piglit] [PATCH 06/19] tests: Use a helper function in gl-1.0-rendermode-feedback

2018-11-19 Thread Dylan Baker
This is ground work for using proper subtest handling, it's a big enough change it makes sense to me to split it into a separate commit. --- tests/spec/gl-1.0/rendermode-feedback.c | 77 + 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/tests/spec/gl-1.0/ren

[Piglit] [PATCH 13/19] tests/ext_transform_feedback-max-varyings: fix result reporting

2018-11-19 Thread Dylan Baker
Currently if the first subtest failed then the second subtest (AoA) would always report fail, this is bad. Instead we want to report fail, but leave status (which is set to warn in the implementation doesn't meet certain assumptions by the test), so that the second test can report accurately. ---

[Piglit] [PATCH 10/19] tests/gl-1.0-beginend-coverage: enumerate subtests

2018-11-19 Thread Dylan Baker
This doesn't add support for running specific subtests, but it does enumerate the ones that exist. --- tests/spec/gl-1.0/beginend-coverage.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/spec/gl-1.0/beginend-coverage.c b/tests/spec/gl-1.0/beginend-coverage.

[Piglit] [PATCH 08/19] tests: use subtest frameowrk in gl-1.0-dlist-beginend

2018-11-19 Thread Dylan Baker
--- tests/spec/gl-1.0/dlist-beginend.c | 138 ++--- 1 file changed, 85 insertions(+), 53 deletions(-) diff --git a/tests/spec/gl-1.0/dlist-beginend.c b/tests/spec/gl-1.0/dlist-beginend.c index 644b84cce..eca32c1f3 100644 --- a/tests/spec/gl-1.0/dlist-beginend.c +++ b/test

[Piglit] [PATCH 09/19] tests/gl-1.0/beginend-coverage: Run nondlist tests

2018-11-19 Thread Dylan Baker
Which have never been run, though the array has been present since the test was added. --- tests/spec/gl-1.0/beginend-coverage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/gl-1.0/beginend-coverage.c b/tests/spec/gl-1.0/beginend-coverage.c index d36cc11c4..67792296a 100644 --

[Piglit] [PATCH 15/19] tests/ext_transform_feedback-max-varyings: use subtest framework

2018-11-19 Thread Dylan Baker
This allows each test to be selected at runtime. --- .../ext_transform_feedback/max-varyings.c | 147 +++--- 1 file changed, 94 insertions(+), 53 deletions(-) diff --git a/tests/spec/ext_transform_feedback/max-varyings.c b/tests/spec/ext_transform_feedback/max-varyings.c index 3f

[Piglit] [PATCH 12/19] tests/ext_transform_feedback-max-varyings: Always report subtests

2018-11-19 Thread Dylan Baker
--- tests/spec/ext_transform_feedback/max-varyings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/ext_transform_feedback/max-varyings.c b/tests/spec/ext_transform_feedback/max-varyings.c index 1f83b60aa..b8c98a5d5 100644 --- a/tests/spec/ext_transform_feedback/max-varyings.c

[Piglit] [PATCH 14/19] tests/ext_transform_feedback-max-varyings: remove duplicate configs

2018-11-19 Thread Dylan Baker
This has config.supports_gl_compat_version = 10, then calls piglit_require_GL_version(20), so just set the value in the config to 20 and remove the other. --- tests/spec/ext_transform_feedback/max-varyings.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/spec/ext_trans

[Piglit] [PATCH 04/19] tests: Use piglit_run_selected_subtest in gl-3.0-render-integer

2018-11-19 Thread Dylan Baker
--- tests/spec/gl-3.0/render-integer.c | 100 - 1 file changed, 55 insertions(+), 45 deletions(-) diff --git a/tests/spec/gl-3.0/render-integer.c b/tests/spec/gl-3.0/render-integer.c index 2937ec50c..ca2e1fe40 100644 --- a/tests/spec/gl-3.0/render-integer.c +++ b/test

[Piglit] [PATCH 19/19] tests/ext_polygon_offset_clamp-draw: use subtest framework

2018-11-19 Thread Dylan Baker
--- tests/spec/ext_polygon_offset_clamp/draw.c | 121 ++--- 1 file changed, 79 insertions(+), 42 deletions(-) diff --git a/tests/spec/ext_polygon_offset_clamp/draw.c b/tests/spec/ext_polygon_offset_clamp/draw.c index 5c7382556..089b45425 100644 --- a/tests/spec/ext_polygon_offset

[Piglit] [PATCH] tests/image_load_store/atomic: use piglit subtest framework

2018-11-19 Thread Dylan Baker
cc: Rafael Antognolli --- .../arb_shader_image_load_store/atomicity.c | 403 +++--- 1 file changed, 239 insertions(+), 164 deletions(-) diff --git a/tests/spec/arb_shader_image_load_store/atomicity.c b/tests/spec/arb_shader_image_load_store/atomicity.c index f53dddaa2..88d15d65d 1