Re: [Piglit] [PATCH v3] tests: add nvidia conservative rasterization tests

2018-03-30 Thread Brian Paul
The patch looks great overall. Just minor nit-picks below. On 03/28/2018 11:13 AM, Rhys Perry wrote: Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate and GL_NV_conservative_raster_pre_snap_triangles. Changes in v2: - cleanup the tests - fix some test failures - remov

[Piglit] [PATCH 2/3] tex-srgb: Drop unused variables and a stale comment

2018-03-30 Thread Nanley Chery
--- tests/texturing/tex-srgb.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/tests/texturing/tex-srgb.c b/tests/texturing/tex-srgb.c index 96e92a1ff..2fd8d6b96 100644 --- a/tests/texturing/tex-srgb.c +++ b/tests/texturing/tex-srgb.c @@ -68,28 +68,23 @@

[Piglit] [PATCH 3/3] arb_framebuffer_srgb/blit: Add source fill modes

2018-03-30 Thread Nanley Chery
Test how blits behave when the source is cleared. This case is of interest to Intel GPUs, which will fast-clear the source. --- tests/all.py | 12 +++- tests/spec/arb_framebuffer_srgb/blit.c | 35 +++--- 2 files changed, 35 insertions(+

[Piglit] [PATCH 1/3] tex-srgb: Also test a cleared texture

2018-03-30 Thread Nanley Chery
Test sRGB texturing on a cleared texture. This case is of interest to Intel GPUs, which will fast-clear the texture. --- tests/texturing/tex-srgb.c | 45 + 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/tests/texturing/tex-srgb.c b/tests

[Piglit] [PATCH v4] tests: add nvidia conservative rasterization tests

2018-03-30 Thread Rhys Perry
Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate and GL_NV_conservative_raster_pre_snap_triangles. Changes in v2: - cleanup the tests - fix some test failures - remove the gles version of the dilation test as the extension is not exposed in gl.xml Changes in v3: - fix a

Re: [Piglit] [PATCH] tests: add nvidia conservative rasterization tests

2018-03-30 Thread Dylan Baker
Quoting Rhys Perry (2018-03-22 06:43:25) > Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate > and GL_NV_conservative_raster_pre_snap_triangles. > --- > tests/all.py | 20 ++ > tests/spec/CMakeLists.txt | 3