Re: [Piglit] [PATCH] glsl-1.10: add some preprocessor stringification tests

2018-08-28 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/28/2018 06:33 PM, Timothy Arceri wrote: > From Section 3.3. (Preprocessor) of the GLSL 4.60 spec: > > "The following operators are also available: > defined > ## > ... > > Any directive not listed above will cause a compile-time error.

[Piglit] [PATCH] glsl-1.10: add some preprocessor stringification tests

2018-08-28 Thread Timothy Arceri
From Section 3.3. (Preprocessor) of the GLSL 4.60 spec: "The following operators are also available: defined ## ... Any directive not listed above will cause a compile-time error." --- .../stringification-in-unreachable-branch.frag | 12 .../compile

Re: [Piglit] [PATCH] arb_tessellation_shader: add GL_EXT_shader_integer_mix on [require]

2018-08-28 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/24/2018 03:57 AM, Alejandro Piñeiro wrote: > Needed by the tessellation evaluation shader. > --- > .../tes-patch-input-array-vec2-index-invalid-rd.shader_test | 1 > + > 1 file changed, 1 insertion(+) > > diff --git > a/tests/spec/arb_tessellation_

Re: [Piglit] [PATCH 2/2] arb_fragment_shader_interlock: Additional compile tests

2018-08-28 Thread Jason Ekstrand
Both patches are Reviewed-by: Jason Ekstrand Please send a 3rd with switch statements. :-) Or, you can rev this patch. I don't care. --Jason On Tue, Aug 28, 2018 at 5:13 PM Ian Romanick wrote: > From: Ian Romanick > > The negative tests in this group require some inference from various > s

Re: [Piglit] [PATCH] glx: Fix make-current

2018-08-28 Thread Ian Romanick
I'm not even sure what you're trying to fix. As far as I can tell, that test is making a perfectly valid sequence of calls. If a particular driver fails on that, it is a bug in the driver. On 08/25/2018 12:29 PM, Ernestas Kulik wrote: > Actually, scratch that, I must have been high when I wrote

[Piglit] [PATCH 2/2] arb_fragment_shader_interlock: Additional compile tests

2018-08-28 Thread Ian Romanick
From: Ian Romanick The negative tests in this group require some inference from various specs. A spec bug has been submitted against the GL_ARB_fragment_shader_interlock spec. Currently none of the negative tests produce the expected result on Mesa. Signed-off-by: Ian Romanick --- .../beginI

Re: [Piglit] [PATCH] ext_render_snorm-render: fix read back assumptions

2018-08-28 Thread Nanley Chery
On Tue, Aug 28, 2018 at 09:58:14AM +0300, Tapani Pälli wrote: > Test assumed that we can read back directly from R8, RG8 fbo but > this is not actually enabled by the extension. Patch introduces > additional read from window to sanity check fbo contents. > I think we're allowed to read from R8 an

[Piglit] [PATCH] arb_fragment_shader_interlock: Simple compiler tests

2018-08-28 Thread Ian Romanick
From: Ian Romanick Currently none of the negative tests produce the expected result on Mesa. There are other cases called out by the spec as things you cannot do, but it's not clear what the expected result is in those cases (compile- or link-time error, undefined rendering, GPU hang, house fire

Re: [Piglit] [PATCH] Cmake: Install shader_source files

2018-08-28 Thread Dylan Baker
Quoting Mark Janes (2018-08-28 11:38:30) > Reviewed-by: Mark Janes > Tested-by: Mark Janes > > Dylan Baker writes: > > > Otherwise these tests fail in odd ways when running from an installed > > instance. > > > > Cc: Alejandro Piñeiro > > Cc: Mark Janes > > Cc: Clayton Craft > > --- > > CM

Re: [Piglit] [PATCH] Cmake: Install shader_source files

2018-08-28 Thread Mark Janes
Reviewed-by: Mark Janes Tested-by: Mark Janes Dylan Baker writes: > Otherwise these tests fail in odd ways when running from an installed > instance. > > Cc: Alejandro Piñeiro > Cc: Mark Janes > Cc: Clayton Craft > --- > CMakeLists.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[Piglit] [PATCH] Cmake: Install shader_source files

2018-08-28 Thread Dylan Baker
Otherwise these tests fail in odd ways when running from an installed instance. Cc: Alejandro Piñeiro Cc: Mark Janes Cc: Clayton Craft --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8f19457fc..596870b9b 100644 --- a/

Re: [Piglit] [PATCH] glsl-1.30: add linker test for inter stage in/out vars usage

2018-08-28 Thread Vadim Shovkoplias
Hi Timothy, Thanks for the review! Can you please push this patch ? вт, 28 авг. 2018 г. в 3:45, Timothy Arceri : > Reviewed-by: Timothy Arceri > > On 27/08/18 22:19, Vadym Shovkoplias wrote: > > This test exposes a Mesa GLSL linker bug. The test fails with the > > following error message: > > >