Re: [Piglit] [PATCH 1/9] shader_runner: Support testing GL_NUM_PROGRAM_BINARY_FORMATS

On 2018-06-09 21:56:33, Timothy Arceri wrote: > Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a > missing something? They are close. Patch 6 tests that the uniform is reset by examining the result of drawing. Patch 8 tests by reading the uniform value via the GL API. I guess th

Re: [Piglit] [PATCH 1/9] shader_runner: Support testing GL_NUM_PROGRAM_BINARY_FORMATS

Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a missing something? Otherwise, this series looks great thanks for working on it :) Reviewed-by: Timothy Arceri On 09/06/18 15:47, Jordan Justen wrote: Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 16 +

Re: [Piglit] [PATCH 8/9] ARB_get_program_binary: Test that uniforms are reset on program reload (API)

Isn't this exactly the same test as patch 6? On 09/06/18 15:48, Jordan Justen wrote: Signed-off-by: Jordan Justen --- .../arb_get_program_binary/CMakeLists.gl.txt | 1 + .../arb_get_program_binary/reset-uniform.c| 121 ++ 2 files changed, 122 insertions(+) create mo

Re: [Piglit] [PATCH 2/9] shader_runner: Add -get-program-binary parameter

On 09/06/18 15:48, Jordan Justen wrote: This parameter will test ARB_get_program_binary and OES_get_program_binary with any shader runner test. If -get-program-binary, then shader_runner will check to see if the extension is supported, and if 1 or more binary formats are supported. If the exte

[Piglit] [PATCH 2/2] tox: Add python 3.7-dev to build matrix

Signed-off-by: Rhys Kidd --- .travis.yml | 2 ++ tox.ini | 9 + 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index b6e8136e8..bfbba0390 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,6 +21,8 @@ matrix: env: TOX_ENV="py35-{generator

[Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

Python 3.3 reached end-of-life in September 2017 [0]. Continuous integration testing has identified a number of dependencies are now failing on python 3.3, such as: Collecting wheel wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the running Python is 3.3.6 ... OSEr

Re: [Piglit] [PATCH 1/4] README.md: Note that python 3.3.x+ is supported

On 8 June 2018 at 12:15, Dylan Baker wrote: > --- > README.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 30d7a2b5f..2d7d95674 100644 > --- a/README.md > +++ b/README.md > @@ -30,7 +30,7 @@ The original tests have been taken from > > Fi

[Piglit] [PATCH v2] glsl-1.30: add a new test for signed division by immediates

Changes in v2: - Specify the values for the uniforms in the shader source - Rename to "fs-signed-div-by-imm" because I ended up adding non-power-of-two tests Signed-off-by: Rhys Perry --- .../execution/fs-signed-div-by-imm.shader_test | 68 ++ 1 file changed, 68 inserti

Re: [Piglit] [PATCH] glsl-1.30: add a new test for signed division by powers of two

Seems fine, but a handful of comments: On Sat, Jun 9, 2018 at 12:00 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > .../execution/fs-po2-division-int.shader_test | 74 > ++ > 1 file changed, 74 insertions(+) > create mode 100644 > tests/spec/glsl-1.30/execu

[Piglit] [PATCH] glsl-1.30: add a new test for signed division by powers of two

Signed-off-by: Rhys Perry --- .../execution/fs-po2-division-int.shader_test | 74 ++ 1 file changed, 74 insertions(+) create mode 100644 tests/spec/glsl-1.30/execution/fs-po2-division-int.shader_test diff --git a/tests/spec/glsl-1.30/execution/fs-po2-division-int.shade