Re: [Piglit] [PATCH 1/7] appveyro: Remove help invocation from cmake

2017-06-13 Thread Jose Fonseca
-H is not the help option. Is the source directory. See https://stackoverflow.com/questions/31090821/what-does-the-h-option-means-for-cmake I know that both -B and -H are undocumented, but I've been using both since forever, since I prefer them to passing the source/dir as positional argumen

Re: [Piglit] [PATCH 5/7] appveyor: Convert to powerscript blocks for install and build_script

2017-06-13 Thread Jose Fonseca
BTW, some of this logic is really hairy. Furthermore I'm afraid i'm not proficient in powershell, so I don't have confidence I can maintain this. It might be better to simply move all of this into its own .cmd script. Jose From: Dylan Baker Sent: Tuesday, J

Re: [Piglit] [PATCH 7/7] appveyor: Add python tests

2017-06-13 Thread Jose Fonseca
I thinks it's fine to restrict the supported Python versions on Windows. (Eg., only 2.7 and 3.6.) Either way, this is Reviewed-by: Jose Fonseca I haven't received PATCH 3 and 4 yet. But 2, 5, 6 are also Reviewed-by: Jose Fonseca Jose From: Dylan Bake

[Piglit] [PATCH 7/7] appveyor: Add python tests

2017-06-13 Thread Dylan Baker
Signed-off-by: Dylan Baker --- appveyor.yml | 57 +++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index c83efc757..f4cfa8721 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -43,33 +43,75 @@ cache:

[Piglit] [PATCH 4/7] appveyor: Use requirement files to install dependencies with pip

2017-06-13 Thread Dylan Baker
This allows the dependencies to be centrally located, rather than in multiple places. Signed-off-by: Dylan Baker --- appveyor.yml | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 8a78f61f7..520339c87 100644 --- a/appveyor.yml +++ b/ap

[Piglit] [PATCH 3/7] Add python requirement files

2017-06-13 Thread Dylan Baker
These can be used with `pip install -r` to batch install requirements, mainly these are intended to be used by CI. Signed-off-by: Dylan Baker --- python-requirements/minimum.txt | 3 +++ python-requirements/python2-extra-nix.txt | 1 + python-requirements/python2-extra.txt | 4

[Piglit] [PATCH 5/7] appveyor: Convert to powerscript blocks for install and build_script

2017-06-13 Thread Dylan Baker
This is required to run two types of tests, which is what is needed to add back tests for the python runner. Signed-off-by: Dylan Baker --- appveyor.yml | 72 +--- 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/appveyor.yml

[Piglit] Appveyor: Add support for python tests in addition to native tests

2017-06-13 Thread Dylan Baker
This little series fixes a few bugs, centralizes a few things, and adds python tests back to appveyor, while maintaining support for native C/C++ compilation. It does this by converting several sections to powerscript, which I find easier to read and write than cmd (batch) scripts. This is availab

[Piglit] [PATCH 6/7] appveyor: cache python packages

2017-06-13 Thread Dylan Baker
Signed-off-by: Dylan Baker --- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 85045782f..c83efc757 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -37,6 +37,7 @@ clone_depth: 100 cache: - freeglut-MinGW-3.0.0-1.mp.zip - freeglut-MinGW-3.0

[Piglit] [PATCH 2/7] appveyor: Normalize indentation of lists

2017-06-13 Thread Dylan Baker
Just whitespace changes. Signed-off-by: Dylan Baker --- appveyor.yml | 83 ++-- 1 file changed, 42 insertions(+), 41 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 00b5700c6..8a78f61f7 100644 --- a/appveyor.yml +++ b/appveyor.

[Piglit] [PATCH 1/7] appveyro: Remove help invocation from cmake

2017-06-13 Thread Dylan Baker
Signed-off-by: Dylan Baker --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 302308599..00b5700c6 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -86,7 +86,7 @@ install: - appveyor DownloadFile https://www.khronos.org/registry/

Re: [Piglit] [PATCH] Respect GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT in binding-layout.c.

2017-06-13 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/04/2017 06:30 PM, Kenneth Graunke wrote: > The spec/arb_shading_language_420pack/execution/binding-layout test > assumed that it could bind buffers at 16-byte offsets. This may not > be true - we need to respect GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT. >

Re: [Piglit] [PATCH] khr_texture_compression_astc: change the subtest array declaration to prevent the crash coming from Visual Studio's optimisation

2017-06-13 Thread Ian Romanick
On 06/06/2017 06:01 AM, Sandra Koroniewska wrote: > This fixes > spec/khr_texture_compression_astc/khr_compressed_astc-array_gl on > Intel Windows driver. > --- > .../khr_compressed_astc-miptree-array.c| 37 > +++--- > 1 file changed, 19 insertions(+), 18 deletions(-)

Re: [Piglit] [PATCH 6/8] fbo: Use renderbuffers instead of textures

2017-06-13 Thread Ian Romanick
On 06/02/2017 01:25 PM, Mark Janes wrote: > Hi Ian, > > This test fails on g33. Was that expected? That is not expected. Since this test passes on i965 and on... some legacy platforms, it seems like this has to be some sort of (preexisting) i915 bug. Can you submit a bugzilla and assign it to

Re: [Piglit] [PATCH v2] tests: Added a couple of new test profiles for the Khronos CTS runner

2017-06-13 Thread Mark Janes
Tested-by: Mark Janes Andres Gomez writes: > After: > https://github.com/KhronosGroup/VK-GL-CTS/commit/af8c22a343ee2c230488f6de71b36dc3070b2024 > > OpenGL GL*-CTS case lists were renamed to KHR-GL*. > > We want to keep the existing profiles so we are able to keep running > the caselists from pr

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures (v2)

2017-06-13 Thread Dorian Apanel
Thank You Francisco for pointing this out. I didn't know about this bug. 2017-06-12 20:59 GMT+02:00 Francisco Jerez : > Dorian Apanel writes: > > > Textures created by image load/store tests where not complete. > > Needed to set max level, to relax mip requirements. > > Load/Store on incomplete