Re: Re: [PHP] A Review Request

2011-05-20 Thread Peter Lind
On 20 May 2011 11:20, Tim Streater wrote: *snip* > [...] is marked as being aimed at the novice, and at the same time lists some > of the areas that deliberately haven't been addressed in the example > provided, then that should suffice. > Apart from the above that would make great additions,

Re: Re: [PHP] A Review Request

2011-05-20 Thread Tim Streater
On 19 May 2011 at 23:47, Adam Richardson wrote: > You did make several other great points (session hijacking, multiple login > attempts), but to be fair to Tedd, there are many levels of security, and I > doubt he's trying to educate PHP developers with your background. In the > same way that so

Re: Re: [PHP] A Review Request

2011-05-20 Thread Tim Streater
On 20 May 2011 at 04:03, Alex Nikitin wrote: > but here is a brief example: > > (!DEBUG) || error_log("Fetch Data: ".memory_get_usage()/1048576); > > reads and writes a lot better and faster then: > > if(DEBUG) { >$memory = memory_get_usage()/1048576; >error_log("Fetch Data: ".$memory);

Re: Re: [PHP] A Review Request

2011-05-18 Thread tedd
At 2:44 PM -0700 5/18/11, David Harkness wrote: On Wed, May 18, 2011 at 2:38 PM, Peter Lind <peter.e.l...@gmail.com> wrote: As is probably clear by now, in my opinion it would be much better to go the motions of the script a bit at a time, with comments of *why* t

Re: Re: [PHP] A Review Request

2011-05-18 Thread David Harkness
On Wed, May 18, 2011 at 2:38 PM, Peter Lind wrote: > As is probably clear by now, in my opinion it would be much better to > go the motions of the script a bit at a time, with comments of *why* > things are done (not *what* is done) - and why you really should spend > a bit more time learning abo

Re: Re: [PHP] A Review Request

2011-05-18 Thread Peter Lind
On 18 May 2011 23:28, Tim Streater wrote: > On 18 May 2011 at 22:22, Peter Lind wrote: > >> On 18 May 2011 23:12, tedd wrote: > >>> This is just one way to give-back. >> >> Suggesting people that they copypaste your code is a very bad way of >> giving back. Suggesting that they read and understa

Re: Re: [PHP] A Review Request

2011-05-18 Thread Tim Streater
On 18 May 2011 at 22:22, Peter Lind wrote: > On 18 May 2011 23:12, tedd wrote: >> This is just one way to give-back. > > Suggesting people that they copypaste your code is a very bad way of > giving back. Suggesting that they read and understand the code is a > great way. I hope you see the di

Re: Re: [PHP] A Review Request

2011-05-18 Thread Tim Streater
On 18 May 2011 at 20:31, Joshua Kehn wrote: > On May 18, 2011, at 3:22 PM, tedd wrote: >> What do you people think? > I can say I really don't like your bracing style. I completely disagree - having the braces lined up is the only way to go. Means I don't have to search all over creation for