Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c

2001-02-15 Thread Thies C. Arntzen
On Thu, Feb 15, 2001 at 01:47:46PM +0200, Zeev Suraski wrote: > At 13:01 15/2/2001, Thies C. Arntzen wrote: > >On Thu, Feb 15, 2001 at 04:17:06AM +0200, Zeev Suraski wrote: > > > This patch won't always work (it may cause the link not to be closed when > > > it's supposed to). I committed a diffe

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c

2001-02-15 Thread Zeev Suraski
At 13:01 15/2/2001, Thies C. Arntzen wrote: >On Thu, Feb 15, 2001 at 04:17:06AM +0200, Zeev Suraski wrote: > > This patch won't always work (it may cause the link not to be closed when > > it's supposed to). I committed a different patch to the CVS - can you > > under what circumstances? Wel

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c

2001-02-15 Thread Thies C. Arntzen
On Thu, Feb 15, 2001 at 12:01:35PM +0100, Thies C. Arntzen wrote: > On Thu, Feb 15, 2001 at 04:17:06AM +0200, Zeev Suraski wrote: > > This patch won't always work (it may cause the link not to be closed when > > it's supposed to). I committed a different patch to the CVS - can you > > unde

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c

2001-02-15 Thread Thies C. Arntzen
On Thu, Feb 15, 2001 at 04:17:06AM +0200, Zeev Suraski wrote: > This patch won't always work (it may cause the link not to be closed when > it's supposed to). I committed a different patch to the CVS - can you under what circumstances? > please check it? will do - tc > > At 18

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c

2001-02-14 Thread Zeev Suraski
This patch won't always work (it may cause the link not to be closed when it's supposed to). I committed a different patch to the CVS - can you please check it? At 18:54 13/2/2001, Thies C. Arntzen wrote: >thies Tue Feb 13 08:54:48 2001 EDT > > Modified files: > /php4/ext/pgsql

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c php_pgsql.h

2001-01-20 Thread Sascha Schumann
> Strange, I compiled it at home, and it gave me no troubles, must be a > wrong regexp to replace spaces by tabs then. I'll look into it later. Another issue is the lo_lseek() call. The third and fourth parameters are prototyped as int, but you are passing in char *. - Sascha

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c php_pgsql.h

2001-01-20 Thread Derick Rethans
On Sat, 20 Jan 2001, Sascha Schumann wrote: > > +PHP_FUNCTION(pg_lolseek) { > > + val **pgsql_lofp, **seek_offset, **seek_whence; > ^^^ > > + gLofp *pgsql; > ^ > > + long int offset; > .. > > + ffset = lo_tell((PGconn *)pgsql->conn, pgsql->lofd); > ^ > > + ETURN_LONG (of

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c php_pgsql.h

2001-01-20 Thread Sascha Schumann
> +PHP_FUNCTION(pg_lolseek) { > + val **pgsql_lofp, **seek_offset, **seek_whence; ^^^ > + gLofp *pgsql; ^ > + long int offset; .. > + ffset = lo_tell((PGconn *)pgsql->conn, pgsql->lofd); ^ > + ETURN_LONG (offset); ^ Derick, this patch is completely brok