Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c

2001-04-18 Thread Andi Gutmans
Why do you need that SEPARATE_ZVAL()? You seem to be using pv_row as read-only. Also can you please try not to commit \r\n but only \n? Thanks, Andi At 02:31 AM 4/19/2001 +, Dan Kalowsky wrote: >kalowskyWed Apr 18 19:31:23 2001 EDT > > Modified files: > /php4/ext/odbc

Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c

2001-04-17 Thread Sterling Hughes
On Tue, 17 Apr 2001, Jani Taskinen wrote: > On Mon, 16 Apr 2001, Sterling Hughes wrote: > > >> > >> -#ifndef HAVE_DBMAKER > >> - if ((*pv_onoff)) { > >> -#else > >>if (pv_onoff && (*pv_onoff)) { > >> -#endif > >>convert_to_long_ex(pv_onoff); > >>rc = SQLSetConnectOpti

Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c

2001-04-16 Thread Jani Taskinen
On Mon, 16 Apr 2001, Sterling Hughes wrote: >> >> -#ifndef HAVE_DBMAKER >> -if ((*pv_onoff)) { >> -#else >> if (pv_onoff && (*pv_onoff)) { >> -#endif >> convert_to_long_ex(pv_onoff); >> rc = SQLSetConnectOption(conn->hdbc, SQL_AUTOCOMMIT, >>

Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c

2001-04-16 Thread Dan Kalowsky
> This should be breaking something, no? > > Either way an "if" statement is started therefore it needs to be finished. it's there, it's just the next line down (didn't make it into the cvs diff as i didn't change it) honest! it should be seen in the file as: rc = SQLSetConnectOption(conn->h

Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c

2001-04-16 Thread Sterling Hughes
On Tue, 17 Apr 2001, Dan Kalowsky wrote: > kalowsky Mon Apr 16 19:02:36 2001 EDT > > Modified files: > /php4/ext/odbcphp_odbc.c > Log: > This change seems to fix bugs 7158, 7807, 8531, and 8636. After asking why this >patch was applied no one seemed to respond with an

Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c php_odbc.h

2001-01-14 Thread Sebastian Bergmann
Stig Bakken wrote: > ssb Sun Jan 14 17:11:06 2001 EDT > > Modified files: > /php4/ext/odbc php_odbc.c php_odbc.h > Log: > @- Added odbc_error() and odbc_errormsg() functions (Stig) PHP 4 does not build on Win32 after this patch: php_odbc.c D:\Programme\MS Visual Stu