Re: [PHP] sapi_add_header_ex() violating CODING_STANDARDS

2007-04-03 Thread js
Hi Jochem. On 4/3/07, Jochem Maas <[EMAIL PROTECTED]> wrote: from your explaination above one could infer that it was a transgression with regard to CS. whether you could consider it a bug would depend on whether the code in question actually caused problems or not ... the efree() at the point

Re: [PHP] sapi_add_header_ex() violating CODING_STANDARDS

2007-04-03 Thread Jochem Maas
js wrote: > Hi list. > > I don't think this is the right place to talk about this, > but writing PHP extensions I found that "sapi_add_header_ex()" in SAPI.c > is violating a law of PHP CODING_STANDARDS, which says > > "[1] Functions that are given pointers to resources should not free them > *sn

[PHP] sapi_add_header_ex() violating CODING_STANDARDS

2007-04-03 Thread js
Hi list. I don't think this is the right place to talk about this, but writing PHP extensions I found that "sapi_add_header_ex()" in SAPI.c is violating a law of PHP CODING_STANDARDS, which says "[1] Functions that are given pointers to resources should not free them *snip* Exceptions: - The fu