Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-20 Thread Hilaire
It is a go here. Thanks Le 21/06/2017 à 04:56, Ben Coman a écrit : > This is strange, since the slice upload seemed to go smoothly, if a bit > slow - but no errors. > I've uploaded the missing mcz, so the existing slice should now work. > > cheers -ben > -- Dr. Geo http://drgeo.eu

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-20 Thread Ben Coman
This is strange, since the slice upload seemed to go smoothly, if a bit slow - but no errors. I've uploaded the missing mcz, so the existing slice should now work. cheers -ben On Wed, Jun 21, 2017 at 12:45 AM, Sven Van Caekenberghe wrote: > It is not, Ben has to redo his slice. > > > On 20 Jun

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-20 Thread Sven Van Caekenberghe
It is not, Ben has to redo his slice. > On 20 Jun 2017, at 18:29, Stephane Ducasse wrote: > > Did you check if the file is in the inbox repo? > > Stef > > On Tue, Jun 20, 2017 at 2:21 PM, Hilaire wrote: >> Almost there... >> >> Le 20/06/2017 à 05:05, Ben Coman a écrit : >>> @Hilaire, could y

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-20 Thread Stephane Ducasse
Did you check if the file is in the inbox repo? Stef On Tue, Jun 20, 2017 at 2:21 PM, Hilaire wrote: > Almost there... > > Le 20/06/2017 à 05:05, Ben Coman a écrit : >> @Hilaire, could you test the slice? >> > > -- > Dr. Geo > http://drgeo.eu

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-20 Thread Hilaire
Almost there... Le 20/06/2017 à 05:05, Ben Coman a écrit : > @Hilaire, could you test the slice? > -- Dr. Geo http://drgeo.eu

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-19 Thread Stephane Ducasse
Thx guys! We will tag it for a port back to Pharo60. On Tue, Jun 20, 2017 at 5:05 AM, Ben Coman wrote: > > On Mon, Jun 19, 2017 at 8:00 PM, David T. Lewis wrote: >> >> 20167 > > > Thanks Dave. I've cherry-picked those into an integration slice, but I > don't have 64-bit to test on. > @Hilaire,

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-19 Thread Ben Coman
On Mon, Jun 19, 2017 at 8:00 PM, David T. Lewis wrote: > 20167 Thanks Dave. I've cherry-picked those into an integration slice, but I don't have 64-bit to test on. @Hilaire, could you test the slice? cheers -ben

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-19 Thread David T. Lewis
I opened new issue 20167 for this. Dave On Mon, Jun 19, 2017 at 08:10:20AM +0200, Stephane Ducasse wrote: > Thanks David. > Once hilaire confirms it can you create a bug entry in pharo bug tracker? > > S. > > On Sun, Jun 18, 2017 at 9:37 PM, David T. Lewis wrote: > > Hi Hilaire, > > > > I con

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-19 Thread Hilaire
Hi David, Steph, The fix works fine on P6 64 bits too! Thanks Hilaire Le 19/06/2017 à 08:10, Stephane Ducasse a écrit : > Thanks David. > Once hilaire confirms it can you create a bug entry in pharo bug tracker? > > S. -- Dr. Geo http://drgeo.eu

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread David T. Lewis
Hi Hilaire, I confirmed this on Squeak, and added a new test based on your example. The test is at http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194766.html, and the fix is http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-June/194767.html I did not check a Phar

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread Hilaire
As a matter of fact, if I drop the original PNG picture in the 64bits image , it is decoded fine (I am not sure however both the png file and the bytearray are exactly the same) It may seems the problem comes from the Byte array representation, just blind guess. Le 18/06/2017 à 16:09, Hilaire a

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread Hilaire
Le 18/06/2017 à 15:39, Stephane Ducasse a écrit : > what do you mean exactly. Is it working or not? It is not working on 64 bits image/vm > and where would be problem to fix. No idea -- Dr. Geo http://drgeo.eu

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread kmo
Just to confirm - I've tried it - works fine in Linux 32 bit VM - but fails with the 64 bit VM -- View this message in context: http://forum.world.st/Regression-with-PNGReaderWriter-in-P6-tp4951796p4951803.html Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread Stephane Ducasse
Hilaire what do you mean exactly. Is it working or not? and where would be problem to fix. Stef On Sun, Jun 18, 2017 at 2:16 PM, Hilaire wrote: > Aha, so I understand why you have all icons displayed just fine > Some arrays are decoded fine, but most are not. > > Damn it. > > Anyway the attache

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread Hilaire
Aha, so I understand why you have all icons displayed just fine Some arrays are decoded fine, but most are not. Damn it. Anyway the attached example will be fine for a unit test. Le 18/06/2017 à 14:12, Nicolai Hess a écrit : > > Works for me in windows 32. > Maybe it is an 32/64 bit vm issue ?

Re: [Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread Nicolai Hess
2017-06-18 14:01 GMT+02:00 Hilaire : > The code bellow decodes the PNG picture just fine in P3, in P6 it can't! > > I suspect changes in PNGReaderWriter>>nextImage > However the version shows no history of edit :( > > One should add this code below in a test for PNG. > > > PNGReadWriter createAFor

[Pharo-users] Regression with PNGReaderWriter in P6

2017-06-18 Thread Hilaire
The code bellow decodes the PNG picture just fine in P3, in P6 it can't! I suspect changes in PNGReaderWriter>>nextImage However the version shows no history of edit :( One should add this code below in a test for PNG. PNGReadWriter createAFormFrom: #(137 80 78 71 13 10 26 10 0 0 0 13 73 72 68