Re: [Pharo-users] Monticello review web application

2015-02-04 Thread mikefilonov
If the app is useful I will go on with the development. I have following roadmap in my mind: * REST API so review can be created automatically * Mail notifications * List of reviewers * Review state like "approved, denied", minimum number of approves need to for review to "pass" * Comment linked t

Re: [Pharo-users] Monticello review web application

2015-02-04 Thread Sven Van Caekenberghe
> On 04 Feb 2015, at 09:46, Marcus Denker wrote: > > >> On 04 Feb 2015, at 09:33, Sven Van Caekenberghe wrote: >> >> Hi Mike, >> >> I just tried your application and it works well. Simple but effective. >> > > One question: Could we benefit from that for daily review of Pharo fixes? I don

Re: [Pharo-users] Monticello review web application

2015-02-04 Thread Marcus Denker
> On 04 Feb 2015, at 09:33, Sven Van Caekenberghe wrote: > > Hi Mike, > > I just tried your application and it works well. Simple but effective. > One question: Could we benefit from that for daily review of Pharo fixes? > It is of course sometimes a bit hard to get to an actual URL ;-) >

Re: [Pharo-users] Monticello review web application

2015-02-04 Thread Sven Van Caekenberghe
Hi Mike, I just tried your application and it works well. Simple but effective. It is of course sometimes a bit hard to get to an actual URL ;-) Good work. Sven > On 04 Feb 2015, at 02:33, mikefilonov wrote: > >> Where you tool takes its input? > > The tool requires a full URL to mcz packa

Re: [Pharo-users] Monticello review web application

2015-02-03 Thread mikefilonov
> Where you tool takes its input? The tool requires a full URL to mcz package file for both base and target versions. This allows to compare versions on different locations. I attached the screenshot of the form : You may easi

Re: [Pharo-users] Monticello review web application

2015-02-03 Thread stepharo
What I would love is to bind it with epicea. The users can comment the files. What is cool with Epicea is that a change has semantics and a before and after state. Finally often you do a change (composed of different modifications) and that you do not want to see all the modifications one by on

Re: [Pharo-users] Monticello review web application

2015-02-03 Thread stepharo
Excellent We were discussing with alberto and martin about a tool to support code review :) Le 3/2/15 18:41, mikefilonov a écrit : Hello, I had some spare time and I built a prototype web application for comparing Monticello versions. I developed it using Seaside and Monticello version diff im

[Pharo-users] Monticello review web application

2015-02-03 Thread mikefilonov
Hello, I had some spare time and I built a prototype web application for comparing Monticello versions. I developed it using Seaside and Monticello version diff implementation in Pharo. It was super easy to reuse the classes which are responsible for downloading, comparing and generating diffs of