Re: [Pharo-users] Lint Rule for Class-Side Method

2016-09-09 Thread Yuriy Tymchuk
Hi, so in Pharo 5 CriticBrowser does not care about #checksClass, #checksMethod and so on. I am changing this in Pharo 6, but I didn’t have enough time for Pharo 5. For CriticBrowser you need to override instance-side methods #checkClass: or #checkMethod:. In your case you want to override #ch

Re: [Pharo-users] Lint Rule for Class-Side Method

2016-09-07 Thread Sean P. DeNigris
Uko2 wrote > Ok, can you also, please, clarify which version of Pharo are you using? Sure, sorry for the vague report. Pharo 5 - Cheers, Sean -- View this message in context: http://forum.world.st/Lint-Rule-for-Class-Side-Method-tp4914121p4914682.html Sent from the Pharo Smalltalk Users ma

Re: [Pharo-users] Lint Rule for Class-Side Method

2016-09-07 Thread Yuriy Tymchuk
> On 07 Sep 2016, at 23:41, Sean P. DeNigris wrote: > > Uko2 wrote >> What are you using to obtain critiques? > > CriticBrowser Ok, can you also, please, clarify which version of Pharo are you using? > > > > - > Cheers, > Sean > -- > View this message in context: > http://forum.world.

Re: [Pharo-users] Lint Rule for Class-Side Method

2016-09-07 Thread Sean P. DeNigris
Uko2 wrote > What are you using to obtain critiques? CriticBrowser - Cheers, Sean -- View this message in context: http://forum.world.st/Lint-Rule-for-Class-Side-Method-tp4914121p4914674.html Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Re: [Pharo-users] Lint Rule for Class-Side Method

2016-09-06 Thread Yuriy Tymchuk
Hi, sorry for late reply. What are you using to obtain critiques? QualityAssistnat? CriticBrowser? Cheers. Uko > On 06 Sep 2016, at 19:06, Sean P. DeNigris wrote: > > Sean P. DeNigris wrote >> I'm probably missing something obvious, but it seems like #checksMethod >> Lint Rules only get check

Re: [Pharo-users] Lint Rule for Class-Side Method

2016-09-06 Thread Sean P. DeNigris
Sean P. DeNigris wrote > I'm probably missing something obvious, but it seems like #checksMethod > Lint Rules only get checked against instance-side methods. How does one > check class-side methods? I converted it to a #checksClass rule, but then > hits showed the class definition instead of the of

[Pharo-users] Lint Rule for Class-Side Method

2016-09-04 Thread Sean P. DeNigris
I'm probably missing something obvious, but it seems like #checksMethod Lint Rules only get checked against instance-side methods. How does one check class-side methods? I converted it to a #checksClass rule, but then hits showed the class definition instead of the offending method source. Thanks.