Re: [Pharo-users] Grease stream tests failing on Pharo7

2018-07-24 Thread Johan Brichau
Hi, I reported the issue here: https://pharo.fogbugz.com/f/cases/22281/ReadWriteStream-broken Johan > On 23 Jul 2018, at 20:12, Johan Brichau wrote: > > Hi Richard, > > Thanks for pointing out the difference between #on: and #w

Re: [Pharo-users] Grease stream tests failing on Pharo7

2018-07-23 Thread Johan Brichau
Hi Richard, Thanks for pointing out the difference between #on: and #with: instance creation methods. This lead me to discover that ReadWriteStream>>on: strangely sets the readLimit instvar to the end… which is not what I would expect. Removing that method and reversing the change in the commit

Re: [Pharo-users] Grease stream tests failing on Pharo7

2018-07-23 Thread Richard O'Keefe
(ReadWriteStream on: 'abc') contents ==> 'abc' in GNU Smalltalk and Dolphin ==> '' in Squeak 6.0 and ST/X Here I think we see why ANSI Smalltalk defined #with: for {Read,}WriteStreams but not #on:. When you recall that ReadWriteStream is a subclass of WriteStream in most Smalltalks, and that (Wri

Re: [Pharo-users] Grease stream tests failing on Pharo7

2018-07-23 Thread Johan Brichau
Hi, As I’m diving into the changes and why it fails: (ReadWriteStream on: ‘abc’) contents -> = ‘abc’ on Pharo 6 -> = ‘’ on Pharo 7 That seems wrong to me. (I’ve also sent this question via github on the commit itself https://github.com/pharo-project/pharo/commit/9e442addff3790af0c78dbc73f1f349

[Pharo-users] Grease stream tests failing on Pharo7

2018-07-22 Thread Johan Brichau
Hi, I am taking a look at making Grease and Seaside work correctly on Pharo7. There have been a number of changes to the ReadWriteStream implementation in Pharo that break Grease tests: https://travis-ci.org/SeasideSt/Grease/jobs/406766720