Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2019-01-01 Thread Tudor Girba via Pharo-users
--- Begin Message --- Nice work. Doru > On Dec 30, 2018, at 10:13 PM, Stephane Ducasse > wrote: > > Hello Fellow Pharoers > > I'm happy to announce a new little book to improve the culture around Pharo. > I will revise it in the future so you can feel free to send feedback > and pull reques

Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2019-01-01 Thread Sven Van Caekenberghe via Pharo-users
--- Begin Message --- That is a useful contribution, thank you (again) for your efforts ! > On 30 Dec 2018, at 22:13, Stephane Ducasse wrote: > > Hello Fellow Pharoers > > I'm happy to announce a new little book to improve the culture around Pharo. > I will revise it in the future so you can fe

Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2019-01-01 Thread Tim Mackinnon via Pharo-users
--- Begin Message --- I’ve always felt the XP book nailed it - don’t use comments as a crutch to avoid fixing confusing code and don’t do work twice by simply writing a comment that says the same as the code. (You can of course try to write the comment and auto-generate the code, but we’ve tried

Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2019-01-01 Thread Alistair Grant via Pharo-users
--- Begin Message --- Hi Richard, On Tue, 1 Jan 2019 at 07:26, Richard O'Keefe wrote: > > ... > > To get an example, I did (String allSelectors atRandom), getting > #copyWithoutAll:. That has only one definition, in Collection: >copyWithoutAll: aCollection > "Answer a copy of the receiver th

Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2018-12-31 Thread Richard O'Keefe
I'm not sure that the advice on method comments is as good as it could be. Consider Point >> setX: xValue setY: yValue x := xValue. y := yValue It is pretty obvious what this does, and if I'm reading chapter 4 correctly the advice is that it doesn't need a comment. But it does: why DOESN'T th

Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2018-12-31 Thread Richard O'Keefe
On naming protocols: it would be nice to have clear guidance about when to use '-ion' and when to use '-ing'. In my own code I've been using '-ing' except for a few traditional categories like 'instance creation'. One reason for this was that I didn't want to keep on re-deciding "is it 'enumerati

Re: [Pharo-users] [Pharo-dev] New book: Pharo with Style

2018-12-31 Thread Benoit St-Jean via Pharo-users
--- Begin Message --- Besides, I forgot to add one comment : you should have guidelines for protocol naming.  It's not critical per se but I find it quite annoying to look for stuff in "enumerating" when it's been put in "printing" !  loll On 2018-12-31 03:51, Stephane Ducasse wrote: Thanks! T