[HACKERS] add line number as prompt option to psql

2014-06-12 Thread Sawada Masahiko
lowing. <http://www.postgresql.org/message-id/cafj8prc1rupk6+cha1jpxph3us_zipabdovmceex4wpbp2k...@mail.gmail.com> Please give me feedback. Regards, --- Sawada Masahiko psql-line-number_v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.o

Re: [HACKERS] Set new system identifier using pg_resetxlog

2014-06-25 Thread Sawada Masahiko
set it, which is useful for > automating some things... > > -- > Petr Jelinek http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > -- Regards, --- Sawada Masahiko

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-06-25 Thread Sawada Masahiko
#7 succeeded at 214 with fuzz 2 (offset 5 lines). Hunk #8 FAILED at 223. Hunk #9 succeeded at 374 with fuzz 1 (offset 35 lines). Hunk #10 FAILED at 360. Hunk #11 FAILED at 387. 3 out of 11 hunks FAILED -- saving rejects to file src/bin/scripts/vacuumdb.c.rej --- Sawada Masahiko On Friday, March

Re: [HACKERS] Set new system identifier using pg_resetxlog

2014-06-26 Thread Sawada Masahiko
cksum version: 0 Values to be changed: First log segment after reset:00010002 -- $ pg_resetxlog -s0 data Transaction log reset $ pg_controldata data | grep "Database system identifier" Database system identifier: 6029284919152642525 this p

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-01 Thread Sawada Masahiko
this way all process > get equal sharing of the task. > > > Thanks & Regards, > Dilip Kumar > I have executed latest patch. One question is that how to use --jobs option is correct? $ vacuumdb -d postgres --jobs=30 I got following error. vacuumdb: unrecognized option '--jobs=30' Try "vacuumdb --help" for more information. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-02 Thread Sawada Masahiko
On Wed, Jul 2, 2014 at 2:27 PM, Dilip kumar wrote: > On 01 July 2014 22:17, Sawada Masahiko Wrote, > > >> I have executed latest patch. >> One question is that how to use --jobs option is correct? >> $ vacuumdb -d postgres --jobs=30 >> >> I got following

Re: [HACKERS] add line number as prompt option to psql

2014-07-06 Thread Sawada Masahiko
On Fri, Jun 20, 2014 at 7:17 PM, Jeevan Chalke wrote: > Hi Sawada Masahiko, > > I liked this feature. So I have reviewed it. > > Changes are straight forward and looks perfect. > No issues found with make/make install/initdb/regression. > > However I would suggest removin

Re: [HACKERS] add line number as prompt option to psql

2014-07-09 Thread Sawada Masahiko
u for reviewing the patch. I have revised the patch, and attached. > A: > But with prompt line number feature, it should be sync to each other. This patch can handle this case. > B: > However, I see that you have removed the code changes related to INT_MAX. > Why? I had m

Re: [HACKERS] add line number as prompt option to psql

2014-07-10 Thread Sawada Masahiko
o mimic this I have initialized > newline = INT_MAX - 1. > Thank you for reviewing the patch with variable cases. I have revised the patch, and attached latest patch. > A: > Will you please explain the idea behind these changes ? I thought wrong about adding new to tail of query_buf. The

[HACKERS] timeout of pg_receivexlog --status-interval

2014-07-10 Thread Sawada Masahiko
and should execute select() function with NULL of fourth argument. the attached patch allows to execute select() with NULL, i.g., pg_receivexlog.c will wait until can read socket without timeout, if -s is specified to 0. Regards, ------- Sawada Masahiko receivexlog-timout.patch Description: Binary dat

Re: [HACKERS] add line number as prompt option to psql

2014-07-11 Thread Sawada Masahiko
e number of new lines to correctly adjust current line number" > > 2. > /* Avoid cur_line and newline exceeds the INT_MAX */ > > You are saying avoid cur_line AND newline, but there is no adjustment for > newline in the code following the comment. > > Thanks > -- > Jeevan B Chalke > Principal Software Engineer, Product Development > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > Thanks. I will fix it. -- Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] add line number as prompt option to psql

2014-07-11 Thread Sawada Masahiko
On Fri, Jul 11, 2014 at 11:01 PM, Alvaro Herrera wrote: > Jeevan Chalke wrote: > >> On Fri, Jul 11, 2014 at 3:13 PM, Sawada Masahiko >> wrote: > >> > And the line number should be switched to 1 when line number has >> > reached to INT_MAX? >> >>

Re: [HACKERS] timeout of pg_receivexlog --status-interval

2014-07-15 Thread Sawada Masahiko
On Tue, Jul 15, 2014 at 7:38 PM, Fujii Masao wrote: > On Thu, Jul 10, 2014 at 11:10 PM, Sawada Masahiko > wrote: >> Hi, >> >> At 1047 line of receivelog.c:CopyStreamPoll(), we set NULL to >> timeoutptr variable. >> if the value of timeoutprt is set NULL the

Re: [HACKERS] add line number as prompt option to psql

2014-08-14 Thread Sawada Masahiko
On Sat, Jul 12, 2014 at 2:19 AM, Alvaro Herrera wrote: > Sawada Masahiko wrote: > >> As you said, if line number reached UINT_MAX then I think that this >> case is too strange. >> I think INT_MAX is enough for line number. > > My point is not whether 2 billion is a b

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-15 Thread Sawada Masahiko
s fine. One question is why reply_fsync is defined as volatile variable? Sorry I could not understand reason of that. Currently patch modifies argument of some function (e.g., Handle CopyStream, Process LogDate Msg), and add the similar code to each function. I don't think it is good approach. For ex

Re: PENDING_LIST_CLEANUP_SIZE - maximum size of GIN pending list Re: [HACKERS] HEAD seems to generate larger WAL regarding GIN index

2014-08-16 Thread Sawada Masahiko
ecrease it >> otherwise. >> >> This patch uses another patch that I proposed (*1) as an infrastructure. >> Please apply that infrastructure patch first if you apply this patch. >> >> (*1) >> http://www.postgresql.org/message-id/CAHGQGwEanQ_e8WLHL2

[HACKERS] After switching primary server while using replication slot.

2014-08-18 Thread Sawada Masahiko
on, I think that we should make master server to notify about removal of WAL segment to all standby servers. And the standby servers recycle WAL segments files base on that information. Thought? -- Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-18 Thread Sawada Masahiko
get error with applying, and compiling. It works fine. I think this function code has no problem. Could you please submit patch to commit fest app? Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-29 Thread Sawada Masahiko
On Tue, Jul 21, 2015 at 3:50 PM, Michael Paquier wrote: > On Mon, Jul 20, 2015 at 9:59 PM, Beena Emerson > wrote: >> Simon Riggs wrote: >> >>> The choice between formats is not >>> solely predicated on whether we have multi-line support. >> >>> I still think writing down some actual use cases wo

[HACKERS] Comment typo in src/backend/command/cluster.c

2014-01-20 Thread Sawada Masahiko
Hi all, Attached patch fixes the typo which is in "src/backend/command/cluster.c". Regards, --- Sawada Masahiko fix_typo-cluster.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscrip

Re: [HACKERS] Add force option to dropdb

2014-01-27 Thread Sawada Masahiko
that need specific line breaks should be formatted as block comments, where the comment starts as /*--.) Please refer to coding rule. <http://wiki.postgresql.org/wiki/Developer_FAQ#What.27s_the_formatting_style_used_in_PostgreSQL_source_code.3F> Regards, --- Sawada Masahiko -- Se

[HACKERS] Fix comment typo in /src/backend/command/cluster.c

2014-01-27 Thread Sawada Masahiko
Hi all, Attached patch fixes the typo which is in "src/backend/command/cluster.c". Regards, --- Sawada Masahiko fix_typo-cluster.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscrip

Re: [HACKERS] Fix comment typo in /src/backend/command/cluster.c

2014-01-27 Thread Sawada Masahiko
> > On 01/27/2014 10:24 PM, Sawada Masahiko wrote: > >> Hi all, >> >> Attached patch fixes the typo which is in "src/backend/command/cluster. >> c". >> >> > > Are you sure that's a typo? "iff" is usually short hand for &qu

Re: [HACKERS] Add force option to dropdb

2014-01-29 Thread Sawada Masahiko
to > fix it > Regards > > > On Tuesday, January 28, 2014 4:17 AM, Sawada Masahiko > wrote: > On 2014年1月17日 0:56, salah jubeh wrote: >> >>>If the user owns objects, that will prevent this from working also. I >>>have the feeling that adding DROP OWNED BY a

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-31 Thread Sawada Masahiko
On Tue, Jan 21, 2014 at 7:17 AM, Oskari Saarenmaa wrote: > 18.11.2013 07:53, Sawada Masahiko kirjoitti: >>> >>> On 13 Nov 2013, at 20:51, Mika Eloranta wrote: >>>> >>>> Prevent excessive progress reporting that can grow to gigabytes >>>>

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-02-02 Thread Sawada Masahiko
On Sat, Feb 1, 2014 at 8:29 PM, Oskari Saarenmaa wrote: > 31.01.2014 10:59, Sawada Masahiko kirjoitti: > > I think the idea in the new progress_report() call (with force == true) is > to make sure that there is at least one progress_report call that actually > writes the

[HACKERS] 'dml' value for log_statement

2014-02-06 Thread Sawada Masahiko
n if we would like to log only DML. This patch allows the user to set in detail the setting. The server logs statement only when INSERT. UPDATE, DELETE and TRUNCATE statement are executed. ( same as 'mod' value which does not log the DDL) Comments? Regards, --- Sawada Masahi

[HACKERS] pg_basebackup skips pg_replslot directory

2014-02-17 Thread Sawada Masahiko
not start. I got following FATAL error when the standby server starts. FATAL: could not open directory "pg_replslot": No such file or directory Is this a bug? Attached file solves it by including pg_replslot directory as empty directory. Please give feedback. Regards, --- Sawad

Re: [HACKERS] pg_basebackup skips pg_replslot directory

2014-02-17 Thread Sawada Masahiko
On Tue, Feb 18, 2014 at 2:07 AM, Andres Freund wrote: > Hi, > > On 2014-02-18 02:01:58 +0900, Sawada Masahiko wrote: >> I found strange behavior of PostgreSQL of HEAD while using pg_basebackup. >> pg_basebackup skips pg_replslot directory since >> 858ec11858a914d4c380

[HACKERS] The behavior of CheckRequiredParameterValues()

2014-03-04 Thread Sawada Masahiko
wal_level(i.g., hot_standby) if we want to enable hot standby. In this case, I think that the standby server didn't need to confirm wal_level value of ControlFile. I think that it should confirm value which is written in postgreql.conf. I might be missing something. Please let me know tha

Re: [HACKERS] The behavior of CheckRequiredParameterValues()

2014-03-05 Thread Sawada Masahiko
On Wed, Mar 5, 2014 at 5:13 PM, Amit Langote wrote: > On Wed, Mar 5, 2014 at 12:07 PM, Amit Langote wrote: >> On Wed, Mar 5, 2014 at 2:09 AM, Sawada Masahiko >> wrote: >> >>> >>> xlog.c:6177 >>> if (ControlFile->wal_le

[HACKERS] Parsing bool type value

2013-08-20 Thread Sawada Masahiko
uot; and the setting value in parse_bool_with_len() function. Should we deny the "of" value as bool type value? Regards, --- Sawada Masahiko parse_bool_with_len.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

Re: [HACKERS] Parsing bool type value

2013-08-20 Thread Sawada Masahiko
On Tue, Aug 20, 2013 at 11:53 PM, Amit Kapila wrote: > On Tue, Aug 20, 2013 at 1:11 PM, Sawada Masahiko > wrote: >> Hi all, >> >> Taking a look at PostgreSQL HEAD today, I noticed that currently >> PostgreSQL allows "of" value as bool type value.

[HACKERS] Behaviour of take over the synchronous replication

2013-08-23 Thread Sawada Masahiko
ould become potential server. What am I missing? Please give me feedback. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Behaviour of take over the synchronous replication

2013-08-24 Thread Sawada Masahiko
On Sat, Aug 24, 2013 at 3:14 AM, Josh Berkus wrote: > On 08/23/2013 12:42 AM, Sawada Masahiko wrote: >> in case (a), those priority is clear. So I think that re-taking over >> is correct behaviour. >> OHOT, in case (b), even if AAA and BBB are set same priority, AAA

Re: [HACKERS] Patch for fail-back without fresh backup

2013-08-25 Thread Sawada Masahiko
On Sat, Aug 24, 2013 at 11:38 PM, Peter Eisentraut wrote: > On Thu, 2013-07-11 at 23:42 +0900, Sawada Masahiko wrote: >> please find the attached patch. > > Please fix these compiler warnings: > > xlog.c:3117:2: warning: implicit declaration of function ‘SyncRepWaitForLSN’ &

Re: [HACKERS] Behaviour of take over the synchronous replication

2013-08-27 Thread Sawada Masahiko
On Sun, Aug 25, 2013 at 3:21 PM, Amit Kapila wrote: > On Sat, Aug 24, 2013 at 2:46 PM, Sawada Masahiko > wrote: >> On Sat, Aug 24, 2013 at 3:14 AM, Josh Berkus wrote: >>> On 08/23/2013 12:42 AM, Sawada Masahiko wrote: >>>> in case (a), those priority is clea

Re: [HACKERS] Behaviour of take over the synchronous replication

2013-08-27 Thread Sawada Masahiko
'catchup'. IWO 'AAA' doesn't has authority to operate the queue. 'BBB' server is preferred sync standby server while 'AAA' wal sender state is 'catchup'. So even if user execute query, master server doesn't freeze commits When '

Re: [HACKERS] Behaviour of take over the synchronous replication

2013-08-29 Thread Sawada Masahiko
On Wed, Aug 28, 2013 at 10:59 PM, Amit Kapila wrote: > On Tue, Aug 27, 2013 at 4:51 PM, Sawada Masahiko > wrote: >> On Sun, Aug 25, 2013 at 3:21 PM, Amit Kapila wrote: >>> On Sat, Aug 24, 2013 at 2:46 PM, Sawada Masahiko >>> wrote: >>>> On Sat, A

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-12 Thread Sawada Masahiko
ning: variable ‘numdataflush’ set but not used > [-Wunused-but-set-variable] > Sorry I forgot fix it. I have attached the patch which I modified. Regards, --- Sawada Masahiko synchronous_transfer_v6.patch Description: Binary data -- Sent via pgsql-hackers mailing list (

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-17 Thread Sawada Masahiko
standby, it can resolve the data page inconsistency > between > two standbys? > Currently patch supports the case which two servers are set up SYNC replication. IWO, failback safe standby is the same as SYNC replication standby. User can set synchronous_transfer in only master side.

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-17 Thread Sawada Masahiko
On Wed, Sep 18, 2013 at 11:45 AM, Fujii Masao wrote: > On Wed, Sep 18, 2013 at 10:35 AM, Sawada Masahiko > wrote: >> On Tue, Sep 17, 2013 at 9:52 PM, Fujii Masao wrote: >>> I set up synchronous replication with synchronous_transfer = all, and then >>> I r

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-17 Thread Sawada Masahiko
On Wed, Sep 18, 2013 at 1:05 PM, Sawada Masahiko wrote: > On Wed, Sep 18, 2013 at 11:45 AM, Fujii Masao wrote: >> On Wed, Sep 18, 2013 at 10:35 AM, Sawada Masahiko >> wrote: >>> On Tue, Sep 17, 2013 at 9:52 PM, Fujii Masao wrote: >>>> I set up synchronous r

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-18 Thread Sawada Masahiko
On Wed, Sep 18, 2013 at 11:45 AM, Fujii Masao wrote: > On Wed, Sep 18, 2013 at 10:35 AM, Sawada Masahiko > wrote: >> On Tue, Sep 17, 2013 at 9:52 PM, Fujii Masao wrote: >>> I set up synchronous replication with synchronous_transfer = all, and then >>> I r

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-19 Thread Sawada Masahiko
On Thu, Sep 19, 2013 at 12:25 PM, Fujii Masao wrote: > On Thu, Sep 19, 2013 at 11:48 AM, Sawada Masahiko > wrote: >> I attached the patch which I have modified. > > Thanks for updating the patch! > > Here are the review comments: > Thank you for reviewing! &

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-19 Thread Sawada Masahiko
On Thu, Sep 19, 2013 at 7:32 PM, Fujii Masao wrote: > On Thu, Sep 19, 2013 at 7:07 PM, Sawada Masahiko > wrote: >> On Thu, Sep 19, 2013 at 12:25 PM, Fujii Masao wrote: >>> On Thu, Sep 19, 2013 at 11:48 AM, Sawada Masahiko >>> wrote: >>>>

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-22 Thread Sawada Masahiko
lue in transaction, other process (e.g. checkpointer process) can't confirm it. Currently patch, each processes uses locally synchronous_commit. Regards, --- Sawada Masahiko synchronous_transfer_v10.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-27 Thread Sawada Masahiko
bys listed under synchronous_standbys are really *async* > standbys with failback safety. > Thank you for comment. I think it is good simple idea. In your opinion, if synchronous_transfer is set 'all' and synchronous_commit is set 'on', the master wait for data flush eve if user sets s

Re: [HACKERS] Patch for fail-back without fresh backup

2013-09-27 Thread Sawada Masahiko
On Fri, Sep 27, 2013 at 5:18 PM, Pavan Deolasee wrote: > On Fri, Sep 27, 2013 at 1:28 PM, Sawada Masahiko > wrote: >> >> >> > >> >> Thank you for comment. I think it is good simple idea. >> In your opinion, if synchronous_transfer is set 'all

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-03 Thread Sawada Masahiko
On Fri, Sep 27, 2013 at 6:44 PM, Sawada Masahiko wrote: > On Fri, Sep 27, 2013 at 5:18 PM, Pavan Deolasee > wrote: >> On Fri, Sep 27, 2013 at 1:28 PM, Sawada Masahiko >> wrote: >>> >>> >>> > >>> >>> Thank you fo

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-08 Thread Sawada Masahiko
cRepWaitForLSN(lsn, true, true); > > If smgr_redo() is called only during recovery, SyncRepWaitForLSN() doesn't > need > to be called here. Thank you for info. I have removed it at smgr_redo(). Regards, --- Sawada Masahiko synchronous_transfer_v12.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-08 Thread Sawada Masahiko
On Tue, Oct 8, 2013 at 6:37 PM, Pavan Deolasee wrote: > > On Tue, Oct 8, 2013 at 2:33 PM, Sawada Masahiko > wrote: >> >> On Fri, Oct 4, 2013 at 4:32 PM, Fujii Masao wrote: >> > >> I attached the v12 patch which have modified based on above suggestions. >

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-08 Thread Sawada Masahiko
On Tue, Oct 8, 2013 at 6:46 PM, Andres Freund wrote: > On 2013-10-08 15:07:02 +0530, Pavan Deolasee wrote: >> On Tue, Oct 8, 2013 at 2:33 PM, Sawada Masahiko wrote: >> >> > On Fri, Oct 4, 2013 at 4:32 PM, Fujii Masao wrote: >> > > >> > I attached the

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-21 Thread Sawada Masahiko
ght? > > We will definitely need some amount of performance benchmarks even if this > is optional. But are there other things to worry about ? Any strong > objections to this idea or any other stow stopper for pg_rewind itself ? > -- Regards, --- Sawada Masahiko -- Se

Re: [HACKERS] Patch for fail-back without fresh backup

2013-10-24 Thread Sawada Masahiko
including the block number of the changed block. I think that writing log is not lead huge overhead increase. Is those WAL record replicated to the standby server in synchronous ( of course when configuring sync replication)? I am concerned that it lead performance overhead with such as executing SE

Re: [HACKERS] Patch for fail-back without fresh backup

2013-11-02 Thread Sawada Masahiko
_rewind? Is there for anything else? (Sorry it might has already been discussed..) Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or < 3) character LIKE queries

2013-05-30 Thread Sawada Masahiko
2013/5/31 Amit Langote > > On Thu, May 30, 2013 at 11:47 PM, Robert Haas wrote: > > On Wed, May 29, 2013 at 10:51 PM, Amit Langote > > wrote: > >> So, it appears, for search strings consisting of 2 (or < 3) > >> characters, trigrams can not be utilized. No? > > > > I think that's right. "trigr

Re: [HACKERS] Behavior of a pg_trgm index for 2 (or < 3) character LIKE queries

2013-05-31 Thread Sawada Masahiko
On Fri, May 31, 2013 at 11:16 AM, Amit Langote wrote: > On Fri, May 31, 2013 at 4:25 AM, Alexander Korotkov > wrote: >> On Thu, May 30, 2013 at 12:49 PM, Sawada Masahiko >> wrote: >>> >>> following emails are discussed about partial match of pg_trgm. I ho

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-15 Thread Sawada Masahiko
ere is inconsistent data between those server when fail back. right? if so , there is not possible inconsistent. because if you use GUC option as his propose (i.g., failback_safe_standby_mode = remote_flush), when old master is working fine, all file system level changes aren't done before WAL replicated. -- Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-15 Thread Sawada Masahiko
On Sat, Jun 15, 2013 at 10:34 PM, Amit kapila wrote: > > On Saturday, June 15, 2013 1:19 PM Sawada Masahiko wrote: > On Fri, Jun 14, 2013 at 10:15 PM, Amit Kapila wrote: >> On Friday, June 14, 2013 2:42 PM Samrat Revagade wrote: >>> Hello, >> >>>> We

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-17 Thread Sawada Masahiko
On Sun, Jun 16, 2013 at 2:00 PM, Amit kapila wrote: > On Saturday, June 15, 2013 8:29 PM Sawada Masahiko wrote: > On Sat, Jun 15, 2013 at 10:34 PM, Amit kapila wrote: >> >> On Saturday, June 15, 2013 1:19 PM Sawada Masahiko wrote: >> On Fri, Jun 14, 2013 at 10:15 PM, Am

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-18 Thread Sawada Masahiko
On Tuesday, June 18, 2013, Amit Kapila wrote: > On Tuesday, June 18, 2013 12:18 AM Sawada Masahiko wrote: > > On Sun, Jun 16, 2013 at 2:00 PM, Amit kapila > > > > > > wrote: > > > On Saturday, June 15, 2013 8:29 PM Sawada Masahiko wrote: > > >

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-19 Thread Sawada Masahiko
On Tuesday, June 18, 2013, Amit Kapila wrote: > On Tuesday, June 18, 2013 12:18 AM Sawada Masahiko wrote: > > On Sun, Jun 16, 2013 at 2:00 PM, Amit kapila > > > > > > wrote: > > > On Saturday, June 15, 2013 8:29 PM Sawada Masahiko wrote: > > >

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-24 Thread Sawada Masahiko
each standby. For example : ---- [Server] standby_name = 'slave1' synchronous_transfer = commit wal_sender_timeout = 30 [Server] standby_name = 'slave2' synchronous_transfer = all wal_sender_timeout = 50 --- there are discussions about such ini file in past. if so, we can set each parameter to each standby. please give me feedback. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-25 Thread Sawada Masahiko
On Tue, Jun 25, 2013 at 12:19 PM, Pavan Deolasee wrote: > > > > On Mon, Jun 24, 2013 at 7:17 PM, Sawada Masahiko > wrote: >> >> >> >> >> [Server] >> standby_name = 'slave1' >> synchronous_transfer = comm

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-27 Thread Sawada Masahiko
On Mon, Jun 24, 2013 at 10:47 PM, Sawada Masahiko wrote: > 1. synchronous standby and make same as failback safe standby > 2. asynchronous standby and make same as failback safe standby > > in above case, adding new parameter might be meaningless. but I think > that we should handl

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-27 Thread Sawada Masahiko
oint LSN. if not, master will inform standby that failed. 3. standby will fork WAL, and apply WAL which is sent from master continuity. in this approach, user who want to dump from old master will set 'off' to follow_master_force and standby_mode, and gets the dump of old master after master started. OTOH, user who want to starts replication force will set 'on' to both parameter. please give me feedback. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for fail-back without fresh backup

2013-07-02 Thread Sawada Masahiko
On Tue, Jul 2, 2013 at 2:45 PM, Amit Kapila wrote: > On Friday, June 28, 2013 10:41 AM Sawada Masahiko wrote: >> On Wed, Jun 26, 2013 at 1:40 PM, Amit Kapila >> wrote: >> > On Tuesday, June 25, 2013 10:23 AM Amit Langote wrote: >> >> Hi, >> >> >

Re: [HACKERS] Patch for fail-back without fresh backup

2013-07-07 Thread Sawada Masahiko
synchronous_transfer = data_flush (synchronous_commit values is ignored) - default SYNC replication synchronous_transfer = commit synchronous_commit = on synchronous_standby_names = - default ASYNC replication synchronous_transfer = commit ToDo 1. currently this patch supports synchrono

Re: [HACKERS] Patch for fail-back without fresh backup

2013-07-07 Thread Sawada Masahiko
On Sun, Jul 7, 2013 at 4:19 PM, Sawada Masahiko wrote: > On Mon, Jun 17, 2013 at 8:48 PM, Simon Riggs wrote: >> On 17 June 2013 09:03, Pavan Deolasee wrote: >> >>> I agree. We should probably find a better name for this. Any suggestions ? >> >> err, I alread

Re: [HACKERS] Patch for fail-back without fresh backup

2013-07-09 Thread Sawada Masahiko
On Sun, Jul 7, 2013 at 4:27 PM, Sawada Masahiko wrote: > On Sun, Jul 7, 2013 at 4:19 PM, Sawada Masahiko wrote: >> On Mon, Jun 17, 2013 at 8:48 PM, Simon Riggs wrote: >>> On 17 June 2013 09:03, Pavan Deolasee wrote: >>> >>>> I agree. We should pr

Re: [HACKERS] Patch for fail-back without fresh backup

2013-07-11 Thread Sawada Masahiko
On Tue, Jul 9, 2013 at 11:45 PM, Sawada Masahiko wrote: > On Sun, Jul 7, 2013 at 4:27 PM, Sawada Masahiko wrote: > I found a bug which occurred when we do vacuum, and have fixed it. > yesterday (8th July) "Improve scalability of WAL insertions" patch is > committed to HEAD

Re: [HACKERS] Using ini file to setup replication

2013-07-22 Thread Sawada Masahiko
arameter(e.g., wal_sender_timeout) is not set in configure file(or postgresql,conf) like above, what value should we set value to parameter? and how we handle originally wal_sender_timeout? will it leave? or delete? Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@po

Re: [HACKERS] Using ini file to setup replication

2013-07-23 Thread Sawada Masahiko
gresql.conf. if include file doesn't exist, we would set default value to each wal sender. that is, we give up ini file, and we provide mechanism of setting to each wal sender as option of overwrite. of course to support this approach, it needs to use the patch which Andres suggested, and serve

[HACKERS] Condition to become the standby mode.

2013-07-25 Thread Sawada Masahiko
odeRequested) synchronous transfer discussion : http://www.postgresql.org/message-id/CAF8Q-Gy7xa60HwXc0MKajjkWFEbFDWTG=ggyu1kmt+s2xcq...@mail.gmail.com -- Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-03-11 Thread Sawada Masahiko
On Tue, Mar 10, 2015 at 5:05 PM, Jim Nasby wrote: > On 3/9/15 9:43 PM, Sawada Masahiko wrote: >> >> On Fri, Mar 6, 2015 at 11:07 AM, Jim Nasby >> wrote: >>> >>> On 3/2/15 10:58 AM, Sawada Masahiko wrote: >>>> >>>> >>>> O

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-03-11 Thread Sawada Masahiko
On Tue, Mar 10, 2015 at 12:08 PM, Stephen Frost wrote: > Sawada, > > * Sawada Masahiko (sawada.m...@gmail.com) wrote: >> Thank you for your review! >> Attached file is the latest version (without document patch. I making it >> now.) >> As per discussion, ther

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-03-12 Thread Sawada Masahiko
On Tue, Mar 10, 2015 at 5:05 PM, Jim Nasby wrote: > On 3/9/15 9:43 PM, Sawada Masahiko wrote: >> >> On Fri, Mar 6, 2015 at 11:07 AM, Jim Nasby >> wrote: >>> >>> On 3/2/15 10:58 AM, Sawada Masahiko wrote: >>>> >>>> >>>> O

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-03-12 Thread Sawada Masahiko
On Thu, Mar 12, 2015 at 6:36 AM, Jim Nasby wrote: > On 3/11/15 6:33 AM, Sawada Masahiko wrote: >>>>>>> >>>>>>> As a refresher, current commands are: >>>>>>> >>>>> >>>>>>> >>>>>

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-23 Thread Sawada Masahiko
lized and > MemoryContextRegisterResetCallback() is used to cleanup the stack on errors. > > Let me know what you think. > Hi, I tied to look into latest patch, but got following error. masahiko [pg_audit] $ LANG=C make gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -g -fpic -I. -I. -I../../src/include -D_GNU_SOURCE -c -o pg_audit.o pg_audit.c pg_audit.c: In function 'log_audit_event': pg_audit.c:456: warning: ISO C90 forbids mixed declarations and code pg_audit.c: In function 'pg_audit_ddl_command_end': pg_audit.c:1436: error: 'pg_event_trigger_expand_command' undeclared (first use in this function) pg_audit.c:1436: error: (Each undeclared identifier is reported only once pg_audit.c:1436: error: for each function it appears in.) make: *** [pg_audit.o] Error 1 Am I missing something? Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-24 Thread Sawada Masahiko
On Tue, Mar 24, 2015 at 3:17 AM, Alvaro Herrera wrote: > Sawada Masahiko wrote: > >> I tied to look into latest patch, but got following error. >> >> masahiko [pg_audit] $ LANG=C make >> gcc -Wall -Wmissing-prototypes -Wpointer-arith >> -Wdeclaration-after-s

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-24 Thread Sawada Masahiko
Hi David, Thank you for your answer! On Wed, Mar 25, 2015 at 12:38 AM, David Steele wrote: > Hi Sawada, > > Thank you for taking the time to look at the patch. > > On 3/24/15 10:28 AM, Sawada Masahiko wrote: >> I've applied these patchese successfully. >> >>

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-03-25 Thread Sawada Masahiko
DIT: SESSION,6,1,READ,SELECT,,,selecT test(); LOG: AUDIT: SESSION,6,2,FUNCTION,EXECUTE,FUNCTION,public.test,selecT test(); LOG: AUDIT: SESSION,6,3,READ,SELECT,,,select * from hoge CONTEXT: PL/pgSQL function test() line 6 at OPEN ERROR: pg_audit stack is already empty STATEMENT: selecT test(); It seems like that the item in stack is already freed by deleting pg_audit memory context (in MemoryContextDelete()), before calling stack_pop in dropping of top-level Portal. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-03 Thread Sawada Masahiko
On Thu, Apr 2, 2015 at 2:46 AM, David Steele wrote: > Hi Sawada, > > On 3/25/15 9:24 AM, David Steele wrote: >> On 3/25/15 7:46 AM, Sawada Masahiko wrote: >>> 2. >>> I got ERROR when executing function uses cursor. >>> >>> 1) create empty table

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-04-04 Thread Sawada Masahiko
On Wed, Mar 11, 2015 at 11:46 PM, Sawada Masahiko wrote: > On Tue, Mar 10, 2015 at 12:08 PM, Stephen Frost wrote: >> Sawada, >> >> * Sawada Masahiko (sawada.m...@gmail.com) wrote: >>> Thank you for your review! >>> Attached file is the latest version (witho

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-05 Thread Sawada Masahiko
On Sun, Apr 5, 2015 at 8:21 AM, Jeff Janes wrote: > On Sat, Apr 4, 2015 at 3:10 PM, Jim Nasby wrote: >> >> On 4/3/15 12:59 AM, Sawada Masahiko wrote: >>> >>> + case HEAPTUPLE_LIVE: >>> +

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread Sawada Masahiko
On Fri, Apr 3, 2015 at 10:01 PM, David Steele wrote: > On 4/3/15 3:59 AM, Sawada Masahiko wrote: >> On Thu, Apr 2, 2015 at 2:46 AM, David Steele wrote: >>> Let me know if you see any other issues. >>> >> >> I pulled HEAD, and then tried to compile

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-06 Thread Sawada Masahiko
On Fri, Apr 3, 2015 at 10:01 PM, David Steele wrote: > On 4/3/15 3:59 AM, Sawada Masahiko wrote: >> On Thu, Apr 2, 2015 at 2:46 AM, David Steele wrote: >>> Let me know if you see any other issues. >>> >> >> I pulled HEAD, and then tried to compile

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-06 Thread Sawada Masahiko
On Fri, Mar 13, 2015 at 5:10 PM, Kyotaro HORIGUCHI wrote: > Hello, I have some trivial comments about the latest patch. > > At Thu, 12 Mar 2015 21:15:14 +0900, Sawada Masahiko > wrote in > sawada.mshk> On Thu, Mar 12, 2015 at 6:36 AM, Jim Nasby > wrote: >> >>

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-06 Thread Sawada Masahiko
On Mon, Apr 6, 2015 at 10:17 PM, Jim Nasby wrote: > On 4/6/15 1:46 AM, Sawada Masahiko wrote: >> >> On Sun, Apr 5, 2015 at 8:21 AM, Jeff Janes wrote: >>> >>> On Sat, Apr 4, 2015 at 3:10 PM, Jim Nasby >>> wrote: >>>&g

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-06 Thread Sawada Masahiko
has. And DDL command which changes these status is like ALTER TABLE SET READ ONLY, or READ WRITE. Also as Alvaro's suggested, the read-only table affect not only freezing table but also performance optimization. I'll consider including them when I deal with read-only table. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Sawada Masahiko
On Tue, Apr 7, 2015 at 9:32 AM, Fabrízio de Royes Mello wrote: > > On Mon, Apr 6, 2015 at 10:21 AM, Sawada Masahiko > wrote: >> >> On Fri, Mar 13, 2015 at 5:10 PM, Kyotaro HORIGUCHI >> wrote: >> > Hello, I have some trivial comments about the latest patch. &g

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Sawada Masahiko
On Tue, Apr 7, 2015 at 10:12 PM, Fabrízio de Royes Mello wrote: > > On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko > wrote: >> >> Thank you for your reviewing. >> I modified the patch and attached latest version patch(v7). >> Please have a look it. >> &

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Sawada Masahiko
On Wed, Apr 8, 2015 at 1:11 AM, Fabrízio de Royes Mello wrote: > > On Tue, Apr 7, 2015 at 1:04 PM, Sawada Masahiko > wrote: >> >> On Tue, Apr 7, 2015 at 10:12 PM, Fabrízio de Royes Mello >> wrote: >> > >> > On Tue, Apr 7, 2015 at 7:22 AM, Sawada Ma

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-08 Thread Sawada Masahiko
On Wed, Apr 8, 2015 at 1:09 PM, Fujii Masao wrote: > On Wed, Apr 8, 2015 at 1:57 AM, Sawada Masahiko wrote: >> On Wed, Apr 8, 2015 at 1:11 AM, Fabrízio de Royes Mello >> wrote: >>> >>> On Tue, Apr 7, 2015 at 1:04 PM, Sawada Masahiko >>> wrote:

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-09 Thread Sawada Masahiko
On Thu, Apr 9, 2015 at 1:14 PM, Fujii Masao wrote: > On Wed, Apr 8, 2015 at 10:53 PM, Sawada Masahiko > wrote: >> On Wed, Apr 8, 2015 at 1:09 PM, Fujii Masao wrote: >>> On Wed, Apr 8, 2015 at 1:57 AM, Sawada Masahiko >>> wrote: >>>> On Wed, Apr 8

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-14 Thread Sawada Masahiko
INT: In a moment you should be able to reconnect to the database and repeat your command. FATAL: the database system is in recovery mode I hope that these messages helps you to address this problem. I will also try to address this. Regards, --- Sawada Masahiko -- Sent via pgsql-hackers mailing

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-15 Thread Sawada Masahiko
On Wed, Apr 15, 2015 at 10:52 AM, Sawada Masahiko wrote: > On Wed, Apr 15, 2015 at 8:57 AM, David Steele wrote: >> On 4/14/15 7:13 PM, Tatsuo Ishii wrote: >>> This patch does not apply cleanly due to the moving of pgbench (patch >>> to filelist.sgml failed). >> &

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-20 Thread Sawada Masahiko
On Tue, Apr 7, 2015 at 11:22 AM, Sawada Masahiko wrote: > On Tue, Apr 7, 2015 at 7:53 AM, Jim Nasby wrote: >> On 4/6/15 5:18 PM, Greg Stark wrote: >>> >>> Only I would suggest thinking of it in terms of two orthogonal boolean >>> flags rather than three

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-20 Thread Sawada Masahiko
On Thu, Apr 16, 2015 at 2:34 AM, David Steele wrote: > On 4/15/15 11:30 AM, Sawada Masahiko wrote: >> On Wed, Apr 15, 2015 at 10:52 AM, Sawada Masahiko >> wrote: >>> I tested v8 patch with CURSOR case I mentioned before, and got >>> segmentation fault again

  1   2   3   >