Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-06 Thread Petr Jelinek
er. It's fun to set it up yes. I do have the machine with buildfarm client ready still (although now also traveling so slightly complicated to get to it) but I didn't activate it yet as I don't want it to just report failures forever. -- Petr Jelinek

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-06 Thread Petr Jelinek
On 07/04/16 00:50, Michael Paquier wrote: On Thu, Apr 7, 2016 at 7:44 AM, Michael Paquier wrote: On Thu, Apr 7, 2016 at 6:11 AM, Petr Jelinek wrote: On 06/04/16 22:50, Andrew Dunstan wrote: I have spent way too much time on this and don't have it working yet. I'm setting up a sacr

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-04-07 Thread Petr Jelinek
On 07/04/16 12:26, Andres Freund wrote: Hi, On 2016-04-06 20:03:20 +0200, Petr Jelinek wrote: Attached patch adds filtering of both database and origin. Added tests with slightly less hardcoding than what you proposed above. Not a fan of creating & dropping another database - that'

Re: [HACKERS] Timeline following for logical slots

2016-04-07 Thread Petr Jelinek
. But in general the idea of recovering from error rather than being hell bent on preventing it is something I am pushing as well. For example it should be easier to look at what's in replication queue and remove things from there if needed. -- Petr Jelinek http://www.2n

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Petr Jelinek
look on it, but just in 12 hours or so, aka after the deadline if that matters for this patch. I won't be able to get back to it (well mainly to windows environment) till Thursday due to travel, sorry. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-10 Thread Petr Jelinek
y was too happy with it. I guess the worry is that given that the header file is obviously unfinished in the area where this is defined and also the fact that this looks like something that's not meant to be used outside of that header makes people worry that it might change between

Re: [HACKERS] Pglogical questions and problems

2016-04-14 Thread Petr Jelinek
unfortunate in terms of planning for this. That's a bummer. I suppose you won't be at NYC either? No NYC either. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Pglogical questions and problems

2016-04-14 Thread Petr Jelinek
o have some history of bike-shedding any SQL syntax that's not part of standard to death halting the actual feature development for prolonged time periods as a result. Finally a side note about sharding - I have strong believe that sharding needs to be tightly coupled to be effective a

[HACKERS] pg_stat_activity crashes

2016-04-20 Thread Petr Jelinek
which is what this patch does though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 64c4cc4..355e58c 100644 --- a/src/bac

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-24 Thread Petr Jelinek
tify a single one that was clearly not created or edited by anything other than Visual Studio itself. I did some checking too, and yes it seems having version 12 .sln is fine or maybe even desirable. We mainly need to make sure that the tools version is 14 and platform toolset is v140 for M

Re: [HACKERS] 9.6 and fsync=off

2016-04-27 Thread Petr Jelinek
h that). +1 (Abhijit's wording with data loss changed to data corruption) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-29 Thread Petr Jelinek
successful build to the buildfarm. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/

Re: [HACKERS] Processes and caches in postgresql

2016-05-03 Thread Petr Jelinek
hey plan this as purely developer feature and you should not use it for deploying anything. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] 10.0

2016-05-13 Thread Petr Jelinek
, 11, etc. We can't possibly get all the major features people want into single release given the yearly release cycle. That being said, I think that once we released beta1 as 9.6 it's too late for bumping it. -- Petr Jelinek http://www.2ndQuadrant.com/ Postgr

Re: [HACKERS] 10.0

2016-05-13 Thread Petr Jelinek
On 13/05/16 20:31, Alvaro Herrera wrote: Josh berkus wrote: Anyway, can we come up with a consensus of some minimum changes it will take to make the next version 10.0? I think the next version should be 10.0 no matter what changes we put in. +1 -- Petr Jelinek http

Re: [HACKERS] 10.0

2016-05-14 Thread Petr Jelinek
of removal plgpsql rename clause where nobody wanted to rewrite couple thousand function which used it and there are many examples like that). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hac

Re: [HACKERS] Sequence Access Method WIP

2015-01-22 Thread Petr Jelinek
On 22/01/15 16:50, Heikki Linnakangas wrote: On 01/12/2015 11:33 PM, Petr Jelinek wrote: Second patch adds DDL support. I originally wanted to make it CREATE/DROP SEQUENCE ACCESS METHOD... but that would mean making ACCESS a reserver keyword so I went for CREATE ACCESS METHOD FOR SEQUENCES

Re: [HACKERS] tracking commit timestamps

2015-01-22 Thread Petr Jelinek
On 05/01/15 17:50, Petr Jelinek wrote: On 05/01/15 16:17, Petr Jelinek wrote: On 05/01/15 07:28, Fujii Masao wrote: On Thu, Dec 4, 2014 at 12:08 PM, Fujii Masao wrote: On Wed, Dec 3, 2014 at 11:54 PM, Alvaro Herrera wrote: Pushed with some extra cosmetic tweaks. I got the following

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-01-22 Thread Petr Jelinek
to be confusing otherwise. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [HACKERS] Re: Abbreviated keys for Numeric

2015-01-26 Thread Petr Jelinek
writing the array version of width_bucket. It was one of the motivations for making special float8 version since not having to call it had significant effect. Sadly I don't remember if it was the function call itself or the conversion anymore. -- Petr Jelinek http

Re: [HACKERS] TABLESAMPLE patch

2015-01-28 Thread Petr Jelinek
the trends should look the same in sample as they look in the source population. Obviously there is some variation in practice as we don't have perfect random generator but that's independent of the algorithm. -- Petr Jelinek http://www.2ndQuadrant.com/

Re: [HACKERS] TABLESAMPLE patch

2015-01-28 Thread Petr Jelinek
neric enough that we can support it. The following change seems enough. Seems about right, thanks. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Sequence Access Method WIP

2015-01-28 Thread Petr Jelinek
On 28/01/15 18:09, Heikki Linnakangas wrote: On 01/23/2015 02:34 AM, Petr Jelinek wrote: On 22/01/15 17:02, Petr Jelinek wrote: The new version (the one that is not submitted yet) of gapless sequence is way more ugly and probably not best example either but does guarantee gaplessness (it

Re: [HACKERS] TABLESAMPLE patch

2015-01-31 Thread Petr Jelinek
On 31/01/15 14:27, Amit Kapila wrote: On Fri, Jan 23, 2015 at 5:39 AM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: On 19/01/15 07:08, Amit Kapila wrote: On Sun, Jan 18, 2015 at 12:46 AM, Petr Jelinek mailto:p...@2ndquadrant.com> <mailto:p...@2nd

Re: [HACKERS] Getting rid of wal_level=archive and default to hot_standby + wal_senders

2015-02-03 Thread Petr Jelinek
one online, I definitely think that would be a good goal to have. If we could do the same for hot_standby if you had physical slots, that might also be a good idea? +many for the logical, physical would be nice but I think it's again in the category of not so easy and maybe better as next

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-03 Thread Petr Jelinek
ing I can say is that I am not big fan of _logSegNo variable name but that's not new in this patch, we use it all over the place in xlog. I would vote for bigger default of the checkpoint_wal_size (or whatever it will be named) though, since the current one is not much bigger in practice

Re: [HACKERS] Logical Replication Helpers WIP for discussion

2015-02-13 Thread Petr Jelinek
On 13/02/15 08:48, Michael Paquier wrote: On Mon, Dec 22, 2014 at 10:26 PM, Robert Haas mailto:robertmh...@gmail.com>> wrote: On Fri, Dec 19, 2014 at 8:40 AM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: > What I hope to get from this is agreement on the gener

Re: [HACKERS] Logical Replication Helpers WIP for discussion

2015-02-15 Thread Petr Jelinek
On 13/02/15 14:04, Petr Jelinek wrote: On 13/02/15 08:48, Michael Paquier wrote: Looking at this patch, I don't see what we actually gain much here except a decoder plugin that speaks a special protocol for a special background worker that has not been presented yet. What actually is the

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-16 Thread Petr Jelinek
precision would matter too much. The problem is that the new function is actually not used anywhere in the code, I only see use of plain sqrt. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hacker

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-16 Thread Petr Jelinek
On 17/02/15 01:57, Peter Geoghegan wrote: On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek wrote: We definitely want this feature, I wished to have this info many times. I would still like to see a benchmark. Average of 3 runs of read-only pgbench on my system all with pg_stat_statement

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-16 Thread Petr Jelinek
On 17/02/15 02:57, Andrew Dunstan wrote: On 02/16/2015 08:48 PM, Petr Jelinek wrote: On 17/02/15 01:57, Peter Geoghegan wrote: On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek wrote: We definitely want this feature, I wished to have this info many times. I would still like to see a benchmark

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-16 Thread Petr Jelinek
On 17/02/15 03:03, Andrew Dunstan wrote: On 02/16/2015 08:57 PM, Andrew Dunstan wrote: On 02/16/2015 08:48 PM, Petr Jelinek wrote: On 17/02/15 01:57, Peter Geoghegan wrote: On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek wrote: We definitely want this feature, I wished to have this info

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-17 Thread Petr Jelinek
On 17/02/15 03:07, Petr Jelinek wrote: On 17/02/15 03:03, Andrew Dunstan wrote: On 02/16/2015 08:57 PM, Andrew Dunstan wrote: On 02/16/2015 08:48 PM, Petr Jelinek wrote: On 17/02/15 01:57, Peter Geoghegan wrote: On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek wrote: We definitely want this

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-17 Thread Petr Jelinek
On 17/02/15 16:12, Andres Freund wrote: On 2015-02-17 15:50:39 +0100, Petr Jelinek wrote: On 17/02/15 03:07, Petr Jelinek wrote: On 17/02/15 03:03, Andrew Dunstan wrote: On 02/16/2015 08:57 PM, Andrew Dunstan wrote: Average of 3 runs of read-only pgbench on my system all with

Re: [HACKERS] mogrify and indent features for jsonb

2015-02-17 Thread Petr Jelinek
ut the: + /* XXX : why do we need this assertion? The functions is declared to take text[] */ + Assert(ARR_ELEMTYPE(path) == TEXTOID); I wonder about this also, some functions do that, some don't, I am not really sure what is the rule there myself. -- Petr Jelinek

Re: [HACKERS] Sequence Access Method WIP

2015-02-17 Thread Petr Jelinek
On 17/02/15 23:11, Robert Haas wrote: On Sun, Feb 15, 2015 at 1:40 PM, Petr Jelinek wrote: sending new version that is updated along the lines of what we discussed at FOSDEM, which means: - back to single bytea amdata column (no custom columns) Well, the main argument is still future

Re: [HACKERS] Sequence Access Method WIP

2015-02-17 Thread Petr Jelinek
On 18/02/15 02:59, Petr Jelinek wrote: On 17/02/15 23:11, Robert Haas wrote: On Sun, Feb 15, 2015 at 1:40 PM, Petr Jelinek wrote: sending new version that is updated along the lines of what we discussed at FOSDEM, which means: - back to single bytea amdata column (no custom columns) Well

Re: [HACKERS] Replication identifiers, take 4

2015-02-18 Thread Petr Jelinek
e for both? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal: disallow operator "=>" and use it for named parameters

2015-02-19 Thread Petr Jelinek
don't need it. yes, I removed it I am marking this as Ready For Committer, the patch is trivial and works as expected, there is nothing to be added to it IMHO. The "=>" operator was deprecated for several years so it should not be too controversial either. -- Petr Jel

Re: [HACKERS] Bootstrap DATA is a pita

2015-02-20 Thread Petr Jelinek
made fake YAML over this. +1 for the idea and +1 for YAML(-like) syntax. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2015-02-21 Thread Petr Jelinek
On 21/02/15 22:09, Andrew Dunstan wrote: On 02/16/2015 09:05 PM, Petr Jelinek wrote: I found one more issue with the 1.2--1.3 upgrade script, the DROP FUNCTION pg_stat_statements(); should be DROP FUNCTION pg_stat_statements(bool); since in 1.2 the function identity has changed. I think

Re: [HACKERS] proposal: searching in array function - array_position

2015-02-21 Thread Petr Jelinek
hat the documentation does not say what is returned by array_offset if nothing is found (it's documented in code but not in sgml). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hacke

Re: [HACKERS] Replication identifiers, take 4

2015-02-21 Thread Petr Jelinek
interface. As I wrote in another email, I would like to integrate the RepNodeId and CommitTSNodeId into single thing. There are no docs for the new sql interfaces. The replication_identifier.c might deserve some intro/notes text. -- Petr Jelinek http://www.2ndQuadrant.com/

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-21 Thread Petr Jelinek
erspective of the algorithm in this patch, but user does not really care about that) which is somewhat weird given the naming. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Replication identifiers, take 4

2015-02-22 Thread Petr Jelinek
On 22/02/15 09:57, Andres Freund wrote: On 2015-02-19 00:49:50 +0100, Petr Jelinek wrote: On 16/02/15 10:46, Andres Freund wrote: On 2015-02-16 11:34:10 +0200, Heikki Linnakangas wrote: At a quick glance, this basic design seems workable. I would suggest expanding the replication IDs to

Re: [HACKERS] Redesigning checkpoint_segments

2015-02-22 Thread Petr Jelinek
On 23/02/15 03:24, Robert Haas wrote: On Sat, Feb 21, 2015 at 11:29 PM, Petr Jelinek wrote: I am wondering a bit about interaction with wal_keep_segments. One thing is that wal_keep_segments is still specified in number of segments and not size units, maybe it would be worth to change it also

Re: [HACKERS] mogrify and indent features for jsonb

2015-03-01 Thread Petr Jelinek
rinting something like '{"a":["b", "c"], "d": {"e":"f"}}' using that tool you pasted and see what your patch outputs to see what I mean. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] TABLESAMPLE patch

2015-03-07 Thread Petr Jelinek
On 05/03/15 09:21, Amit Kapila wrote: On Tue, Feb 17, 2015 at 3:29 AM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: > > > I didn't add the whole page visibility caching as the tuple ids we get from sampling methods don't map well to the visibility info we get fro

Re: [HACKERS] proposal: searching in array function - array_position

2015-03-07 Thread Petr Jelinek
On 22/02/15 12:19, Pavel Stehule wrote: 2015-02-22 3:00 GMT+01:00 Petr Jelinek mailto:p...@2ndquadrant.com>>: On 28/01/15 08:15, Pavel Stehule wrote: 2015-01-28 0:01 GMT+01:00 Jim Nasby mailto:jim.na...@bluetreble.com>>>: On 1/27/15 4:36 AM, Pave

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-03-07 Thread Petr Jelinek
ate or NumericAggState should be renamed in similar fashion. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TABLESAMPLE patch

2015-03-09 Thread Petr Jelinek
On 09/03/15 04:51, Amit Kapila wrote: On Sat, Mar 7, 2015 at 10:37 PM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: > > On 05/03/15 09:21, Amit Kapila wrote: >> >> On Tue, Feb 17, 2015 at 3:29 AM, Petr Jelinek mailto:p...@2ndquadrant.com> >> <m

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-03-09 Thread Petr Jelinek
On 09/03/15 13:39, Andreas Karlsson wrote: On 03/07/2015 07:18 PM, Petr Jelinek wrote: What I am wondering is if those numeric_int16_* functions that also deal with either the Int128AggState or NumericAggState should be renamed in similar fashion. You mean something like numeric_poly_sum

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-03-09 Thread Petr Jelinek
On 09/03/15 18:39, David Fetter wrote: On Mon, Mar 09, 2015 at 01:39:04PM +0100, Andreas Karlsson wrote: On 03/07/2015 07:18 PM, Petr Jelinek wrote: What I am wondering is if those numeric_int16_* functions that also deal with either the Int128AggState or NumericAggState should be renamed in

Re: [HACKERS] TABLESAMPLE patch

2015-03-10 Thread Petr Jelinek
On 10/03/15 04:43, Amit Kapila wrote: On Mon, Mar 9, 2015 at 3:08 PM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: > > On 09/03/15 04:51, Amit Kapila wrote: >> >> On Sat, Mar 7, 2015 at 10:37 PM, Petr Jelinek mailto:p...@2ndquadrant.com> >> > Dou

Re: [HACKERS] TABLESAMPLE patch

2015-03-10 Thread Petr Jelinek
On 10/03/15 10:54, Amit Kapila wrote: On Tue, Mar 10, 2015 at 3:03 PM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote: > > Ok now I think I finally understand what you are suggesting - you are saying let's go over whole page while tsmnexttuple returns something, and do the

Re: [HACKERS] proposal: disallow operator "=>" and use it for named parameters

2015-03-10 Thread Petr Jelinek
ls should start printing NamedArgExprs with "=>"? Or do we think that needs to wait? I didn't think about it? I don't see any reason why it have to use deprecated syntax. There is one, loading the output into older version of Postgres. Don't know if that

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-11-28 Thread Petr Jelinek
On 28/11/14 17:46, Alex Shulgin wrote: Christoph Berg writes: Re: Petr Jelinek 2014-11-25 <5474efea.2040...@2ndquadrant.com> Patch committed. Before I go and rebase that recovery.conf -> GUC patch on top of this... is it final? I think so, perhaps sans the name mentio

Re: [HACKERS] Sequence Access Method WIP

2014-12-03 Thread Petr Jelinek
eneral I don't think that the custom columns for AM approach prohibits future storage changes. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] tracking commit timestamps

2014-12-03 Thread Petr Jelinek
On 03/12/14 15:54, Alvaro Herrera wrote: Pushed with some extra cosmetic tweaks. Cool, thanks! -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] [COMMITTERS] pgsql: Keep track of transaction commit timestamps

2014-12-04 Thread Petr Jelinek
ransactionCommit but that's only called from CommitTransaction) time so the definition of latest commit is last CommitTransaction call. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] [COMMITTERS] pgsql: Keep track of transaction commit timestamps

2014-12-04 Thread Petr Jelinek
On 04/12/14 12:26, Heikki Linnakangas wrote: On 12/04/2014 01:16 PM, Petr Jelinek wrote: On 04/12/14 10:42, Heikki Linnakangas wrote: On 12/03/2014 04:54 PM, Alvaro Herrera wrote: ir commit timestamp directly as they commit, or an external transaction c Sorry, I'm late to the party

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-12-04 Thread Petr Jelinek
On 02/12/14 18:59, Robert Haas wrote: On Fri, Nov 28, 2014 at 11:59 AM, Petr Jelinek wrote: I'm a bit late to the party, but wouldn't recovery_target_action = ... have been a better name for this? It'd be in line with the other recovery_target_* parameters, and also a bit s

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-12-07 Thread Petr Jelinek
that, along with the rename to recovery_target_action and addition to the recovery.conf.sample. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/doc/src/sgml/recovery-config.sgml b/doc/src/sgml/recovery-config.s

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-12-07 Thread Petr Jelinek
On 08/12/14 02:03, Michael Paquier wrote: On Mon, Dec 8, 2014 at 9:59 AM, Petr Jelinek wrote: Ok this patch does that, along with the rename to recovery_target_action and addition to the recovery.conf.sample. This needs a rebase as at least da71632 and b8e33a8 are conflicting. Simon

Re: [HACKERS] Add shutdown_at_recovery_target option to recovery.conf

2014-12-07 Thread Petr Jelinek
On 08/12/14 02:06, Petr Jelinek wrote: On 08/12/14 02:03, Michael Paquier wrote: On Mon, Dec 8, 2014 at 9:59 AM, Petr Jelinek wrote: Ok this patch does that, along with the rename to recovery_target_action and addition to the recovery.conf.sample. This needs a rebase as at least da71632 and

Re: [HACKERS] tracking commit timestamps

2014-12-07 Thread Petr Jelinek
uld try that, in case you don't have time for that, I will try to setup something later... -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] [COMMITTERS] pgsql: Keep track of transaction commit timestamps

2014-12-10 Thread Petr Jelinek
ting unless we are changing XLog api again. I have bit busy schedule right now though, can it wait till next week? - I will post some code documentation patches then. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

[HACKERS] TABLESAMPLE patch

2014-12-10 Thread Petr Jelinek
costing and returned row count estimation - given the dynamic nature of parameters I think for we'll need to let the sampling method do this, so there will have to be fifth function in the API. - ruleutils support (it needs a bit of code in get_from_clause_item function) - docs are spars

Re: [HACKERS] TABLESAMPLE patch

2014-12-10 Thread Petr Jelinek
On 11/12/14 00:24, Petr Jelinek wrote: Hello, Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard clause and couple of people tried to submit it before so I think I don't need to explain in length what it does - basically returns "random" sampl

[HACKERS] Logical Replication Helpers WIP for discussion

2014-12-14 Thread Petr Jelinek
in transaction ids and timestamps so the data changes constantly. This is of course based on the BDR work Andres, Craig and myself have been doing. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/cont

Re: [HACKERS] tracking commit timestamps

2014-12-15 Thread Petr Jelinek
On 15/12/14 09:12, Michael Paquier wrote: On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch wrote: On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote: On 08/12/14 00:56, Noah Misch wrote: The commit_ts test suite gives me the attached diff on a 32-bit MinGW build running on 64-bit

Re: [HACKERS] Sequence Access Method WIP

2014-12-15 Thread Petr Jelinek
On 10/12/14 03:33, Petr Jelinek wrote: On 24/11/14 12:16, Heikki Linnakangas wrote: About the rough edges: - The AlterSequence is not prettiest code around as we now have to create new relation when sequence AM is changed and I don't know how to do that nicely - I am not sure if I di

Re: [HACKERS] TABLESAMPLE patch

2014-12-16 Thread Petr Jelinek
On 16/12/14 08:43, Jaime Casanova wrote: On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek wrote: Hello, Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard clause and couple of people tried to submit it before so I think I don't need to explain in length wh

Re: [HACKERS] Combining Aggregates

2014-12-17 Thread Petr Jelinek
mment about that. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TABLESAMPLE patch

2014-12-17 Thread Petr Jelinek
though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TABLESAMPLE patch

2014-12-18 Thread Petr Jelinek
Hi, v2 version of this patch is attached. On 16/12/14 09:31, Petr Jelinek wrote: On 16/12/14 08:43, Jaime Casanova wrote: Sadly when the jsonb functions patch was committed a few oids where used, so you should update the ones you are using. at least to make the patch easier for testing

Re: [HACKERS] [COMMITTERS] pgsql: Keep track of transaction commit timestamps

2014-12-19 Thread Petr Jelinek
On 10/12/14 16:03, Petr Jelinek wrote: On 10/12/14 04:26, Michael Paquier wrote: On Thu, Dec 4, 2014 at 9:26 PM, Heikki Linnakangas wrote: Yeah, it was raised. I don't think it was really addressed. There was lengthy discussion on whether to include LSN, node id, and/or some other inform

Re: [HACKERS] [COMMITTERS] pgsql: Keep track of transaction commit timestamps

2014-12-19 Thread Petr Jelinek
On 19/12/14 13:17, Michael Paquier wrote: On Fri, Dec 19, 2014 at 6:30 PM, Petr Jelinek wrote: On 10/12/14 16:03, Petr Jelinek wrote: On 10/12/14 04:26, Michael Paquier wrote: On Thu, Dec 4, 2014 at 9:26 PM, Heikki Linnakangas wrote: Yeah, it was raised. I don't think it was r

Re: [HACKERS] Logical Replication Helpers WIP for discussion

2014-12-19 Thread Petr Jelinek
On 15/12/14 19:42, Robert Haas wrote: On Mon, Dec 15, 2014 at 12:57 AM, Petr Jelinek wrote: we've made few helper functions for making logical replication easier, I bundled it into contrib module as this is mainly for discussion at this time (I don't expect this to get committed any

Re: [HACKERS] TABLESAMPLE patch

2014-12-22 Thread Petr Jelinek
On 21/12/14 18:38, Tomas Vondra wrote: Hi, On 18.12.2014 13:14, Petr Jelinek wrote: Hi, v2 version of this patch is attached. I did a review of this v2 patch today. I plan to do a bit more testing, but these are my comments/questions so far: Thanks for looking at it! (0) There

Re: [HACKERS] TABLESAMPLE patch

2014-12-22 Thread Petr Jelinek
On 22/12/14 20:14, Jaime Casanova wrote: On Thu, Dec 18, 2014 at 7:14 AM, Petr Jelinek wrote: Hi, v2 version of this patch is attached. a few more tests revealed that passing null as the sample size argument works, and it shouldn't. Fixed. in repeatable it gives an error if i use

Re: [HACKERS] Turning recovery.conf into GUCs

2014-12-23 Thread Petr Jelinek
y long already so I think it's preferable to not make it worse. - I wonder if we should rename trigger_file to standby_tigger_file -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] Commit timestamp abbreviations

2014-12-24 Thread Petr Jelinek
of using _ts and 'ts' inconsistently, and I thought we were going to spell out timestamp in more places, but maybe I am remembering incorrectly. The change was from committs to commit_ts + CommitTs depending on place. -- Petr Jelinek http://www.2ndQuadrant.com/ Postgr

Re: [HACKERS] [COMMITTERS] pgsql: Keep track of transaction commit timestamps

2014-12-29 Thread Petr Jelinek
t phase during transaction commit *and* replay I don't think it'd be all that easy to do it fast and flexible. Right, I would love to have custom SLRUs but I don't see it happening given those two restrictions, otherwise I would write the CommitTs patch that way in the fir

Re: [HACKERS] tracking commit timestamps

2015-01-05 Thread Petr Jelinek
ControlFile->wal_log_hints = wal_log_hints; shouldn't it be ControlFile->wal_log_hints = xlrec.wal_log_hints; instead? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --g

Re: [HACKERS] tracking commit timestamps

2015-01-05 Thread Petr Jelinek
On 05/01/15 16:17, Petr Jelinek wrote: On 05/01/15 07:28, Fujii Masao wrote: On Thu, Dec 4, 2014 at 12:08 PM, Fujii Masao wrote: On Wed, Dec 3, 2014 at 11:54 PM, Alvaro Herrera wrote: Pushed with some extra cosmetic tweaks. I got the following assertion failure when I executed

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-05 Thread Petr Jelinek
ng to throw error and die eventually anyway once you are in that code path, maybe just for the clarity... -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-ha

Re: [HACKERS] recovery_min_apply_delay with a negative value

2015-01-05 Thread Petr Jelinek
to be GUCs. Well, there is an ongoing effort on that and I think the patch is very close to the state where committer should take a look IMHO, I have only couple of gripes with it now and one of them needs opinions of others anyway. -- Petr Jelinek http://www.2ndQuadran

[HACKERS] event trigger pg_dump fix

2015-01-05 Thread Petr Jelinek
Hi, Attached is fix for http://www.postgresql.org/message-id/1420492505.23613.15.ca...@bloodnok.com It was dumping comment with NULL owner while the function expects empty string for objects without owner (there is pg_strdup down the line). -- Petr Jelinek http://www

Re: [HACKERS] event trigger pg_dump fix

2015-01-05 Thread Petr Jelinek
On 06/01/15 01:02, Tom Lane wrote: Petr Jelinek writes: Attached is fix for http://www.postgresql.org/message-id/1420492505.23613.15.ca...@bloodnok.com It was dumping comment with NULL owner while the function expects empty string for objects without owner (there is pg_strdup down the line

Re: [HACKERS] tracking commit timestamps

2015-01-06 Thread Petr Jelinek
ows 8 and Windows Server 2012 which we are using thanks to 519b0757a37254452e013ea0ac95f4e56391608c so we are good at least on modern systems. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers maili

Re: [HACKERS] TABLESAMPLE patch

2015-01-06 Thread Petr Jelinek
On 06/01/15 08:51, Michael Paquier wrote: On Tue, Dec 23, 2014 at 5:21 AM, Petr Jelinek wrote: Attached is v3 which besides the fixes mentioned above also includes changes discussed with Tomas (except the CREATE/DROP TABLESAMPLE METHOD), fixes for crash with FETCH FIRST and is rebased against

[HACKERS] XLOG_PARAMETER_CHANGE handling of wal_log_hints

2015-01-06 Thread Petr Jelinek
bug anyway so here is simple patch to change that. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 5cc7e47..be67da4 100644 --- a

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-06 Thread Petr Jelinek
On 07/01/15 00:05, Jim Nasby wrote: On 1/6/15, 8:17 AM, Kouhei Kaigai wrote: The attached patch is newer revision of custom-/foreign-join interface. Shouldn't instances of scan_relid > 0 be scan_relid != InvalidOid Ideally, they should be OidIsValid(scan_relid) -- Petr

Re: [HACKERS] XLOG_PARAMETER_CHANGE handling of wal_log_hints

2015-01-07 Thread Petr Jelinek
On 07/01/15 00:59, Michael Paquier wrote: On Wed, Jan 7, 2015 at 4:24 AM, Petr Jelinek wrote: Hi, when I was fixing how commit_ts handles the XLOG_PARAMETER_CHANGE I noticed that for wal_log_hints we assign the value in ControFile to current value instead of value that comes from WAL. ISTM

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-09 Thread Petr Jelinek
manages to confuse me. Nothing this patch can do about that. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subs

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-01-11 Thread Petr Jelinek
e *state; ... #endif PG_RETURN_POINTER(state); } } -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: h

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-01-11 Thread Petr Jelinek
fix it. If we renamed it on v9.5, we also need a little adjustment to apply this bugfix on prior versions. It seems to me a waste of time for committers. I tend to agree, especially as there is multiple places in code this would affect - RelOptInfo and RestrictInfo have same issue, etc. --

Re: [HACKERS] Sequence Access Method WIP

2015-01-13 Thread Petr Jelinek
On 13/01/15 13:24, Tomas Vondra wrote: On 12.1.2015 22:33, Petr Jelinek wrote: On 15/12/14 11:36, Petr Jelinek wrote: On 10/12/14 03:33, Petr Jelinek wrote: On 24/11/14 12:16, Heikki Linnakangas wrote: About the rough edges: - The AlterSequence is not prettiest code around as we now have to

Re: [HACKERS] Turning recovery.conf into GUCs

2015-01-14 Thread Petr Jelinek
ush all of our configuration through a single, unified mechanism that offers many convenient features, do we continue to suffer our recovery.conf settings to go through some other, less-capable mechanism?". +1 -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development

<    5   6   7   8   9   10   11   12   >