Re: [HACKERS] proposal: schema variables

2017-10-31 Thread Pavel Stehule
2017-10-31 22:08 GMT+01:00 Serge Rielau : > Pavel, > > I can imagine, so DECLARE command will be introduced as short cut for > CREATE TEMP VARIABLE, but in this moment I would not to open this topic. I > afraid of bikeshedding and I hope so CREATE TEMP VAR is anough. > > Language is important beca

Re: [HACKERS] proposal: schema variables

2017-10-31 Thread Pavel Stehule
2017-10-31 22:28 GMT+01:00 srielau : > Pavel, > > There is no > DECLARE TEMP CURSOR > or > DECLARE TEMP variable in PLpgSQL > and > sure .. DECLARE TEMP has no sense, I talked about similarity DECLARE and CREATE TEMP CREATE TEMP TABLE has a different meaning from what I understand you > envisio

Re: [HACKERS] proposal: schema variables

2017-10-31 Thread Pavel Stehule
2017-11-01 6:07 GMT+01:00 Serge Rielau : > "Although the syntax of CREATE TEMPORARY TABLE resembles that of the SQL > standard, the effect is not the same. In the standard, temporary tables are > defined just once and automatically exist (starting with empty contents) in > every session that needs

Re: [HACKERS] Dynamic result sets from procedures

2017-11-01 Thread Pavel Stehule
2017-10-31 22:08 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > This patch is more of a demo of what could be done, not my primary > focus, but if there is interest and some assistance, maybe we can make > something out of it. This patch also goes on top of "SQL procedures" > v

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

2017-11-01 Thread Pavel Stehule
Hi In general, this approach looks good for me. > Regarding current state of patch, I'd like to see new options documented. > Also, it would be better to replace "bool sort_size" with enum assuming > there could be other sorting orders in future. > I am sending updated patch with some basic doc

Re: [HACKERS] [PATCH] Add two-arg for of current_setting(NAME, FALLBACK)

2017-11-01 Thread Pavel Stehule
Hi better to send it as attachment Regards Pavel 2015-03-19 23:41 GMT+01:00 David Christensen : > The two-arg form of the current_setting() function will allow a > fallback value to be returned instead of throwing an error when an > unknown GUC is provided. This would come in most useful when

Re: [HACKERS] proposal: schema variables

2017-11-01 Thread Pavel Stehule
2017-11-01 19:03 GMT+01:00 Mark Dilger : > > > Comments, notes? > > How would variables behave on transaction rollback? > > CREATE TEMP VARIABLE myvar; > SET myvar := 1; > BEGIN; > SET myvar := 2; > COMMIT; > BEGIN; > SET myvar := 3; > ROLLBACK; > SELECT myvar; > > How would variables behave when

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-11-02 Thread Pavel Stehule
Hi 2017-11-02 3:39 GMT+01:00 Peter Eisentraut : > Could someone clarify the status of this patch set? It has been in > "Waiting" mode since the previous CF and no new patch, just a few > questions from the author. > There was a state "needs review". I looked to the patch, and found some issues,

Re: [HACKERS] proposal: schema variables

2017-11-02 Thread Pavel Stehule
2017-11-02 16:35 GMT+01:00 Nico Williams : > On Thu, Nov 02, 2017 at 06:05:54PM +0530, Robert Haas wrote: > > On Thu, Oct 26, 2017 at 12:51 PM, Pavel Stehule > wrote: > > > The variables can be modified by SQL command SET (this is taken from > > > standard, a

Re: [HACKERS] proposal: schema variables

2017-11-02 Thread Pavel Stehule
2017-11-02 16:07 GMT+01:00 Craig Ringer : > On 26 October 2017 at 15:21, Pavel Stehule > wrote: > > Hi, > > > > I propose a new database object - a variable. > > Didn't we have a pretty long discussion about this already in > > Yeah. > > https://ww

Re: [HACKERS] proposal: schema variables

2017-11-02 Thread Pavel Stehule
2017-11-02 13:35 GMT+01:00 Robert Haas : > On Thu, Oct 26, 2017 at 12:51 PM, Pavel Stehule > wrote: > > The variables can be modified by SQL command SET (this is taken from > > standard, and it natural) > > > > SET varname = expression; > > Overloading SET to

Re: [HACKERS] possible encoding issues with libxml2 functions

2017-11-05 Thread Pavel Stehule
Hi 2017-11-05 4:07 GMT+01:00 Noah Misch : > On Tue, Oct 17, 2017 at 06:06:40AM +0200, Pavel Stehule wrote: > > Please, if you can, try it write. I am little bit lost :) > > I'm attaching the patch I desired. Please review. This will probably miss > this week's

Re: [HACKERS] SQL procedures

2017-11-08 Thread Pavel Stehule
2017-11-08 15:23 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 10/31/17 16:50, Pavel Stehule wrote: > > Not sure if disabling RETURN is good idea. I can imagine so optional > > returning something like int status can be good idea. Cheaper than &g

Re: [HACKERS] SQL procedures

2017-11-08 Thread Pavel Stehule
2017-11-08 15:31 GMT+01:00 Pavel Stehule : > > > 2017-11-08 15:23 GMT+01:00 Peter Eisentraut com>: > >> On 10/31/17 16:50, Pavel Stehule wrote: >> > Not sure if disabling RETURN is good idea. I can imagine so optional >> > returning something like in

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-11-09 Thread Pavel Stehule
8 conflicts on doc/src/sgml/func.sgml > > > At Sun, 15 Oct 2017 12:06:11 +0200, Pavel Stehule > wrote in b9efon...@mail.gmail.com> > > 2017-10-02 12:22 GMT+02:00 Kyotaro HORIGUCHI < > > horiguchi.kyot...@lab.ntt.co.jp>: > > > > > Hi, thanks for the new

Re: [HACKERS] proposal: psql command \graw

2017-11-09 Thread Pavel Stehule
Hi 2017-08-24 5:50 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > I have added the patch to the next commitfest. > > Patch applies, compiles, works. > > I'm okay with the names graw/graw+, and for having such short-hands. > > Missing break in switch, even if last item and useless, because other >

Re: [HACKERS] proposal: psql command \graw

2017-11-09 Thread Pavel Stehule
2017-11-09 21:03 GMT+01:00 Fabien COELHO : > > Hello Pavel, > > I hope so I fixed all mentioned issues. >> > > Patch applies with a warning: > > > git apply ~/psql-graw-2.patch > /home/fabien/psql-graw-2.patch:192: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > > Otherw

[HACKERS] different content of pg_depend after pg_upgrade

2017-11-09 Thread Pavel Stehule
Hi We checked some check query based on some operations on pg_depend table. This query did different result when database was migrated with pg_dump or with pg_upgrade. I found so this query was broken, but I found interesting thing. The count is 1 for any objid select distinct count(distinct cla

Re: [HACKERS] proposal: psql command \graw

2017-11-09 Thread Pavel Stehule
2017-11-09 21:12 GMT+01:00 Pavel Stehule : > > > 2017-11-09 21:03 GMT+01:00 Fabien COELHO : > >> >> Hello Pavel, >> >> I hope so I fixed all mentioned issues. >>> >> >> Patch applies with a warning: >> >> > git apply ~/psq

Re: [HACKERS] proposal: psql command \graw

2017-11-09 Thread Pavel Stehule
2017-11-10 8:12 GMT+01:00 Fabien COELHO : > > ISTM that you can remove "force_column_header" and just set "tuple_only" >>> to what you need, that is you do not need to change anything in function >>> "print_unaligned_text". >>> >> >> Last point is not possible - I would not to break original tuple

[HACKERS] pg audit requirements

2017-11-09 Thread Pavel Stehule
Hi I am sending some notes, experience about usage of pgAudit. pgAudit provides basic functionality and usually is good enough. But it is not good enough for some applications in financial services. The requirements: 1. structured output - attached query is not good enough - column name, table

Re: [HACKERS] Transform for pl/perl

2017-11-10 Thread Pavel Stehule
Hi 2017-10-24 14:27 GMT+02:00 Anthony Bykov : > There are some moments I should mention: > 1. {"1":1}::jsonb is transformed into HV {"1"=>"1"}, while > ["1","2"]::jsonb is transformed into AV ["1", "2"] > > 2. If there is a numeric value appear in jsonb, it will be transformed > to SVnv through s

Re: [HACKERS] Variable substitution in psql backtick expansion

2017-11-10 Thread Pavel Stehule
Hi I am sending a review of last patch psql-server-version-1.patch.gz This patch is trivial - the most big problem is choosing correct name for GUC. I am thinking so server_version_raw is acceptable. I had to fix doc - see attached updated patch All tests passed. I'll mark this patch as ready

Re: [HACKERS] proposal: psql command \graw

2017-11-10 Thread Pavel Stehule
2017-11-10 16:38 GMT+01:00 Fabien COELHO : > > Hello, > > Maybe I'm missing something, but it looks that it could be made to work >>> without adding another boolean. >>> >> >> The tuples only cannot be disabled, because then other parts print number >> of rows >> >> postgres=# \pset format unalign

Re: [HACKERS] possible encoding issues with libxml2 functions

2017-11-11 Thread Pavel Stehule
2017-11-11 21:19 GMT+01:00 Noah Misch : > On Sun, Nov 05, 2017 at 06:10:04PM +0100, Pavel Stehule wrote: > > Hi > > > > 2017-11-05 4:07 GMT+01:00 Noah Misch : > > > > > On Tue, Oct 17, 2017 at 06:06:40AM +0200, Pavel Stehule wrote: > > > > Please

Re: [HACKERS] proposal: schema variables

2017-11-13 Thread Pavel Stehule
Hi 2017-11-13 13:15 GMT+01:00 Pavel Golub : > Hello, Pavel. > > You wrote: > > PS> Hi, > > PS> I propose a new database object - a variable. The variable is > PS> persistent object, that holds unshared session based not > PS> transactional in memory value of any type. Like variables in any > PS>

Re: [HACKERS] Showing parallel status in \df+

2016-09-28 Thread Pavel Stehule
Hi 2016-09-28 18:57 GMT+02:00 Tom Lane : > Pavel Stehule writes: > > 2016-09-28 16:03 GMT+02:00 Tom Lane : > >> I propose to push my current patch (ie, move PL function > >> source code to \df+ footers), and we can use it in HEAD for awhile > >> and see wha

Re: [HACKERS] Showing parallel status in \df+

2016-09-28 Thread Pavel Stehule
2016-09-28 21:59 GMT+02:00 Alvaro Herrera : > Pavel Stehule wrote: > > > I am sorry, I disagree. Proposed form is hard readable. Is not possible > to > > simply copy/paste. > > Why do you care? You can use \sf if you want to copy&paste the > function code. >

Re: [HACKERS] Hash Indexes

2016-10-02 Thread Pavel Stehule
2016-10-02 12:40 GMT+02:00 Michael Paquier : > On Sun, Oct 2, 2016 at 3:31 AM, Greg Stark wrote: > > On Fri, Sep 30, 2016 at 2:11 AM, Robert Haas > wrote: > >> For one thing, we can stop shipping a totally broken feature in release > after release > > > > For what it's worth I'm for any patch th

Re: [HACKERS] Showing parallel status in \df+

2016-10-03 Thread Pavel Stehule
2016-10-03 21:54 GMT+02:00 Robert Haas : > On Fri, Sep 30, 2016 at 8:47 PM, Tom Lane wrote: > > Well, alternatively, can we get a consensus for doing that? People > > did speak against removing PL source code from \df+ altogether, but > > maybe they're willing to reconsider if the alternative is

Re: [HACKERS] Showing parallel status in \df+

2016-10-03 Thread Pavel Stehule
2016-10-03 22:03 GMT+02:00 Tom Lane : > Pavel Stehule writes: > > 2016-10-03 21:54 GMT+02:00 Robert Haas : > >> On Fri, Sep 30, 2016 at 8:47 PM, Tom Lane wrote: > >>> Personally I'm on the edge of washing my hands of the whole thing... > > >> The

Re: [HACKERS] proposal: psql \setfileref

2016-10-04 Thread Pavel Stehule
2016-10-04 9:18 GMT+02:00 Gilles Darold : > Le 03/10/2016 à 23:23, Gilles Darold a écrit : > > Le 03/10/2016 à 23:03, Robert Haas a écrit : > >> On Mon, Oct 3, 2016 at 3:54 PM, Gilles Darold > wrote: > >>> 4) An other problem is that like this this patch will allow anyone to > upload into a > >>>

Re: [HACKERS] vacuumdb -f and -j options (was Question / requests.)

2016-10-08 Thread Pavel Stehule
2016-10-09 7:54 GMT+02:00 Amit Kapila : > On Sat, Oct 8, 2016 at 5:52 PM, Michael Paquier > wrote: > > On Sat, Oct 8, 2016 at 9:12 PM, Amit Kapila > wrote: > >> On Fri, Oct 7, 2016 at 10:16 PM, Alvaro Herrera > >> wrote: > >>> Robert Haas wrote: > On Wed, Oct 5, 2016 at 10:58 AM, Francisco

Re: [HACKERS] Showing parallel status in \df+

2016-10-08 Thread Pavel Stehule
Hi 2016-10-08 23:46 GMT+02:00 Jim Nasby : > On 10/3/16 3:18 PM, Pavel Stehule wrote: > >> I am feeling consensus on removing source of PL from \dt+. There is >> partial consensus on saving this field (renamed) for C and internal >> language. I am not sure about conse

Re: [HACKERS] proposal: psql \setfileref

2016-10-09 Thread Pavel Stehule
hi 2016-10-04 9:18 GMT+02:00 Gilles Darold : > Le 03/10/2016 à 23:23, Gilles Darold a écrit : > > Le 03/10/2016 à 23:03, Robert Haas a écrit : > >> On Mon, Oct 3, 2016 at 3:54 PM, Gilles Darold > wrote: > >>> 4) An other problem is that like this this patch will allow anyone to > upload into a >

Re: [HACKERS] proposal: psql \setfileref

2016-10-09 Thread Pavel Stehule
2016-10-09 17:27 GMT+02:00 Corey Huinker : > here is new update - some mentioned issues are fixed + regress tests and >>> docs >>> >> >> >> > This might tie into some work I'm doing. Is there any way these filerefs > could be used as the inline portion of a COPY command? > i.e. like this: > > COPY

Re: [HACKERS] proposal: psql \setfileref

2016-10-09 Thread Pavel Stehule
2016-10-09 19:14 GMT+02:00 Corey Huinker : > On Sun, Oct 9, 2016 at 12:12 PM, Pavel Stehule > wrote: > >> >> >> 2016-10-09 17:27 GMT+02:00 Corey Huinker : >> >>> here is new update - some mentioned issues are fixed + regress tests and >>>>&g

Re: [HACKERS] proposal: psql \setfileref

2016-10-09 Thread Pavel Stehule
2016-10-09 19:27 GMT+02:00 Corey Huinker : > look to code - some parts allows psql session variables, some not - I can >> use variables in statements - not in data block. >> >> More, there is ambiguity - :xxx should not be part of SQL statement (and >> then psql variables are possible), but :

Re: [HACKERS] proposal: psql \setfileref

2016-10-09 Thread Pavel Stehule
2016-10-10 5:26 GMT+02:00 Jim Nasby : > On 10/9/16 9:54 PM, Bruce Momjian wrote: > >> I understand, but I am not sure how difficult implementation it is. This >>> part >>> > (COPY input) doesn't support parametrization - and parametrization can >>> have a >>> > negative performance impact. >>> >>

Re: [HACKERS] PL/Python adding support for multi-dimensional arrays

2016-10-10 Thread Pavel Stehule
2016-10-10 12:31 GMT+02:00 Heikki Linnakangas : > On 10/01/2016 02:45 AM, Jim Nasby wrote: > >> On 9/29/16 1:51 PM, Heikki Linnakangas wrote: >> >>> Now, back to multi-dimensional arrays. I can see that the Sequence >>> representation is problematic, with arrays, because if you have a python >>> l

Re: [HACKERS] proposal: psql \setfileref

2016-10-10 Thread Pavel Stehule
2016-10-10 15:17 GMT+02:00 Gilles Darold : > Le 10/10/2016 à 14:38, Daniel Verite a écrit : > > Gilles Darold wrote: > > > >>postgres=# \setfileref b /dev/random > >>postgres=# insert into test (:b); > >> > >> Process need to be killed using SIGTERM. > > This can be fixed by setting

Re: [HACKERS] proposal: psql \setfileref

2016-10-10 Thread Pavel Stehule
2016-10-10 19:50 GMT+02:00 Pavel Stehule : > > > 2016-10-10 15:17 GMT+02:00 Gilles Darold : > >> Le 10/10/2016 à 14:38, Daniel Verite a écrit : >> > Gilles Darold wrote: >> > >> >>postgres=# \setfileref b /dev/random >> >>p

Re: [HACKERS] PL/Python adding support for multi-dimensional arrays

2016-10-10 Thread Pavel Stehule
2016-10-11 7:49 GMT+02:00 Heikki Linnakangas : > On 10/10/2016 08:42 PM, Pavel Stehule wrote: > >> 2016-10-10 12:31 GMT+02:00 Heikki Linnakangas : >> >> On 10/01/2016 02:45 AM, Jim Nasby wrote: >>> >>> On 9/29/16 1:51 PM, Heikki Linnakangas wrote: >&

Re: [HACKERS] proposal: psql \setfileref

2016-10-11 Thread Pavel Stehule
2016-10-11 9:32 GMT+02:00 Gilles Darold : > Le 11/10/2016 à 07:53, Pavel Stehule a écrit : > > > > 2016-10-10 19:50 GMT+02:00 Pavel Stehule : > >> >> >> 2016-10-10 15:17 GMT+02:00 Gilles Darold : >> >>> Le 10/10/2016 à 14:38, Dani

Re: [HACKERS] proposal: schema PL session variables

2016-10-11 Thread Pavel Stehule
Hi 2016-02-23 20:52 GMT+01:00 Pavel Stehule : > > > 2016-02-12 22:41 GMT+01:00 Jim Nasby : > >> On 2/12/16 2:58 PM, Pavel Stehule wrote: >> >>> >>> So I think adding something like this needs to at least address >>> *how*

Re: [HACKERS] autonomous transactions

2016-10-11 Thread Pavel Stehule
2016-10-11 17:06 GMT+02:00 Petr Jelinek : > On 10/10/16 16:44, Merlin Moncure wrote: > > On Thu, Oct 6, 2016 at 3:53 PM, Simon Riggs > wrote: > >> On 6 October 2016 at 21:27, Robert Haas wrote: > >>> I think we should implement background transactions and call them > >>> background transactions.

Re: [HACKERS] Remove "Source Code" column from \df+ ?

2016-10-11 Thread Pavel Stehule
2016-10-12 1:51 GMT+02:00 Tom Lane : > Stephen Frost writes: > > As was mentioned, this thread doesn't really need a patch but rather > > some comment from those who have voiced a -1 on removing the PL source > > code column. > > > In another, perhaps vain, attempt to get to a consensus, here's w

Re: [HACKERS] autonomous transactions

2016-10-11 Thread Pavel Stehule
2016-10-11 21:54 GMT+02:00 Merlin Moncure : > On Tue, Oct 11, 2016 at 10:06 AM, Petr Jelinek > wrote: > > On 10/10/16 16:44, Merlin Moncure wrote: > >> On Thu, Oct 6, 2016 at 3:53 PM, Simon Riggs > wrote: > >>> On 6 October 2016 at 21:27, Robert Haas wrote: > I think we should implement ba

Re: [HACKERS] Remove "Source Code" column from \df+ ?

2016-10-12 Thread Pavel Stehule
2016-10-12 19:48 GMT+02:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 10/12/16 11:16 AM, Tom Lane wrote: > > I'm not sure that Peter was voting for retaining "internal name", but > > personally I prefer that to deleting prosrc entirely, so +1. > > I'm not sure what the point of sho

Re: [HACKERS] patch: function xmltable

2016-10-13 Thread Pavel Stehule
Hi new update - only doc + + Only XPath query language is supported. PostgreSQL doesn't support XQuery + language. Then the syntax of xmltable doesn't + allow to use XQuery related functionality - the name of xml expression + (clause AS) is not allowed, and only one xml expres

[HACKERS] proposal: session server side variables

2016-10-13 Thread Pavel Stehule
Hi, long time I working on this topic. Session server side variables are one major missing feature in PLpgSQL. Now I hope, I can summarize requests for implementation in Postgres: Requirements == 1. Should be used in any PL (PLpgSQL, PLPython, PLPerl, ..) 2. Should not block a implementa

Re: [HACKERS] proposal: session server side variables

2016-10-14 Thread Pavel Stehule
2016-10-14 9:56 GMT+02:00 Craig Ringer : > On 14 October 2016 at 13:30, Pavel Stehule > wrote: > > Hi, > > > > long time I working on this topic. Session server side variables are one > > major missing feature in PLpgSQL. Now I hope, I can summarize requests > f

[HACKERS] minor issue: \c without parameter disconnect current user

2016-10-16 Thread Pavel Stehule
Hi I expect so \c without parameters has only informational character. But \c reset user. postgres=# set role to tom; SET Time: 0.787 ms postgres=> select current_user; +--+ | current_user | +--+ | tom | +--+ (1 row) Time: 0.851 ms postgres=> \c You

Re: [HACKERS] Add PGDLLEXPORT to PG_FUNCTION_INFO_V1

2016-10-17 Thread Pavel Stehule
2016-10-18 5:48 GMT+02:00 Craig Ringer : > On 18 October 2016 at 04:19, Andres Freund wrote: > > On 2016-10-17 16:16:37 -0400, Robert Haas wrote: > >> I wouldn't think that cross-file references would be especially > >> common. Functions that take PG_FUNCTION_ARGS and return Datum aren't > >> a

Re: [HACKERS] minor issue: \c without parameter disconnect current user

2016-10-19 Thread Pavel Stehule
2016-10-18 20:11 GMT+02:00 Alvaro Herrera : > Robert Haas wrote: > > On Mon, Oct 17, 2016 at 12:49 AM, Pavel Stehule > wrote: > > > I expect so \c without parameters has only informational character. > But \c > > > reset user. > > > > Yeah, I use

Re: [HACKERS] [RFC] Transaction management overhaul is necessary?

2016-10-21 Thread Pavel Stehule
2016-10-21 10:24 GMT+02:00 Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com>: > Hello, > > From our experience in handling customers' problems, I feel it's necessary > to evolve PostgreSQL's transaction management. The concrete problems are: > > 1. PostgreSQL cannot end and begin transactions

Re: [HACKERS] PL/Python adding support for multi-dimensional arrays

2016-10-24 Thread Pavel Stehule
Hi 2016-10-14 10:53 GMT+02:00 Heikki Linnakangas : > On 10/11/2016 08:56 AM, Pavel Stehule wrote: > >> 2016-10-11 7:49 GMT+02:00 Heikki Linnakangas : >> >> Unfortunately there are cases that are fundamentally ambiguous. >>> >>> create type comptyp

[HACKERS] planet postgresql issue

2016-10-24 Thread Pavel Stehule
Hi I got a email about issues with reading feed URL. I checked manually URL and it looks well. http://okbob.blogspot.com/ feeds/posts/default Regards Pavel

Re: [HACKERS] PL/Python adding support for multi-dimensional arrays

2016-10-26 Thread Pavel Stehule
2016-10-26 10:03 GMT+02:00 Heikki Linnakangas : > On 10/24/2016 10:33 PM, Pavel Stehule wrote: > >> Hi >> >> 2016-10-14 10:53 GMT+02:00 Heikki Linnakangas : >> >> Please review. Are the docs and the error messages now clear enough on >>> this? We

Re: [HACKERS] split up psql \d Modifiers column

2016-10-27 Thread Pavel Stehule
2016-10-28 5:30 GMT+02:00 Peter Eisentraut : > I propose to change the psql \d output a bit, best shown with an example: > > \d persons3 > - Table "public.persons3" > - Column | Type |Modifiers > -+-+-- > - id | integer | not null > - name | text

Re: [HACKERS] delta relations in AFTER triggers

2016-11-02 Thread Pavel Stehule
2016-11-02 15:57 GMT+01:00 Kevin Grittner : > On Sun, Oct 30, 2016 at 10:35 AM, Kevin Grittner > wrote: > > > SPI support would also > > allow us to consider using set logic for validating foreign keys, > > instead of the one-row-at-a-time approach currently used. > > Just as a proof of concept f

Re: [HACKERS] Add support for SRF and returning composites to pl/tcl

2016-11-05 Thread Pavel Stehule
Hi I checked this code, and it looks well 0. there are not any reason why we would not to implement this feature - more, the implementation is simple. 1. there was not problem with patching, compilation 2. the original patch is missing new expected result for regress tests, fixed in attached pa

Re: [HACKERS] Add support for SRF and returning composites to pl/tcl

2016-11-05 Thread Pavel Stehule
2016-11-06 2:12 GMT+01:00 Tom Lane : > Jim Nasby writes: > > Attached is a patch that adds support for SRFs and returning composites > > from pl/tcl. This work was sponsored by Flight Aware. > > I spent a fair amount of time whacking this around, because I did not > like the fact that you were us

Re: [HACKERS] Let's get rid of SPI_push/SPI_pop

2016-11-06 Thread Pavel Stehule
2016-11-07 2:16 GMT+01:00 Tom Lane : > The intent of SPI_push/SPI_pop seems to be to draw a boundary line between > nested layers of SPI callers. Which is fine, but the SPI_connect and > SPI_finish calls of the inner layer would suffice for that. AFAICS, > the only thing that SPI_push/SPI_pop bu

Re: [HACKERS] Let's get rid of SPI_push/SPI_pop

2016-11-07 Thread Pavel Stehule
2016-11-07 15:47 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > 2016-11-07 2:16 GMT+01:00 Tom Lane : > >> So I think we should just delete these functions and adjust SPI_connect > >> and SPI_finish so that they just push/pop a context level > unconditionally. >

Re: [HACKERS] proposal: psql \setfileref

2016-11-10 Thread Pavel Stehule
Hi 2016-11-09 22:47 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > [ psql-setfileref-2016-10-11.patch ] > > I haven't been paying any attention to this thread, but I got around to > looking at it finally. I follow the idea of wanting to be able to shove > the conte

Re: [HACKERS] proposal: psql \setfileref

2016-11-10 Thread Pavel Stehule
2016-11-10 18:56 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > 2016-11-09 22:47 GMT+01:00 Tom Lane : > >> * I really dislike the notion of keying the behavior to a special type > of > >> psql variable. > > > still I am thinking so some differencing c

Re: [HACKERS] Danger of automatic connection reset in psql

2016-11-10 Thread Pavel Stehule
2016-11-11 5:14 GMT+01:00 Ashutosh Bapat : > > > > How about, instead of all this, adding an option to psql to suppress > > the automatic reconnect behavior? When enabled, psql just exits > > instead of trying to reconnect. > > > +1. But, existing users may not notice addition of the new option a

Re: [HACKERS] proposal: psql \setfileref

2016-11-12 Thread Pavel Stehule
2016-11-10 18:56 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > 2016-11-09 22:47 GMT+01:00 Tom Lane : > >> * I really dislike the notion of keying the behavior to a special type > of > >> psql variable. > > > still I am thinking so some differencing c

Re: [HACKERS] Tackling JsonPath support

2016-11-13 Thread Pavel Stehule
2016-11-13 18:13 GMT+01:00 Tom Lane : > Christian Convey writes: > > * Our ultimate goal is to give Postgres an implementation of the > functions > > "JSON_EXISTS", "JSON_VALUE", and "JSON_QUERY" which fully comply with the > > SQL standards. > > * The best representation of those standards is fo

Re: [HACKERS] proposal: psql \setfileref

2016-11-13 Thread Pavel Stehule
Hi I am sending a initial implementation of psql content commands. This design is reaction to Tom's objections against psql file ref variables. This design is more cleaner, more explicit and more practical - import can be in one step. Now supported commands are: r - read file without any modific

Re: [HACKERS] Tackling JsonPath support

2016-11-13 Thread Pavel Stehule
EK_11.0.0/json/src/tpc/db2z_bif_jsontable.html The vendors use name for this query language "SQL/JSON path expressions" - so important source is SQL/JSON (this can be different than origin JSONPath (your second source)). Regards Pavel Regards Pavel > Thanks, > Christian >

Re: [HACKERS] proposal: psql \setfileref

2016-11-15 Thread Pavel Stehule
2016-11-15 16:41 GMT+01:00 Corey Huinker : > > On Sun, Nov 13, 2016 at 1:46 PM, Pavel Stehule > wrote: > >> r - read file without any modification >> rq - read file, escape as literal and use outer quotes >> rb - read binary file - transform to hex code st

Re: [HACKERS] proposal: psql \setfileref

2016-11-15 Thread Pavel Stehule
Hi 2016-11-13 19:46 GMT+01:00 Pavel Stehule : > Hi > > I am sending a initial implementation of psql content commands. This > design is reaction to Tom's objections against psql file ref variables. > This design is more cleaner, more explicit and more practical - import

Re: [HACKERS] proposal: psql \setfileref

2016-11-15 Thread Pavel Stehule
2016-11-15 17:39 GMT+01:00 Daniel Verite : > Corey Huinker wrote: > > > I am not asking for this feature now, but do you see any barriers to > later > > adding x/xq/xb/xbq equivalents for executing a shell command? > > For text contents, we already have this (pasted right from the doc): >

[HACKERS] regression tests fails

2016-11-15 Thread Pavel Stehule
Hi I have a repeated problem with regress tests master, Fedora 25, running on port 50848 with PID 5548 == creating database "regression" == CREATE DATABASE ALTER DATABASE == running regression test queries== test ddl

Re: [HACKERS] proposal: psql \setfileref

2016-11-16 Thread Pavel Stehule
2016-11-16 16:59 GMT+01:00 Robert Haas : > On Tue, Nov 15, 2016 at 11:48 AM, Pavel Stehule > wrote: > >> For text contents, we already have this (pasted right from the doc): > >> > >> testdb=> \set content `cat my_file.txt` > >> testdb=> INSERT IN

Re: [HACKERS] proposal: psql \setfileref

2016-11-16 Thread Pavel Stehule
2016-11-16 17:58 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > The Daniel's proposal has important issues: > > > 1. you need to store and hold the content in memory > > 2. you cannot use tab complete - without it this feature lost a usability > > 3. you hav

Re: [HACKERS] proposal: psql \setfileref

2016-11-17 Thread Pavel Stehule
Hi a independent implementation of parametrized queries can looks like attached patch: this code is simple without any unexpected behave. parameters are used when user doesn't require escaping and when PARAMETRIZED_QUERIES variable is on Regards Pavel diff --git a/src/bin/psql/common.c b/src/b

Re: [HACKERS] proposal: psql \setfileref

2016-11-17 Thread Pavel Stehule
Hi 2016-11-17 12:00 GMT+01:00 Pavel Stehule : > > Hi > > a independent implementation of parametrized queries can looks like > attached patch: > > this code is simple without any unexpected behave. > > parameters are used when user doesn't require escaping

[HACKERS] possible optimizations - pushing filter before aggregation

2016-11-18 Thread Pavel Stehule
Hi In one application I see slow queries. There is often used views like CREATE VIEW v AS SELECT min(a) M1, min(b) M2, max(c) M3, x, y, z FROM t1 GROUP BY x, y, z; and queries like SELECT * FROM v WHERE M2 = const1 AND M3 > const2 Isn't possible in this case push equivalence befor

Re: [HACKERS] patch: function xmltable

2016-11-18 Thread Pavel Stehule
Hi 2016-11-17 19:22 GMT+01:00 Alvaro Herrera : > I've been going over this patch. I think it'd be better to restructure > the before adding the docs for this new function; I already > split it out, so don't do anything about this. > > Next, looking at struct TableExprBuilder I noticed that the

Re: [HACKERS] possible optimizations - pushing filter before aggregation

2016-11-18 Thread Pavel Stehule
2016-11-19 3:59 GMT+01:00 Douglas Doole : > > On Fri, Nov 18, 2016 at 12:47 AM Pavel Stehule > wrote: > > Isn't possible in this case push equivalence before aggregation? > > > If I'm understanding you correctly, that would lead to wrong results. > Here

Re: [HACKERS] patch: function xmltable

2016-11-18 Thread Pavel Stehule
2016-11-19 0:42 GMT+01:00 Alvaro Herrera : > The SQL standard seems to require a comma after the XMLNAMESPACES > clause: > > ::= > XMLTABLE > [ ] > > [ ] > COLUMNS > > I don't understand the reason for that, but I have added it: > > | XMLTABLE '(' XMLN

Re: [HACKERS] patch: function xmltable

2016-11-18 Thread Pavel Stehule
2016-11-19 5:19 GMT+01:00 Pavel Stehule : > > > 2016-11-19 0:42 GMT+01:00 Alvaro Herrera : > >> The SQL standard seems to require a comma after the XMLNAMESPACES >> clause: >> >> ::= >> XMLTABLE >> [ ] >> >> [ ] >>

Re: [HACKERS] regression tests fails

2016-11-20 Thread Pavel Stehule
2016-11-16 5:54 GMT+01:00 Pavel Stehule : > Hi > > I have a repeated problem with regress tests > > master, Fedora 25, > > running on port 50848 with PID 5548 > == creating database "regression" == > CREATE DATABASE >

Re: [HACKERS] regression tests fails

2016-11-20 Thread Pavel Stehule
2016-11-21 8:09 GMT+01:00 Craig Ringer : > On 21 November 2016 at 14:45, Pavel Stehule > wrote: > > > SELECT (regexp_split_to_array(data, ':'))[4], COUNT(*), > > (array_agg(data))[1], (array_agg(data))[count(*)] > > FROM pg_logical_slot_get_changes('

Re: [HACKERS] regression tests fails

2016-11-20 Thread Pavel Stehule
2016-11-21 8:13 GMT+01:00 Pavel Stehule : > > > 2016-11-21 8:09 GMT+01:00 Craig Ringer : > >> On 21 November 2016 at 14:45, Pavel Stehule >> wrote: >> >> > SELECT (regexp_split_to_array(data, ':'))[4], COUNT(*), >> > (ar

Re: [HACKERS] Danger of automatic connection reset in psql

2016-11-21 Thread Pavel Stehule
2016-11-22 3:46 GMT+01:00 Robert Haas : > On Mon, Nov 21, 2016 at 4:55 AM, Oleksandr Shulgin > wrote: > > On Tue, Nov 15, 2016 at 4:10 PM, Jim Nasby > wrote: > >> > >> On 11/14/16 5:41 AM, Oleksandr Shulgin wrote: > >>> > >>> Automatic connection reset is a nice feature for server development, >

Re: [HACKERS] patch: function xmltable

2016-11-21 Thread Pavel Stehule
2016-11-21 21:16 GMT+01:00 Tom Lane : > Alvaro Herrera writes: > > Something I just noticed is that transformTableExpr takes a TableExpr > > node and returns another TableExpr node. That's unlike what we do in > > other places, where the node returned is of a different type than the > > input no

Re: [HACKERS] Danger of automatic connection reset in psql

2016-11-22 Thread Pavel Stehule
2016-11-22 13:02 GMT+01:00 Oleksandr Shulgin : > On Tue, Nov 22, 2016 at 5:28 AM, Pavel Stehule > wrote: > >> >> 2016-11-22 3:46 GMT+01:00 Robert Haas : >> >>> On Mon, Nov 21, 2016 at 4:55 AM, Oleksandr Shulgin >>> wrote: >>> &

[HACKERS] new gcc 7.0.1 warnings

2017-02-17 Thread Pavel Stehule
Hi I am checking new Fedora 26, where new gcc compiler is used. float.c: In function ‘float4out’: float.c:382:41: warning: ‘%.*g’ directive output may be truncated writing between 1 and 310 bytes into a region of size 65 [-Wformat-truncation=] snprintf(ascii, MAXFLOATWIDTH + 1, "%.*g", ndig,

Re: [HACKERS] new gcc 7.0.1 warnings

2017-02-18 Thread Pavel Stehule
2017-02-18 18:35 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > float.c:382:5: note: ‘snprintf’ output between 2 and 311 bytes into a > > destination of size 65 > > float.c:618:5: note: ‘snprintf’ output between 2 and 311 bytes into a > > destination of size 129 >

[HACKERS] Error in XML recv function

2017-02-20 Thread Pavel Stehule
Hi When I did tests of own XML import functions I found a strange error. I successfully imported XML to PostgreSQL. This document is readable without any visual defects. But when I tested this document against any libxml2 function I found a error - ERROR: could not parse XML document DETAIL: i

[HACKERS] possible encoding issues with libxml2 functions

2017-02-20 Thread Pavel Stehule
Hi Today I played with xml_recv function and with xml processing functions. xml_recv function ensures correct encoding from document encoding to server encoding. But the decl section holds original encoding info - that should be obsolete after encoding. Sometimes we solve this issue by removing d

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2017-02-21 Thread Pavel Stehule
2017-02-14 11:51 GMT+01:00 Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp>: > Thank you for the comment. > > At Mon, 6 Feb 2017 17:10:43 +0100, Pavel Stehule > wrote in mail.gmail.com> > > > 0001-Refactoring-tab-complete-to-make-psql_completion-cod.patch &

Re: [HACKERS] GRANT EXECUTE ON FUNCTION foo() TO bar();

2017-02-22 Thread Pavel Stehule
2017-02-22 8:06 GMT+01:00 Joel Jacobson : > Hi Hackers, > > Currently, it's only possible to grant/revoke execute on functions to > roles. > > I think it would be useful in many situations, both for documentation > purposes, > but also for increased security, to in a precise way control what > oth

Re: [HACKERS] GRANT EXECUTE ON FUNCTION foo() TO bar();

2017-02-22 Thread Pavel Stehule
2017-02-22 9:20 GMT+01:00 Joel Jacobson : > On Wed, Feb 22, 2017 at 9:07 AM, Pavel Stehule > wrote: > > Usage of X functions can be locked in schema. > > I think that's also a good idea. Both are useful I think. They solve > two different use-cases. > > If there a

[HACKERS] ToDo: Schema Private Function

2017-02-22 Thread Pavel Stehule
Hi I propose a schema private functions as analogy to Oracle package functions. My target of this proposal is better isolation generally available top level callable functions from other auxiliary functions. A execution of functions can be little bit more robust due less dependency on SEARCH_PATH

[HACKERS] proposal - psql: possibility to specify sort for describe commands, when size is printed

2017-02-23 Thread Pavel Stehule
Hi Currently is not possible to control sort columns for \d* commands. Usually schema and table name is used. Really often task is collect the most big objects in database. "\dt+, \di+" shows necessary information, but not in practical order. Instead introduction some additional flags to backslas

<    1   2   3   4   5   6   7   8   9   10   >