On Mon, 3 Oct 2016 13:35:16 +0900
Michael Paquier wrote:
>
> Moved to next CF, the patch still applies. Karl, you have registered
> to review this patch a couple of months back but nothing happened. I
> have removed your name for now. If you have time, don't hesitate to
> come back to it.
Right.
On Tue, 18 Oct 2016 14:18:36 +0200
Gilles Darold wrote:
> Here is the v6 of the patch, here is the description of the
> pg_current_logfile() function, I have tried to keep thing as simple as
> possible:
>
> pg_current_logfile( [ destination text ] )
>
On Tue, 25 Oct 2016 22:30:48 -0500
"Karl O. Pinc" wrote:
> Hope to provide more feedback soon.
Before I forget:
"make check" fails, due to oid issues with pg_current_logfile().
You're writing Unix eol characters into pg_log_file. (I think.)
Does this matter on MS
On Tue, 25 Oct 2016 22:53:41 -0500
"Karl O. Pinc" wrote:
> On Tue, 25 Oct 2016 22:30:48 -0500
> "Karl O. Pinc" wrote:
>
> > Hope to provide more feedback soon.
Er, attached is yet another doc patch to the v6 patch.
Sorry about that.
Changes pg_curre
Another new version of a doc patch to the v6 patch.
More better English. *sigh*
Regards,
Karl
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
patch_pg_current_logfile-v6.diff.patchv4
Description: Binary data
--
Sent via pgsql-hackers mailing li
On Tue, 25 Oct 2016 22:30:48 -0500
"Karl O. Pinc" wrote:
> Since pg_log_file may contain only one line, and that
> line may be either the filename of the csv log file or
> the file name of the stderr file name it's impossible
> to tell whether that single file is in
On Thu, 27 Oct 2016 00:31:56 +0200
Gilles Darold wrote:
> Thanks a lot for the documentation fixes, I've also patched some of
> your changes, see v7 of the patch and explanations bellow.
Thanks. Sorry if I've not kept up on your latest decisions.
> > Put pg_log_file in alphabetical order in th
On Thu, 27 Oct 2016 11:07:43 +0200
Christoph Berg wrote:
> Re: Karl O. Pinc 2016-10-27 <20161026222513.74cd3...@slate.meme.com>
> > But what if current_logfile contains only a single line? What
> > sort of file format does the logfile have? If you don't know
> &g
On Thu, 27 Oct 2016 19:03:11 +0200
Gilles Darold wrote:
> >> Re: Karl O. Pinc 2016-10-27
> >> <20161026222513.74cd3...@slate.meme.com>
> > Your comment makes me wonder if pg_current_logfile(), without
> > arguments, should instead be "SHOW current_logf
On Thu, 27 Oct 2016 19:57:18 +0200
Christoph Berg wrote:
> Re: Karl O. Pinc 2016-10-27 <20161027121141.6bd95...@slate.meme.com>
> > SELECT * from postgres.pg_current_logfile;
> We were discussing exactly that idea upthread before concluding that a
> function with a single
On Thu, 27 Oct 2016 19:03:11 +0200
Gilles Darold wrote:
> The current v8 of the patch
Attached is a doc patch for your v8 patch.
Added , so the docs would build.
Added markup of "system values".
Hope to look at code soon!
Karl
Free Software: "You don't pay back, you pay forward."
On Thu, 27 Oct 2016 16:18:02 -0500
"Karl O. Pinc" wrote:
> On Thu, 27 Oct 2016 19:03:11 +0200
> Gilles Darold wrote:
>
> > The current v8 of the patch
>
> Attached is a doc patch for your v8 patch.
>
> Added , so the docs would build.
>
> A
On Thu, 27 Oct 2016 19:03:11 +0200
Gilles Darold wrote:
> The current v8 of the patch
Attached is a patch to the v8 version of your patch.
It rewords some of the comments in the code. Take the hunks
or leave them as you wish.
Regards,
Karl
Free Software: "You don't pay back, you pay forwa
Hi Gilles,
On Thu, 27 Oct 2016 19:03:11 +0200
Gilles Darold wrote:
> The current v8 of the patch
For your consideration.
Attached is a patch to apply to v8 of your patch.
I moved the call to logfile_writename() in write_syslogger_file()
into the open_csvlogfile(). That's where the new filena
On Thu, 27 Oct 2016 22:09:41 -0500
"Karl O. Pinc" wrote:
> On Thu, 27 Oct 2016 19:03:11 +0200
> Gilles Darold wrote:
>
> > The current v8 of the patch
>
> For your consideration.
>
> Attached is a patch to apply to v8 of your patch.
>
>
On Thu, 27 Oct 2016 19:03:11 +0200
Gilles Darold wrote:
> The current v8 of the patch
Perhaps instead of the define CURRENT_LOG_FILENAME
a better name for the symbol would be LOG_METAINFO_FILE?
Regards,
Karl
Free Software: "You don't pay back, you pay forward."
-- Robert A.
On Fri, 28 Oct 2016 10:03:37 +0200
Gilles Darold wrote:
> ...
> the v9 of the patch, attached here.
I notice that there are a number of user-supplied GUC
values for log_destination that are repeatedly used,
both in the GUC code and in your patch. These are
presently written as hardcoded strings
On Fri, 28 Oct 2016 10:03:37 +0200
Gilles Darold wrote:
> ...
> v9 of the patch, attached here.
Attached are 2 more documentation patchs to apply on
top of your v9 patch.
patch_pg_current_logfile-v9.diff.doc_current_logfiles
Explains the current_logfiles file in the
narrative documentation.
On Sat, 29 Oct 2016 22:00:08 +0200
Gilles Darold wrote:
> The attached v10 of the current_logfiles patch include your last
> changes on documentation but not the patch on v9 about the
> user-supplied GUC value. I think the v10 path is ready for committers
> and that the additional patch to add sr
On Tue, 28 Jun 2016 11:06:24 +0200
Gilles Darold wrote:
> Le 07/04/2016 08:30, Karl O. Pinc a écrit :
> > "src/backend/postmaster/syslogger.c expects to see fopen() fail
> > with
> ENFILE and EMFILE. What will you do if you get these?"
>
> - Nothing, if
Hi Gilles,
On Sat, 29 Oct 2016 22:00:08 +0200
Gilles Darold wrote:
> The attached v10 of the current_logfiles patch
Attached is a patch to apply on top of the v10 patch.
It updates current_logfiles only once per log rotation.
I see no reason to open and write the file twice
if both csvlog and
On Mon, 31 Oct 2016 09:26:27 +0100
Gilles Darold wrote:
> Le 30/10/2016 à 08:04, Karl O. Pinc a écrit :
> Attached patch v11 include your patch.
>
> >
> > I have some questions about logfile_writename():
> >
> > Why does the logfile_open() call fail silently?
On Wed, 2 Nov 2016 10:07:34 +0100
Gilles Darold wrote:
> Please have a look at line 1137 on HEAD of syslogger.c you will see
> that in case of failure function logfile_open() report a FATAL or LOG
> error with message:
>
> errmsg("could not open log file \"%s\": %m", filename);
Ok. Thanks
On Wed, 2 Nov 2016 07:55:45 -0500
"Karl O. Pinc" wrote:
> On Wed, 2 Nov 2016 10:07:34 +0100
> Gilles Darold wrote:
>
> > Please have a look at line 1137 on HEAD of syslogger.c
> Ok. Thanks. Sorry for the confusion.
And yes, we did talk about this before. I s
On Mon, 31 Oct 2016 09:26:27 +0100
Gilles Darold wrote:
> Le 30/10/2016 à 08:04, Karl O. Pinc a écrit :
> > Have you given any thought to my proposal to change
> > CURRENT_LOG_FILENAME to LOG_METAINFO_FILE?
> Yes, I don't think the information logged in this
On Thu, 3 Nov 2016 18:34:50 -0500
"Karl O. Pinc" wrote:
> On Mon, 31 Oct 2016 09:26:27 +0100
> Gilles Darold wrote:
>
> > Le 30/10/2016 à 08:04, Karl O. Pinc a écrit :
>
> > > Have you given any thought to my proposal to change
> > > CURRENT_LOG
On Mon, 31 Oct 2016 10:19:18 +0100
Gilles Darold wrote:
> Le 31/10/2016 à 04:35, Karl O. Pinc a écrit :
> > Attached is a patch to apply on top of the v10 patch.
> >
> > It updates current_logfiles only once per log rotation.
> > I see no reason to open and write
On Fri, 4 Nov 2016 16:58:45 +0100
Gilles Darold wrote:
> I attached a v12 patch
Attached is a comment patch which improves the comment
describing CURRENT_LOG_FILENAME. It's been bugging me.
I should have made this change long ago when I looked
at all the other code comments but neglected to.
On Mon, 7 Nov 2016 23:29:28 +0100
Gilles Darold wrote:
> Here is the v13 of the patch,
> - I've reverted the patch removing the call to logfile_writename in
> open_csvlogfile function, it is required to write log filename at
> startup when log_destination is set to csvlog. I could not find a
On Sat, 12 Nov 2016 12:59:46 -0600
"Karl O. Pinc" wrote:
> On Mon, 7 Nov 2016 23:29:28 +0100
> Gilles Darold wrote:
> > Here is the v13 of the patch,
> > - Do not write current_logfiles when log_collector is activated
> > but log_destination doesn'
On Mon, 7 Nov 2016 23:29:28 +0100
Gilles Darold wrote:
> Here is the v13 of the patch,
Just to keep things up to date... Attached are 3 re-worked patches
that I see submitting along with the pg_current_logfile patch.
They apply on top of v13.
(I still have one more I'm working on to ensure tha
On Mon, 7 Nov 2016 23:29:28 +0100
Gilles Darold wrote:
> Here is the v13 of the patch, ...
Attached is a doc patch to apply on top of v13.
It adds a lot more detail regards just what is
in the current_logfiles file and when it's
in current_logfiles. I'd like review both for
language and accura
Hi Gilles,
On Sun, 30 Oct 2016 02:04:59 -0500
"Karl O. Pinc" wrote:
> Attached is a patch to be applied on top of your v10 patch
> which does basic fixup to logfile_writename().
I'm looking at the v13 patch and don't see a change I submitted
with a patch to v10.
On Sat, 19 Nov 2016 12:58:47 +0100
Gilles Darold wrote:
> All patches you've submitted on tha v13 patch have been applied and
> are present in attached v14 of the patch. I have not included the
> patches about GUC changes because I'm not sure that adding a new file
> (include/utils/guc_values.h)
Hi Gilles,
On Tue, 15 Nov 2016 15:15:52 -0600
"Karl O. Pinc" wrote:
> > On Mon, 7 Nov 2016 23:29:28 +0100
> > Gilles Darold wrote:
> > > - Do not write current_logfiles when log_collector is activated
> > > but log_destination doesn't contained
On Sat, 19 Nov 2016 18:59:49 +0100
Gilles Darold wrote:
> Le 19/11/2016 à 16:22, Karl O. Pinc a écrit :
> > Hi Gilles,
> >
> > On Tue, 15 Nov 2016 15:15:52 -0600
> > "Karl O. Pinc" wrote:
> >
> >>> On Mon, 7 Nov 2016 23:29:28 +0100
On Mon, 21 Nov 2016 13:17:17 -0500
Robert Haas wrote:
> > I've a couple of other patches that do
> > a little cleanup on master that I'd also like to submit
> > along with your patch.
> It would really be much better to submit anything that's not
> absolutely necessary for the new feature as a
On Fri, 3 Mar 2017 15:24:53 +0900
Michael Paquier wrote:
>
> + /*
> +* No space found, file content is corrupted. Return
> NULL to the
> +* caller and inform him on the situation.
> +*/
> + elog(ERROR,
> +"missing space char
On Sat, 4 Mar 2017 14:26:54 +0530
Robert Haas wrote:
> On Fri, Mar 3, 2017 at 7:21 PM, Karl O. Pinc wrote:
> > But if the code does not exit the loop then
> > before calling elog(ERROR), shouldn't it
> > also call FreeFile(fd)?
>
> Hmm. Normally error reco
Hi,
The attached documentation patch, doc-subqueries-v1.patch,
applies against head.
I wanted to document that subqueries can't modify data.
This is mentioned in the documentation for SELECT and
implied elsewhere but I was looking for something more
than an 'in-passing' mention.
(I wrote a bad
Good points.
On 08/06/2013 05:15:28 PM, David Johnston wrote:
> Instead of simply expanding the section on sub-queries, which may
> still be
> worthwhile, it seems that we have effectively introduced a new "kind"
> of
> query - namely one that mixes both query DDL and update DDL into a
> kind of
>
On 08/07/2013 08:19:03 PM, Peter Eisentraut wrote:
> We have these two error messages:
>
> To make the view updatable, provide an unconditional ON UPDATE DO
> INSTEAD rule or an INSTEAD OF UPDATE trigger.
>
> and
>
> To make the view updatable, provide an unconditional ON DELETE DO
> INSTEAD rul
On 09/02/2013 10:56:54 PM, Karl O. Pinc wrote:
> I have frobbed your to adjust the indentation and
> line-wrap style.
Oops. Somehow left a \ out of this. Anyhow, you get the idea.
Karl
Free Software: "You don't pay back, you pay forward."
On 09/26/2013 12:15:25 PM, Ivan Lezhnjov IV wrote:
>
> On Sep 3, 2013, at 6:56 AM, Karl O. Pinc wrote:
>
> > On 07/31/2013 12:08:12 PM, Ivan Lezhnjov IV wrote:
> >
> >> Patch filename: backup.sgml-cmd-v003.patch
> >>
> >> The third version
Hi Robert,
On 09/27/2013 05:56:52 AM, Robert Haas wrote:
> 1. Attempting to encourage people to consider custom format dumps.
> What's important is what you can do...
Your critique seems obvious in retrospect. Sorry you had
to step in here and do my job. The above point is particularly
sali
On 11/08/2013 02:12:56 PM, Robert Haas wrote:
> On Fri, Nov 8, 2013 at 1:33 PM, Joshua D. Drake
>
> wrote:
> superuser privileges; it's the selective-dump case where you can
> often
> get by without them. I've attached a proposed patch along these
> lines
> for your consideration.
On 11/08/2013 03:42:56 PM, Joshua D. Drake wrote:
>
> On 11/08/2013 12:18 PM, Karl O. Pinc wrote:
> >
> > On 11/08/2013 02:12:56 PM, Robert Haas wrote:
> >> On Fri, Nov 8, 2013 at 1:33 PM, Joshua D. Drake
> >>
> >> wrote:
> >>>>
On 06/04/2013 10:16:20 PM, Peter Eisentraut wrote:
> On Tue, 2013-05-07 at 23:18 -0400, Alvaro Herrera wrote:
> > Peter Eisentraut wrote:
> > > On Tue, 2013-05-07 at 00:32 -0500, Karl O. Pinc wrote:
> > > > Attached is a documentation patch against head which makes
On 06/05/2013 09:13:45 PM, Peter Eisentraut wrote:
> On Tue, 2013-06-04 at 22:27 -0500, Karl O. Pinc wrote:
> > On 06/04/2013 10:16:20 PM, Peter Eisentraut wrote:
> > > On Tue, 2013-05-07 at 23:18 -0400, Alvaro Herrera wrote:
> > > > Peter Eisentraut wrote:
> &g
On 11/03/2012 01:45:36 PM, Pavel Stehule wrote:
> Hello
>
> here is a updated patch
This message does not appear to be threaded so I'm not
sure I've read the whole back-history. Also, I don't
really know what I'm doing. Never the less, I want
to try to contribute to somebody else's patch so
her
Hi Pavel,
On 11/16/2012 12:21:11 AM, Pavel Stehule wrote:
> 2012/11/16 Karl O. Pinc :
> > As long as I'm talking crazy talk, why not
> > abandon psql as a shell language and instead make a
> > pl/pgsql interpreter with readlne() in front
> > of it? Solve all t
On 11/17/2012 12:19:02 AM, Peter Eisentraut wrote:
> On Fri, 2012-09-28 at 11:10 -0500, Karl O. Pinc wrote:
> > pg_temp-toindex.patch
> > Puts pg_temp into the index of the docs.
>
> But there is no object called pg_temp. It always pg_temp_
> something. How sho
On 11/17/2012 12:27:14 AM, Peter Eisentraut wrote:
> On Sun, 2012-09-23 at 21:22 -0500, Karl O. Pinc wrote:
> > Hi,
> >
> > Adds a caution to the pg_restore docs
> >
> > Against git master.
>
> I'm not sure what you are trying to get at here
On 11/17/2012 05:10:12 PM, Peter Eisentraut wrote:
> On Sat, 2012-11-17 at 11:33 -0600, Karl O. Pinc wrote:
> >
what's
> > indexed is the token pg_temp, used when
> > setting search_path.
> Actually, since this is the pg_temp alias for the search path, it is
>
On 11/17/2012 12:16:06 AM, Peter Eisentraut wrote:
> I'm unsure whether splitting this out into a list (or table) is an
> improvement. Other opinions?
>
> This page is written as a narrative explanation of the RAISE feature,
> but there is probably a desire to also have it serve as a reference
>
On 11/19/2012 02:30:49 AM, Pavel Stehule wrote:
> Hello
>
> 2012/11/16 Karl O. Pinc :
> > Hi Pavel,
> >
> > On 11/16/2012 12:21:11 AM, Pavel Stehule wrote:
> >> 2012/11/16 Karl O. Pinc :
> >
> >> > As long as I'm talking crazy talk, why n
Hi Josh,
On 11/20/2012 11:53:23 PM, Josh Kupershmidt wrote:
> Hi Karl,
> I signed on to review this patch for the current CF.
I noticed. Thanks very much.
> On Fri, Sep 21, 2012 at 8:54 AM, Karl O. Pinc wrote:
> > On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote:
> &g
On 11/21/2012 01:41:56 PM, Peter Eisentraut wrote:
> On 11/15/12 3:53 PM, Karl O. Pinc wrote:
> > This patch gives the end user control over psql's
> > error stream. This allows a single psql session
> > to use \o to send both errors and table output
> > to multip
On 11/21/2012 02:12:26 PM, Robert Haas wrote:
> On Sat, Nov 17, 2012 at 1:22 AM, Peter Eisentraut
> wrote:
> > On Mon, 2012-11-12 at 11:42 -0600, Karl O. Pinc wrote:
> >> Could ALTER TABLE use an option to drop the
> >> primary key constraint? I needed to do that,
On 11/21/2012 01:41:56 PM, Peter Eisentraut wrote:
> On 11/15/12 3:53 PM, Karl O. Pinc wrote:
> > This patch gives the end user control over psql's
> > error stream. This allows a single psql session
> > to use \o to send both errors and table output
> > to multip
On 11/21/2012 10:00:11 PM, Karl O. Pinc wrote:
> On 11/21/2012 02:12:26 PM, Robert Haas wrote:
> > On Sat, Nov 17, 2012 at 1:22 AM, Peter Eisentraut
> > wrote:
> > > On Mon, 2012-11-12 at 11:42 -0600, Karl O. Pinc wrote:
> > >> Could ALTER TABLE use an o
On 11/26/2012 12:06:56 PM, Robert Haas wrote:
> On Wed, Nov 21, 2012 at 12:53 AM, Josh Kupershmidt
> wrote:
> > TBH, I didn't find the example above particularly compelling for
> > demonstrating the need for this feature. If you've just got one
> table
> > with dependent views which needs to be re
On 11/26/2012 08:45:08 PM, Josh Kupershmidt wrote:
> On Mon, Nov 26, 2012 at 3:42 PM, Robert Haas
> wrote:
> > On Mon, Nov 26, 2012 at 4:51 PM, Karl O. Pinc wrote:
> >> P.S. An outstanding question regards --truncate-tables
> >> is whether it should drop index
On 11/26/2012 09:30:48 PM, Karl O. Pinc wrote:
> On 11/26/2012 08:45:08 PM, Josh Kupershmidt wrote:
> > It is a common administrative task to selectively restore some
> > existing tables' contents from a backup, and IIRC was the impetus
> for
> > this patch.
>
On 12/04/2012 09:26:47 PM, Josh Kupershmidt wrote:
> Sorry for the delay in following up here.
No problem at all.
> Well, as far as I was able to tell, the use-case where this patch
> worked without trouble was limited to restoring a table, or schema
> with table(s), that:
> a.) has some view(s)
On 11/21/2012 11:33:18 PM, Karl O. Pinc wrote:
> On 11/21/2012 01:41:56 PM, Peter Eisentraut wrote:
> > On 11/15/12 3:53 PM, Karl O. Pinc wrote:
> > > This patch gives the end user control over psql's
> > > error stream. This allows a single psql session
> &g
Hi Alastair,
On 12/09/2012 02:13:32 PM, Alastair Turner wrote:
> Hi Karl,
>
> I have given the patch a quick review and read the related mails
> following its initial submission.
Thank you very much.
> - It's closed ended - there are three things about error output which
> affect where it's wri
On 12/09/2012 03:58:26 PM, Karl O. Pinc wrote:
> Hi Alastair,
>
> On 12/09/2012 02:13:32 PM, Alastair Turner wrote:
> > - It's closed ended - there are three things about error output
> which
> > affect where it's written to: does it go to query output, does i
Hi,
I don't feel particularly qualified to comment, but in the
interest of (hopefully) helping with the patch review process
I'm going to comment anyway.
(Having written this, I feel decidedly unqualified
to critique so please keep this in mind when
considering my comments.)
On 10/31/2012 04:33:
On 12/09/2012 10:33:59 PM, Karl O. Pinc wrote:
> Hi,
>
> I don't feel particularly qualified to comment, but in the
> interest of (hopefully) helping with the patch review process
> I'm going to comment anyway.
I've gone ahead and signed up to review this patch.
Hi,
The top-level README in the source tarball says:
-
See the file INSTALL for instructions on how to build and install
PostgreSQL. That file also lists supported operating systems and
hardware platforms and contains information regarding any other
so
On 12/10/2012 01:29:03 PM, Heikki Linnakangas wrote:
> On 10.12.2012 21:19, Karl O. Pinc wrote:
> > The top-level README in the source tarball says:
> >
> > -
> > See the file INSTALL for instructions on how to build and in
On 11/08/2012 11:55:19 AM, Karl O. Pinc wrote:
> On 11/08/2012 11:10:39 AM, Robert Haas wrote:
> > Ah, well, as to that, I think you'd have to take that suggestion to
> > pgsql-www. The style sheets used for the web site are - just to
> make
> > things exciting - sto
On 11/14/2012 02:35:54 PM, Karl O. Pinc wrote:
> On 11/13/2012 08:50:55 PM, Peter Eisentraut wrote:
> > On Sat, 2012-09-29 at 01:16 -0500, Karl O. Pinc wrote:
> > > This patch makes some sweeping statements.
> >
> > Unfortunately, they are wrong.
>
> I
On 10/30/2012 10:14:19 PM, Josh Kupershmidt wrote:
> I went ahead and cooked up a patch to allow pg_restore, clusterdb,
> vacuumdb, and reindexdb to accept multiple --table switches. Hope I
> didn't overlook a similar tool, but these were the only other
> commands
> I found taking a --table argum
ch go into 10.0 (!?) and
introduce a patch now that complains about multiple
--table arguments. On the other hand, perhaps it's
simply undocumented what pg_restore does when
given repeated, conflicting, arguments and we're
free to change this. Any thoughts?
On 12/10/2012 09:23:03 PM, Karl
On 12/11/2012 10:25:43 PM, Josh Kupershmidt wrote:
> On Tue, Dec 11, 2012 at 11:46 AM, Karl O. Pinc wrote:
> > Yes, the current pg_restore silently
> > ignores multiple --table arguments, and seems to use the last
> > one. You are introducing a backwards incompatible
> &
Hi Jan and Oskari,
On 12/12/2012 11:36:54 AM, Jan Urbański wrote:
> On 10/12/12 19:20, Karl O. Pinc wrote:
> > On 12/09/2012 10:33:59 PM, Karl O. Pinc wrote:
> > There were 2 outstanding issue raised:
> >
> > Is this useful enough/proceeding in the right directio
Hi Josh,
The good news is that there's only this little bit of
documentation formatting to fix
On 12/12/2012 11:04:53 PM, Josh Kupershmidt wrote:
> On Wed, Dec 12, 2012 at 8:14 AM, Karl O. Pinc wrote:
> > On 12/11/2012 10:25:43 PM, Josh Kupershmidt wrote:
> >> On Tue
On 12/13/2012 12:35:14 AM, Karl O. Pinc wrote:
> On 12/12/2012 11:04:53 PM, Josh Kupershmidt wrote:
> > On Wed, Dec 12, 2012 at 8:14 AM, Karl O. Pinc wrote:
> > > On 12/11/2012 10:25:43 PM, Josh Kupershmidt wrote:
> > >> On Tue, Dec 11, 2012 at 11:46 AM, Karl O
On 12/13/2012 07:37:27 PM, Josh Kupershmidt wrote:
> On Thu, Dec 13, 2012 at 6:05 AM, Karl O. Pinc wrote:
> > On 12/13/2012 12:35:14 AM, Karl O. Pinc wrote:
> >
> >> On 12/12/2012 11:04:53 PM, Josh Kupershmidt wrote:
> >> > On Wed, Dec 12, 2012 at 8:14 AM, Karl
On 12/13/2012 09:24:24 PM, Josh Kupershmidt wrote:
> On Thu, Dec 13, 2012 at 7:24 PM, Karl O. Pinc wrote:
> > As a fallback I'd do to the clusterdb, reindexdb, and vacuumdb
> > syntax summaries what was done to the pg_dump and pg_restore
> > syntax summaries. Remov
On 12/13/2012 11:02:56 PM, Josh Kupershmidt wrote:
> On Thu, Dec 13, 2012 at 9:03 PM, Karl O. Pinc wrote:
> > Sorry to be so persnickety, and unhelpful until now.
> > It seemed like it should be doable, but something
> > was going wrong between keyboard and chair. I guess
On 12/14/2012 02:04:45 AM, Jeff Davis wrote:
> On Tue, 2012-10-02 at 10:46 -0500, Karl O. Pinc wrote:
> > I am now submitting patches to the commitfest
> > for review. (I'm not sure how I missed this.)
>
> I prefer this version of the patch. I also attached an alte
On 12/13/2012 10:05:15 PM, Peter Eisentraut wrote:
> The other configuration parameters are all indexed as "x_y_z
> configuration parameter", so I've kept search_path aligned with that.
> I
> have applied your other changes, so I think it's good now. Let me
> know
> if you feel additional change
On 12/16/2012 12:56:22 AM, Peter Eisentraut wrote:
> On Mon, 2012-12-10 at 20:48 -0600, Karl O. Pinc wrote:
> > On 11/14/2012 02:35:54 PM, Karl O. Pinc wrote:
> > > On 11/13/2012 08:50:55 PM, Peter Eisentraut wrote:
> > > > On Sat, 2012-09-29 at 01:16 -0500, Karl
On 12/16/2012 12:51:06 AM, Peter Eisentraut wrote:
> I'm going to set this patch as returned with feedback for now.
Ok. At this point I don't have a vision for improving it
so it might sit there untouched. Maybe someone else
will step forward and make it better.
Regards,
Karl
Free Software:
Hi Allastair,
On 12/28/2012 02:33:03 PM, Alastair Turner wrote:
> Sorry for the slow reply ...
Such is life.
> The discussion needs to be a little broader than stdout and stderr,
> there are currently three output streams from psql:
> - stdout - prompts, not tabular output such as the results
On 01/09/2013 01:08:39 PM, Jan Urbański wrote:
> > I can see arguments to be made for both sides. I'm asking that you
> > think it through to the extent you deem necessary and make
> > changes or not. At that point it should be ready to send
> > to a committer. (I'll re-test first, if you make
On 01/25/2013 12:35:49 PM, Tom Lane wrote:
> Bruce Momjian writes:
> > I have applied a modified version of your patch that creates
> separate
> > secondary index references for search_path.
>
> This patch seems pretty bizarre. What is the difference between a
> "configuration parameter" and a "
Hi,
Attached is a documentation patch against head which makes
static the targets of the on-line PG html documentation that
are referenced by the phpPgAdmin help system.
Apply with "patch -p1" at the top of the pg code tree.
The phpPgAdmin project is a web interface into PG. It
contains help li
Hi,
I've had problems using pg_restore --data-only when
restoring individual schemas (which contain data which
has had bad things done to it). --clean does not work
well because of dependent objects in other schemas.
Patch to the docs attached (before I go and do any
real coding.)
Karl
Free S
On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote:
> I've had problems using pg_restore --data-only when
> restoring individual schemas (which contain data which
> has had bad things done to it). --clean does not work
> well because of dependent objects in other schemas.
Before do
On 09/21/2012 10:54:05 AM, Karl O. Pinc wrote:
> On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote:
>
> > I've had problems using pg_restore --data-only when
> > restoring individual schemas (which contain data which
> > has had bad things done to it). --clean does
Whoops. Do over. Sent the wrong file.
On 09/23/2012 12:19:07 AM, Karl O. Pinc wrote:
> On 09/21/2012 10:54:05 AM, Karl O. Pinc wrote:
> > On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote:
> >
> > > I've had problems using pg_restore --data-only when
> > &g
Attached is version 2. The sgml did not build.
On 09/23/2012 12:24:27 AM, Karl O. Pinc wrote:
> Whoops. Do over. Sent the wrong file.
>
> On 09/23/2012 12:19:07 AM, Karl O. Pinc wrote:
> > On 09/21/2012 10:54:05 AM, Karl O. Pinc wrote:
> > > On 09/20/2012 12:24:4
Hi,
The attached patch documents the oid column of those
system catalogs having an oid.
Distinguish system catalogs with an oid from those without
and make the primary key clear to the newbie.
Found catalogs with an oid by querying a 9.2 installation:
select pg_class.relkind, pg_class.relname
Hi,
Adds a caution to the pg_restore docs
Against git master.
Karl
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
index 488d8dc..ad42d38 100644
--- a/doc/src/sgm
Hi,
Patch to add CREATE TABLE AS to the See Also: section
of the CREATE TABLE docs.
Against git master.
(Builds, as do all the previous doc patches.)
Karl
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
diff --git a/doc/src/sgml/ref/create_table.
On 09/23/2012 10:14:33 PM, Tom Lane wrote:
> "Karl O. Pinc" writes:
> > The attached patch documents the oid column of those
> > system catalogs having an oid.
>
> I think this is fundamentally wrong, or at least misleading, because
> it
> documents
1 - 100 of 195 matches
Mail list logo
