On Fri, Dec 2, 2016 at 1:02 PM, Michael Paquier
wrote:
> On Fri, Dec 2, 2016 at 11:26 AM, Andreas Karlsson wrote:
>> I have attached a new version. The commitfest should technically have been
>> closed by now, so do what you like with the status. I can always submit the
>> patch to the next commi
On Fri, Dec 02, 2016 at 07:45:56AM -0500, Robert Haas wrote:
> On Thu, Dec 1, 2016 at 10:07 PM, Haribabu Kommi
> wrote:
> > From the recent mails, it is not clear to me what is the status of this
> > patch.
> > moved to next CF with "needs review" state. Please feel free to update
> > the status.
On 12/04/2016 02:12 PM, Michael Paquier wrote:
One last thing that I think is missing in this patch is for users the
possibility to check via SQL if the SSL context is actually loaded or
not. As the context is reloaded after all the new values are
available, with the current patch users may see t
On Sun, Dec 4, 2016 at 11:11 PM, Andreas Karlsson wrote:
> On 12/04/2016 02:12 PM, Michael Paquier wrote:
>>
>> One last thing that I think is missing in this patch is for users the
>> possibility to check via SQL if the SSL context is actually loaded or
>> not. As the context is reloaded after al
Hello Pavel,
Some possibilities from pgbench can have sense in psql too - generating
some random numbers from a range.
Could you expand on the use case where this would be useful?
In the end we use one parser for psql and for pgbench.
Note that "master" lexer is already shared, thanks to
2016-12-04 17:35 GMT+01:00 Fabien COELHO :
>
> Hello Pavel,
>
> Some possibilities from pgbench can have sense in psql too - generating
>> some random numbers from a range.
>>
>
> Could you expand on the use case where this would be useful?
>
writing test cases
>
> In the end we use one parser
Yes, that is a possibility, but this can already be queried into a
:-variable, so it is less indispensable.
can you show some examples, please?
SELECT COUNT(*) AS has_unit_extension
FROM pg_extension WHERE extname='unit' \gset
\echo :has_unit_extension
1
So that
\if ! :hash_unit_ext
2016-12-04 20:55 GMT+01:00 Fabien COELHO :
>
> Yes, that is a possibility, but this can already be queried into a
>>> :-variable, so it is less indispensable.
>>>
>>
>> can you show some examples, please?
>>
>
> SELECT COUNT(*) AS has_unit_extension
>FROM pg_extension WHERE extname='unit' \gs
On Sat, Dec 3, 2016 at 7:23 PM, Tomas Vondra
wrote:
> I do share your concerns about unpredictable behavior - that's
> particularly worrying for pg_restore, which may be used for time-
> sensitive use cases (DR, migrations between versions), so unpredictable
> changes in behavior / duration are un
Pavel Stehule wrote:
> 2016-12-04 23:00 GMT+01:00 Pavel Stehule :
> > I am not sure if I understand well to your ideas - please, check attached
> > patch.
Thanks, that's what I meant, but I think you went a bit overboard
creating new functions in execQual -- seems to me it would work just
fine to
On Sun, Nov 20, 2016 at 9:54 AM, John Gorman wrote:
> I reviewed the dht-v2.patch and found that it is in excellent shape.
>
> The overall performance will be faster due to not having to examine
> more than one hash bucket array most of the time.
>
>
Reviewer didn't find any problems in the appro
On Fri, Nov 4, 2016 at 8:20 PM, Amit Kapila wrote:
> On Thu, Nov 3, 2016 at 8:38 PM, Robert Haas wrote:
> > On Tue, Nov 1, 2016 at 11:31 PM, Tomas Vondra
> >> The difference is that both the fast-path locks and msgNumLock went into
> >> 9.2, so that end users probably never saw that regression.
On Thu, Nov 24, 2016 at 11:12 PM, Rushabh Lathia
wrote:
>
> PFA latest patch with fix as well as few cosmetic changes.
>
>
Moved to next CF with "needs review" status.
Regards,
Hari Babu
Fujitsu Australia
On 12/04/2016 03:20 PM, Michael Paquier wrote:
On Sun, Dec 4, 2016 at 11:11 PM, Andreas Karlsson wrote:
On 12/04/2016 02:12 PM, Michael Paquier wrote:
One last thing that I think is missing in this patch is for users the
possibility to check via SQL if the SSL context is actually loaded or
no
Hi
On 12/02/2016 11:01 PM, Robert Haas wrote:
On Wed, Nov 30, 2016 at 8:45 PM, Ian Barwick
wrote:
Small doc patch to clarify how much of the query text is show in
pg_stat_statements
and a link to the relevant GUC.
This patch improves the pg_stat_activity documentation, not the
pg_stat_statem
On Sun, Dec 4, 2016 at 5:58 AM, Noah Misch wrote:
> On Wed, Nov 30, 2016 at 04:24:34PM +, Christian Ullrich wrote:
>> * From: Michael Paquier
>> > would be nice to mention in a code comment that this what Noah has
>> > mentioned upthread: if a CRT loads while pgwin32_putenv() is
>> > executing
On Mon, Dec 5, 2016 at 6:00 AM, Haribabu Kommi wrote:
>
>
> On Fri, Nov 4, 2016 at 8:20 PM, Amit Kapila wrote:
>>
>> On Thu, Nov 3, 2016 at 8:38 PM, Robert Haas wrote:
>> > On Tue, Nov 1, 2016 at 11:31 PM, Tomas Vondra
>> >> The difference is that both the fast-path locks and msgNumLock went
>>
On Tue, Nov 22, 2016 at 4:53 AM, Claudio Freire
wrote:
> On Mon, Nov 21, 2016 at 2:15 PM, Masahiko Sawada
> wrote:
> > On Fri, Nov 18, 2016 at 6:54 AM, Claudio Freire
> wrote:
> >> On Thu, Nov 17, 2016 at 6:34 PM, Robert Haas
> wrote:
> >>> On Thu, Nov 17, 2016 at 1:42 PM, Claudio Freire <
> k
On Wed, Nov 30, 2016 at 4:38 PM, Dilip Kumar wrote:
> On Fri, Nov 25, 2016 at 6:55 PM, Dilip Kumar
> wrote:
> > I have changed the design to directly make it based on DSA instead of
> using DHT.
> > In new version we no longer use DHT. Instead, of that I have made some
> > change in simplehash[1
On Tue, Nov 22, 2016 at 5:57 PM, Haribabu Kommi
wrote:
> Hi Vinayak,
>
> This is a gentle reminder.
>
> you assigned as reviewer to the current patch in the 11-2016 commitfest.
> If you have any more review comments / performance results regarding the
> approach of the patch, please share it. Oth
On Tue, Nov 15, 2016 at 1:17 PM, Noah Misch wrote:
> On Mon, Nov 14, 2016 at 10:21:53AM -0800, Peter Geoghegan wrote:
> > BTW, I recently noticed that the latest version of Valgrind, 3.12,
> > added this new feature:
> >
> > * Memcheck:
> >
> > - Added meta mempool support for describing a cust
On Fri, Dec 2, 2016 at 12:58 PM, Magnus Hagander
wrote:
>
>
As there was a feedback from others related to the patch and doesn't find
any
update from author.
Closed in 2016-11 commitfest with "returned with feedback" status.
Please feel free to update the status once you submit the updated patch
On Mon, Nov 7, 2016 at 2:26 AM, Artur Zakirov
wrote:
>
> Hm, truly. Fixed it.
>
> I've attached the fixed patch.
>
Moved to next CF with "needs review" status.
Regards,
Hari Babu
Fujitsu Australia
On Tue, Nov 22, 2016 at 10:51 PM, Haribabu Kommi
wrote:
> Hi Vitaly,
>
>
> This is a gentle reminder.
>
> you assigned as reviewer to the current patch in the 11-2016 commitfest.
> But you haven't shared your review yet on the new patch in this commitfest
> .
> Please share your review about the
On Mon, Dec 5, 2016 at 1:14 PM, Amit Kapila wrote:
> On Mon, Dec 5, 2016 at 6:00 AM, Haribabu Kommi
> wrote:
>
> No, that is not true. You have quoted the wrong message, that
> discussion was about WALWriteLock contention not about the patch being
> discussed in this thread. I have posted the
On Thu, Dec 1, 2016 at 10:35 PM, Thomas Munro wrote:
> On Sat, Nov 26, 2016 at 1:55 AM, Thomas Munro
> wrote:
> > Here's a new version to apply on top of dsa-v7.patch.
>
> Here's a version to go with dsa-v8.patch.
Moved to next CF with "needs review" status.
Regards,
Hari Babu
Fujitsu Austral
On Thu, Dec 1, 2016 at 11:17 AM, Andreas Karlsson wrote:
> On 12/01/2016 02:48 AM, Andres Freund wrote:
>>
>> It appears openssl has removed the public definition of EVP_CIPHER_CTX
>> leading to pgcrypto failing with:
That's not much surprising, most distributions are still on 1.0.2 as
1.1.0 has
On Mon, Dec 5, 2016 at 11:34 AM, Haribabu Kommi
wrote:
> As there was a feedback from others related to the patch and doesn't find
> any
> update from author.
>
> Closed in 2016-11 commitfest with "returned with feedback" status.
> Please feel free to update the status once you submit the updated
On Fri, Dec 2, 2016 at 8:54 PM, Robert Haas wrote:
> Couldn't this just be a variable in PQconnectPoll(), instead of adding
> a new structure member?
I have fixed same with a local variable in PQconnectPoll, Initally I
thought savedMessage should have same visiblitly as errorMessage so we can
res
On Thu, Nov 17, 2016 at 10:56 PM, Dmitry Dolgov <9erthali...@gmail.com>
wrote:
> > On 15 November 2016 at 15:03, Aleksander Alekseev <
> a.aleks...@postgrespro.ru> wrote:
> > Hello.
> >
> > I took a look on the latest -v4 patch. I would like to note that this
> > patch breaks a backward compatibil
On Fri, Dec 2, 2016 at 4:05 AM, Robert Haas wrote:
> On Tue, Sep 13, 2016 at 4:32 AM, Alexander Korotkov
> wrote:
> > On Fri, Apr 8, 2016 at 10:09 PM, Peter Geoghegan wrote:
> >> On Wed, Mar 30, 2016 at 8:02 AM, Alexander Korotkov
> >> wrote:
> >> > Hmm... I'm not completely agree with that. I
On Sat, Nov 26, 2016 at 10:35 PM, Amit Kapila
wrote:
> On Sat, Oct 22, 2016 at 9:07 AM, Amit Kapila
> wrote:
> > On Fri, Oct 21, 2016 at 10:55 PM, Robert Haas
> wrote:
>
> I have rebased the patch (parallel_index_scan_v2) based on latest
> commit e8ac886c (condition variables). I have removed
On Mon, Dec 5, 2016 at 7:44 AM, Peter Geoghegan wrote:
> On Sat, Dec 3, 2016 at 7:23 PM, Tomas Vondra
> wrote:
> > I do share your concerns about unpredictable behavior - that's
> > particularly worrying for pg_restore, which may be used for time-
> > sensitive use cases (DR, migrations between
On Tue, Nov 22, 2016 at 10:54 PM, Haribabu Kommi
wrote:
> Hi Vik and Vinayak,
>
> This is a gentle reminder.
>
> you both are assigned as reviewer's to the current patch in the 11-2016
> commitfest.
> But you haven't shared your review yet. Please share your review about
> the patch. This will he
On Tue, Nov 1, 2016 at 7:45 AM, Corey Huinker
wrote:
> Attached is a patch that implements copy_srf().
>
Moved to next CF with "needs review" status.
Regards,
Hari Babu
Fujitsu Australia
On Tue, Oct 25, 2016 at 8:44 PM, Peter Moser wrote:
>
> We decided to follow your recommendation and add the patch to the
> commitfest.
>
>
Path is not applying properly to HEAD.
Moved to next CF with "waiting on author" status.
Regards,
Hari Babu
Fujitsu Australia
On Sun, Dec 4, 2016 at 12:06 PM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> I massaged the temporary replication slot patch a bit. I changed the
> column name in pg_stat_replication_slots from "persistent" to
> "temporary" and flipped the logical sense, so that it is consistent
On Wed, Nov 30, 2016 at 9:06 AM, Peter Geoghegan wrote:
> On Wed, Nov 23, 2016 at 2:47 PM, Thomas Munro
> wrote:
> > Actually I meant that at T2 the btree is exactly same as it was at T1,
> > but the order of the values has changed according to the comparator
> > (for example, because a collatio
On Tue, Nov 22, 2016 at 10:48 PM, Haribabu Kommi
wrote:
> Hi,
>
> This is a gentle reminder.
>
> you assigned as reviewer to the current patch in the 11-2016 commitfest.
> But you haven't shared your review yet. Please share your review about
> the patch. This will help us in smoother operation
On Mon, Dec 5, 2016 at 9:50 AM, Andreas Karlsson wrote:
> On 12/04/2016 03:20 PM, Michael Paquier wrote:
>> On Sun, Dec 4, 2016 at 11:11 PM, Andreas Karlsson
>> wrote:
>>> On 12/04/2016 02:12 PM, Michael Paquier wrote:
>>> Does this have a precedent in the code?
>>
>>
>> data_checksums in guc.c i
On Sun, Dec 4, 2016 at 2:28 PM, Noah Misch wrote:
> Committed after re-filling paragraphs.
Thanks, I have updated the CF entry as well.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgs
On Mon, Oct 3, 2016 at 3:11 PM, Michael Paquier
wrote:
> On Tue, Jul 19, 2016 at 3:42 PM, Haribabu Kommi
> wrote:
> > The above changes are based on my understanding to the discussion
> occurred in
> > this mail. In case if I miss anything, please let me know, i will
> > correct the same.
>
> Th
On Wed, Nov 30, 2016 at 8:05 PM, Etsuro Fujita
wrote:
> On 2016/11/30 17:53, Amit Langote wrote:
>
>> On 2016/11/30 17:25, Etsuro Fujita wrote:
>>
>>> Done. I modified the patch so that any inval in pg_foreign_server also
>>> blows the whole plan cache.
>>>
>>
> I noticed the following addition:
On Thu, Dec 1, 2016 at 12:18 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
>
> >
> +
> +Datum pg_import_system_collations(PG_FUNCTION_ARGS);
> +
> +Datum
> +pg_import_system_collations(PG_FUNCTION_ARGS)
> +{
> >>>
> >>> Uh?
> >>
> >> Required to avoi
On Fri, Nov 11, 2016 at 5:38 PM, Masahiko Sawada
wrote:
>
> 2PC is a basic building block to support the atomic commit and there
> are some optimizations way in order to reduce disadvantage of 2PC. As
> you mentioned, it's hard to support a single model that would suit
> several type of FDWs. But
On Wed, Nov 23, 2016 at 10:02 AM, Jim Nasby
wrote:
> On 11/21/16 3:49 AM, Craig Ringer wrote:
>
>> After going through that experience, I now agree with Kevin: an
>>> > interface where a new SPI interface lets PLs push a named tuplestore
>>> > into the SPI connection to make it available to SQL s
On Sun, Nov 13, 2016 at 4:28 AM, Andres Freund wrote:
> Hi,
>
> On 2016-11-01 01:43:31 -0300, Alvaro Herrera wrote:
> > Alvaro Herrera wrote:
> > > I propose we introduce the concept of "indirect indexes".
> >
> > This is a WIP non-functional patch for indirect indexes. I've been
> > distracted
On Mon, Dec 5, 2016 at 11:04 AM, Haribabu Kommi
wrote:
>
>
> On Fri, Nov 11, 2016 at 5:38 PM, Masahiko Sawada
> wrote:
>>
>>
>> 2PC is a basic building block to support the atomic commit and there
>> are some optimizations way in order to reduce disadvantage of 2PC. As
>> you mentioned, it's hard
Hi All,
The commitfest status summary at the end of commitfest.
Needs review: 0
Waiting on author: 0
Ready for Commiter: 0
Commited: 41
Moved to next CF: 79
Rejected: 7
Returned with feedback: 20
TOTAL: 147
Overall progress of completion - 46% (doesn't include "moved to next CF")
Micheal, I n
On Mon, Dec 5, 2016 at 4:42 PM, Ashutosh Bapat <
ashutosh.ba...@enterprisedb.com> wrote:
> On Mon, Dec 5, 2016 at 11:04 AM, Haribabu Kommi
> wrote:
> >
> >
> > On Fri, Nov 11, 2016 at 5:38 PM, Masahiko Sawada
> > wrote:
> >>
> >>
> >> 2PC is a basic building block to support the atomic commit an
On Mon, Dec 5, 2016 at 2:50 PM, Haribabu Kommi wrote:
> Micheal, I need your help in closing the commitfest.
And done. Thanks for doing this work! I was ready to use my CF vacuum
cleaner as need be, but that does not seem to be needed.
> I closed the commitfest using the following assumptions.
Hello,
Sorry for my late response.
The attached patch reflects your comments.
> Here are few comments on latest patch:
>
>
> 1.
> make/make check is fine, however I am getting regression failure in
> postgres_fdw contrib module (attached regression.diff).
> Please investigate and fix.
>
It was
52 matches
Mail list logo