[HACKERS] Statement timeout

2016-05-28 Thread Tatsuo Ishii
When extended query protocol message is used, statement timeout is not checked until a sync message is received (more precisely, statement timeout timer is canceled while processing the sync message, and actual checking timeout is done in CHECK_FOR_INTERRUPTS). Example: parse(statement1) bind(stat

Re: [HACKERS] Does people favor to have matrix data type?

2016-05-28 Thread Kouhei Kaigai
> On 5/25/16 7:46 AM, Kouhei Kaigai wrote: > > My only concern is that domain type is not allowed to define type cast. > > If we could add type cast on domain, we can define type transformation from > > other array type to matrix. > > I've actually wished for that in the past, as well as casting t

Re: [HACKERS] Parallel pg_dump's error reporting doesn't work worth squat

2016-05-28 Thread Tom Lane
Amit Kapila writes: > On Sat, May 28, 2016 at 5:06 AM, Tom Lane wrote: >> It looks like the vacuumdb.c version of this code actually is tied >> into an interrupt handler, but whoever copied it for parallel.c just >> ripped out the CancelRequested checks, making the looping behavior >> pretty usel

Re: [HACKERS] Statement timeout

2016-05-28 Thread Tom Lane
Tatsuo Ishii writes: > When extended query protocol message is used, statement timeout is not > checked until a sync message is received (more precisely, statement > timeout timer is canceled while processing the sync message, and > actual checking timeout is done in CHECK_FOR_INTERRUPTS). Example

Re: [HACKERS] Does people favor to have matrix data type?

2016-05-28 Thread Joe Conway
On 05/28/2016 07:12 AM, Kouhei Kaigai wrote: > Sparse matrix! It is a disadvantaged area for the current array format. > > I have two ideas. HPC folks often split a large matrix into multiple > grid. A grid is typically up to 1024x1024 matrix, for example. > If a grid is consists of all zero eleme

[HACKERS] pgdump/parallel.c: "aborting" flag is dead code

2016-05-28 Thread Tom Lane
parallel.c has an "aborting" flag that's entirely useless, as it's set only during archive_close_connection(), and tested only in places that are not reached after that. I've confirmed this both by code reading and by testing. It appears from some of the comments that there was once an intent to

[HACKERS] Misdesigned command/status APIs for parallel dump/restore

2016-05-28 Thread Tom Lane
pg_dump's APIs for parallel dump/restore include an archive-format-specific MasterStartParallelItem function, which is evidently intended to allow format-specific data to be sent to the worker process during startup of a parallel sub-job. However, no such data can be sent in practice, because pars

Re: [HACKERS] Does people favor to have matrix data type?

2016-05-28 Thread Kouhei Kaigai
> -Original Message- > From: Joe Conway [mailto:m...@joeconway.com] > Sent: Sunday, May 29, 2016 1:40 AM > To: Kaigai Kouhei(海外 浩平); Jim Nasby; Ants Aasma; Simon Riggs > Cc: pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Does people favor to have matrix data type? > > On 05/28/2016

Re: [HACKERS] Statement timeout

2016-05-28 Thread Tatsuo Ishii
> Really? It should get reported at some execution of CHECK_FOR_INTERRUPTS > after we pass the 2-second mark in execute(portal1). If that's not what > you're observing, maybe you've found a code path that's missing some > CHECK_FOR_INTERRUPTS call(s). Oops. Previous example was not appropriate.

Re: [HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-28 Thread Noah Misch
On Thu, May 12, 2016 at 11:33:24AM -0400, Robert Haas wrote: > On Fri, May 6, 2016 at 7:58 PM, Peter Geoghegan wrote: > > I noticed that commit 30bb26b5 ("Allow usage of huge > > maintenance_work_mem for GIN build") made the following modification: > > > > --- a/src/include/access/gin_private.h >

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-28 Thread Noah Misch
On Thu, May 12, 2016 at 10:49:06AM -0400, Robert Haas wrote: > On Thu, May 12, 2016 at 8:39 AM, Ashutosh Sharma > wrote: > > Please find the test results for the following set of combinations taken at > > 128 client counts: > > > > 1) Unpatched master, default *_flush_after : TPS = 10925.882396

Re: [HACKERS] parallel.c is not marked as test covered

2016-05-28 Thread Noah Misch
On Sun, May 15, 2016 at 12:53:13PM +, Clément Prévost wrote: > On Mon, May 9, 2016 at 4:50 PM Andres Freund wrote: > > I think it's a good idea to run a force-parallel run on some buildfarm > > members. But I'm rather convinced that the core tests run by all animals > > need some minimal cover

Re: [HACKERS] Rename max_parallel_degree?

2016-05-28 Thread Noah Misch
On Fri, May 06, 2016 at 02:52:30PM -0400, Robert Haas wrote: > OK, my reading of this thread is that there is a consensus is to > redefine max_parallel_degree=1 as "no parallelism" and > max_parallel_degree>1 as "parallelism using a leader plus N-1 > workers", and along with that, to keep the names

[HACKERS] Re: pg9.6 segfault using simple query (related to use fk for join estimates)

2016-05-28 Thread Noah Misch
On Fri, May 06, 2016 at 03:06:01PM -0400, Robert Haas wrote: > On Thu, May 5, 2016 at 10:48 AM, David Rowley > wrote: > > On 5 May 2016 at 16:04, David Rowley wrote: > >> I've started making some improvements to this, but need to talk to > >> Tomas. It's currently in the middle of his night, but

Re: [HACKERS] Performance degradation in commit ac1d794

2016-05-28 Thread Noah Misch
On Fri, Dec 25, 2015 at 08:08:15PM +0300, Васильев Дмитрий wrote: > I suddenly found commit ac1d794 gives up to 3 times performance degradation. > > I tried to run pgbench -s 1000 -j 48 -c 48 -S -M prepared on 70 CPU-core > machine: > commit ac1d794 gives me 363,474 tps > and previous commit a05dc

Re: [HACKERS] Reviewing freeze map code

2016-05-28 Thread Noah Misch
On Fri, May 06, 2016 at 04:42:48PM -0400, Robert Haas wrote: > On Thu, May 5, 2016 at 2:20 PM, Andres Freund wrote: > > On 2016-05-02 14:48:18 -0700, Andres Freund wrote: > > + charnew_vmbuf[BLCKSZ]; > > + char *new_cur = new_vmbuf; > >