On 23/04/16 08:08, Christian Ullrich wrote:
* Christian Ullrich wrote:
* Andrew Dunstan wrote:
On 04/22/2016 02:46 AM, Michael Paquier wrote:
Progress report:
1. My VS 2015 installations (I now have several) all generate
solution file
with:
Microsoft Visual Studio Solution File, Forma
Hi.
A while ago I discussed some reliability issues when using cancellations (
http://www.postgresql.org/message-id/CADT4RqAk0E10=9ba8v+uu0dq9tr+pn8x+ptqbxfc1fbivh3...@mail.gmail.com).
Since we were discussing some protocol wire changes recently I'd like to
propose one to help with that.
The issu
Shay Rojansky writes:
> The issue I'd like to tackle is the fact that it's not possible to make
> sure a cancellation request affects a specific query.
Right ...
> A simple fix for this would be to have a sequence number returned in the
> BindComplete message.
First, that doesn't fix anything f
On 04/23/2016 11:25 PM, Andrew Dunstan wrote:
On 04/23/2016 06:33 PM, Tom Lane wrote:
I wrote:
Andrew Dunstan writes:
On 04/23/2016 05:30 PM, Christian Ullrich wrote:
In this case, I would prefer this:
#ifdef WIN32_ONLY_COMPILER
-typedef int pid_t;
+typedef intptr_t pid_t;
#endif
That'
On Sun, Apr 24, 2016 at 5:37 AM, Bruce Momjian wrote:
> On Fri, Apr 22, 2016 at 11:53:46AM -0400, Robert Haas wrote:
> > On Wed, Apr 20, 2016 at 1:32 PM, Magnus Hagander
> wrote:
> > > Note that we have not marked them as deprecated. We're just giving
> warnings
> > > that they will be deprecate
On Thu, Apr 21, 2016 at 7:20 PM, Robert Haas wrote:
> On Wed, Apr 20, 2016 at 2:04 PM, Magnus Hagander
> wrote:
> > So what more do we need to just get going with this? Given feature freeze
> > we're perhaps too late to actually build the parameter feature for
> initdb,
> > but we could still ch
* Magnus Hagander (mag...@hagander.net) wrote:
> On Sun, Apr 24, 2016 at 5:37 AM, Bruce Momjian wrote:
>
> > On Fri, Apr 22, 2016 at 11:53:46AM -0400, Robert Haas wrote:
> > > On Wed, Apr 20, 2016 at 1:32 PM, Magnus Hagander
> > wrote:
> > > > Note that we have not marked them as deprecated. We'
Magnus Hagander writes:
> On Thu, Apr 21, 2016 at 7:20 PM, Robert Haas wrote:
>> I think we are far too close to beta1 to begin bikeshedding this.
>> Changing the defaults is not going to be uncontroversial, and it's not
>> something I think we should rush into.
> I think that may be a case of t
Andrew Dunstan writes:
> OK, here's my final version of the patch, which I will apply in 24 hours
> or so unless there is an objection.
> +#pragma warning(push)
> +#pragma warning(disable : 4091)
> #include
> +#pragma warning(pop)
Hmm ... does this pragma work on *every* compiler we're going
Andrew Dunstan writes:
> OK, here's my final version of the patch, which I will apply in 24 hours
> or so unless there is an objection.
BTW, in view of 9f633b404, shouldn't there be a similar addition to
win32env.c in this patch?
regards, tom lane
--
Sent via pgsql-ha
On 04/24/2016 11:58 AM, Tom Lane wrote:
Andrew Dunstan writes:
OK, here's my final version of the patch, which I will apply in 24 hours
or so unless there is an objection.
+#pragma warning(push)
+#pragma warning(disable : 4091)
#include
+#pragma warning(pop)
Hmm ... does this pragma work
On Sun, Apr 24, 2016 at 5:50 PM, Tom Lane wrote:
> Magnus Hagander writes:
> > On Thu, Apr 21, 2016 at 7:20 PM, Robert Haas
> wrote:
> >> I think we are far too close to beta1 to begin bikeshedding this.
> >> Changing the defaults is not going to be uncontroversial, and it's not
> >> something
On 24 April 2016 at 13:04, Shay Rojansky wrote:
The issue I'd like to tackle is the fact that it's not possible to make
> sure a cancellation request affects a specific query. Since cancellations
> are totally asynchronous and occur on another socket, they affect whatever
> query is currently bei
Andrew Dunstan writes:
> On 04/24/2016 11:58 AM, Tom Lane wrote:
>> Hmm ... does this pragma work on *every* compiler we're going to use
>> on Windows?
> According to my research it works on all the MSVC versions we support. I
> didn't research the others (i.e. gcc), but we already use the pragm
On 04/24/2016 12:14 PM, Tom Lane wrote:
Andrew Dunstan writes:
OK, here's my final version of the patch, which I will apply in 24 hours
or so unless there is an objection.
BTW, in view of 9f633b404, shouldn't there be a similar addition to
win32env.c in this patch?
I definitely agree that simply tracking message sequence numbers on both
sides is better. It's also a powerful feature to be able to cancel all
messages "up to N" - I'm thinking of a scenario where, for example, many
simple queries are sent and the whole process needs to be cancelled.
Yes, this ha
On 04/23/2016 11:00 PM, Peter Geoghegan wrote:
On Sat, Apr 23, 2016 at 8:58 PM, Bruce Momjian wrote:
Why is the parallelism variable called "max_parallel_degree"? Is that a
descriptive name? What does "degree" mean? Why is it not called
"max_parallel_workers"?
I also think that "max_parall
Andrew Dunstan writes:
> On 04/24/2016 12:14 PM, Tom Lane wrote:
>> BTW, in view of 9f633b404, shouldn't there be a similar addition to
>> win32env.c in this patch?
> msvcr120.dll seems to be the highest numbered one on my system, and we
> already cover that. If you like we can add to the commen
On Sat, Apr 23, 2016 at 11:58 PM, Bruce Momjian wrote:
> Why is the parallelism variable called "max_parallel_degree"? Is that a
> descriptive name? What does "degree" mean? Why is it not called
> "max_parallel_workers"?
Because "degree of parallelism" is standard terminology, I guess.
Also,
Robert Haas writes:
> On Sat, Apr 23, 2016 at 11:58 PM, Bruce Momjian wrote:
>> Why is the parallelism variable called "max_parallel_degree"? Is that a
>> descriptive name? What does "degree" mean? Why is it not called
>> "max_parallel_workers"?
> Because "degree of parallelism" is standard t
On Sun, Apr 24, 2016 at 8:23 PM, Tom Lane wrote:
> Robert Haas writes:
> > On Sat, Apr 23, 2016 at 11:58 PM, Bruce Momjian
> wrote:
> >> Why is the parallelism variable called "max_parallel_degree"? Is that a
> >> descriptive name? What does "degree" mean? Why is it not called
> >> "max_para
Magnus Hagander writes:
> On Sun, Apr 24, 2016 at 8:23 PM, Tom Lane wrote:
>> FWIW, I agree with Bruce that using "degree" here is a poor choice.
>> It's an unnecessary dependence on technical terminology that many people
>> will not be familiar with.
> FWIW, SQL Server calls it "degree of paral
On 04/02/2016 01:20 PM, Tom Lane wrote:
Andrew Dunstan writes:
Looking at this briefly. It looks like the check should be called from
enum_in() and enum_recv(). What error should be raised if the enum row's
xmin isn't committed? ERRCODE_FEATURE_NOT_SUPPORTED? or maybe
ERRCODE_DATA_EXCEPTION?
Hi,
While working on
http://www.postgresql.org/message-id/cabuevezwma9y+bp4fi4fe4hmpfzmjozomulvtbhhpwtcujr...@mail.gmail.com
I once more taken aback by the total lack of consistency between the
three files in $subject. Some of the inconsistency of guc.c vs. the rest
comes from having separate list
* Andrew Dunstan wrote:
On 04/24/2016 12:14 PM, Tom Lane wrote:
Andrew Dunstan writes:
OK, here's my final version of the patch, which I will apply in 24 hours
or so unless there is an objection.
BTW, in view of 9f633b404, shouldn't there be a similar addition to
win32env.c in this patch
On 04/24/2016 03:16 PM, Christian Ullrich wrote:
* Andrew Dunstan wrote:
On 04/24/2016 12:14 PM, Tom Lane wrote:
Andrew Dunstan writes:
OK, here's my final version of the patch, which I will apply in 24
hours
or so unless there is an objection.
BTW, in view of 9f633b404, shouldn't th
* Andrew Dunstan wrote:
On 04/24/2016 03:16 PM, Christian Ullrich wrote:
* Andrew Dunstan wrote:
msvcr120.dll seems to be the highest numbered one on my system, and we
already cover that. If you like we can add to the comments in that file.
There won't be a higher one, with VS 2015, CRT
On 2016-04-21 11:20:38 -0700, Andres Freund wrote:
> On 2016-04-18 14:33:28 +0900, Fujii Masao wrote:
> > On Fri, Apr 15, 2016 at 6:56 PM, Magnus Hagander
> > wrote:
> > > The documentation says that the default value is 128Kb on Linux, but the
> > > code says it's 256Kb.
> > >
> > > Not sure whi
* Andrew Dunstan wrote:
OK, here's my final version of the patch, which I will apply in 24 hours
or so unless there is an objection.
+ Visual Studio 2008 and above. Compilation
+ is supported down to Windows XP and
+ Windows Server 2003 when building with
+ Visual Studio 2005 to
+ Visual
I wrote:
> However, it's still not entirely clear what is the root cause of the
> failure and whether a patch along the discussed lines would prevent its
> recurrence. Looking at TranslateSocketError, it seems we must be seeing
> an underlying error code of WSAEACCES. A little googling says that
* Magnus Hagander wrote:
Add putenv support for msvcrt from Visual Studio 2013
This was missed when VS 2013 support was added.
Michael Paquier
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab
Just noticed something. This
On 18 April 2016 at 13:15, Simon Riggs wrote:
> On 18 April 2016 at 12:43, Michael Paquier
> wrote:
>
>> On Sat, Apr 16, 2016 at 5:37 AM, Alvaro Herrera
>> wrote:
>> > Andres Freund wrote:
>> >> On 2016-04-15 15:26:17 -0400, Tom Lane wrote:
>> >> > I think the bottom line is that we misdesigned
On 24 April 2016 at 17:54, Shay Rojansky wrote:
> I definitely agree that simply tracking message sequence numbers on both
> sides is better. It's also a powerful feature to be able to cancel all
> messages "up to N" - I'm thinking of a scenario where, for example, many
> simple queries are sent
Simon Riggs writes:
> On 24 April 2016 at 17:54, Shay Rojansky wrote:
>> I definitely agree that simply tracking message sequence numbers on both
>> sides is better. It's also a powerful feature to be able to cancel all
>> messages "up to N" - I'm thinking of a scenario where, for example, many
>
Hi,
The default text representation of jsonb adds whitespace in between
key/value pairs (after the colon ":") and after successive properties
(after the comma ","):
postgres=# SELECT '{"b":2,"a":1}'::jsonb::text;
text
--
{"a": 1, "b": 2}
(1 row)
AFAIK, there's also no gua
On Sun, Apr 24, 2016 at 02:23:43PM -0400, Tom Lane wrote:
> Robert Haas writes:
> > Also, consider that we have the related but actually sorta different
> > GUC max_worker_processes. I think max_parallel_workers to control the
> > per-query behavior and max_worker_processes to control the global
On 04/24/2016 06:02 PM, Sehrope Sarkuni wrote:
AFAIK, there's also no guarantee on the specific order of the
resulting properties in the text representation either. I would
suppose it's fixed for a given jsonb value within a database major
version but across major versions it could change (
* Andrew Dunstan (and...@dunslane.net) wrote:
> On 04/24/2016 06:02 PM, Sehrope Sarkuni wrote:
> >AFAIK, there's also no guarantee on the specific order of the
> >resulting properties in the text representation either. I would
> >suppose it's fixed for a given jsonb value within a database major
>
On Sun, Apr 24, 2016 at 2:23 PM, Tom Lane wrote:
> FWIW, I agree with Bruce that using "degree" here is a poor choice.
> It's an unnecessary dependence on technical terminology that many people
> will not be familiar with.
And many others will. Some made-up term that is entirely
PostgreSQL-speci
Peter Eisentraut writes:
> On 04/21/2016 08:18 PM, Tom Lane wrote:
>> Could you send along the assembler code generated by the compiler (-S
>> output) for float.c? Maybe that would shed some light. Probably the
>> -O0 version would be easier to read.
> Attached is a smaller test program that pr
On Sun, Apr 24, 2016 at 2:42 PM, Tom Lane wrote:
> Magnus Hagander writes:
>> On Sun, Apr 24, 2016 at 8:23 PM, Tom Lane wrote:
>>> FWIW, I agree with Bruce that using "degree" here is a poor choice.
>>> It's an unnecessary dependence on technical terminology that many people
>>> will not be fami
On Mon, Apr 25, 2016 at 4:43 AM, Tom Lane wrote:
> I took a second look at the above-quoted Microsoft documentation, and
> noticed that it specifies that this error occurs when another application
> is *bound* to the target address. If by that they mean that the other
> app did a bind(), then ind
Michael Paquier writes:
> Not worse, and still not enough... bowerbird complained again:
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2016-04-25%2002%3A13%3A54
That's a different symptom that seems unrelated:
cannot remove directory for
C:\prog\bf\root\HEAD\pgsql.build\
Noah, all,
* Noah Misch (n...@leadboat.com) wrote:
> On Fri, Apr 22, 2016 at 12:31:41PM -0400, Stephen Frost wrote:
> > After looking through the code a bit, I realized that there are a lot of
> > object types which don't have ACLs at all but which exist in pg_catalog
> > and were being analyzed b
On Mon, Apr 25, 2016 at 4:27 AM, Andres Freund wrote:
> On 2016-04-21 11:20:38 -0700, Andres Freund wrote:
>> On 2016-04-18 14:33:28 +0900, Fujii Masao wrote:
>> > On Fri, Apr 15, 2016 at 6:56 PM, Magnus Hagander
>> > wrote:
>> > > The documentation says that the default value is 128Kb on Linux,
On Mon, Apr 25, 2016 at 3:58 AM, Andres Freund wrote:
> Hi,
>
> While working on
> http://www.postgresql.org/message-id/cabuevezwma9y+bp4fi4fe4hmpfzmjozomulvtbhhpwtcujr...@mail.gmail.com
> I once more taken aback by the total lack of consistency between the
> three files in $subject. Some of the i
On Fri, Apr 22, 2016 at 6:22 PM, Robert Haas wrote:
> On Fri, Apr 22, 2016 at 8:44 AM, Rajkumar Raghuwanshi
> wrote:
> > I observed below in postgres_fdw.
> >
> > Observation: Update a foreign table which is referring to a local table's
> > view (with use_remote_estimate = true) getting failed w
47 matches
Mail list logo
