[HACKERS] No AVworkers when PM_RECOVERY_CONSISTENT

2009-09-05 Thread Simon Riggs
When pmState == PM_RECOVERY_CONSISTENT we run SignalAutovacWorkers(SIGTERM); at normal shutdown This currently does nothing, but since there aren't ever going to be any AVworkers at this time we should be explicitly skipping this. That should avoid misunderstanding the code and avoid any future s

Re: [HACKERS] No AVworkers when PM_RECOVERY_CONSISTENT

2009-09-05 Thread Tom Lane
Simon Riggs writes: > When pmState == PM_RECOVERY_CONSISTENT we run > SignalAutovacWorkers(SIGTERM); > at normal shutdown > This currently does nothing, but since there aren't ever going to be any > AVworkers at this time we should be explicitly skipping this. That > should avoid misunderstanding

Re: [HACKERS] Non-Solaris dtrace support is disabled in 8.4!!!?

2009-09-05 Thread Peter Eisentraut
On fre, 2009-09-04 at 17:49 -0400, Tom Lane wrote: > I have just discovered that this commit > http://archives.postgresql.org/pgsql-committers/2008-03/msg00316.php > which was alleged to improve our dtrace support on non-Solaris operating > systems, actually disabled it completely: You might want

Re: [HACKERS] Non-Solaris dtrace support is disabled in 8.4!!!?

2009-09-05 Thread Tom Lane
Peter Eisentraut writes: > On fre, 2009-09-04 at 17:49 -0400, Tom Lane wrote: >> I have just discovered that this commit >> http://archives.postgresql.org/pgsql-committers/2008-03/msg00316.php >> which was alleged to improve our dtrace support on non-Solaris operating >> systems, actually disabled

Re: [HACKERS] Tightening binary receive functions

2009-09-05 Thread Tom Lane
Heikki Linnakangas writes: > Greg Stark wrote: >> Just make the textual representation of "char" be \xxx (or perhaps we >> could switch to \xHH now) if the value isn't a printable ascii >> character. As long as "char" reads that in properly it doesn't matter >> if it's not a reasonable multibyte c

Re: [HACKERS] match_unsorted_outer() vs. cost_nestloop()

2009-09-05 Thread Tom Lane
Robert Haas writes: > I guess my point is that for node types that dump their output into a > tuplestore anyway, it doesn't seem like cost_nestloop() should charge > n * the startup cost. I believe that at least function, CTE, and > worktable scans fall into this category. No? Yeah, probably.

Re: [HACKERS] match_unsorted_outer() vs. cost_nestloop()

2009-09-05 Thread Tom Lane
I wrote: > It might be sufficient to have cost_nestloop just hardwire the knowledge > that certain inner path types have a different behavior here --- that > is, for a rescan there is zero start cost and some very low per-tuple > cost, independent of the path's nominal cost values (which would now

Re: [HACKERS] match_unsorted_outer() vs. cost_nestloop()

2009-09-05 Thread Robert Haas
On Sat, Sep 5, 2009 at 8:39 PM, Tom Lane wrote: > I wrote: >> It might be sufficient to have cost_nestloop just hardwire the knowledge >> that certain inner path types have a different behavior here --- that >> is, for a rescan there is zero start cost and some very low per-tuple >> cost, independe

[HACKERS] updated join removal patch

2009-09-05 Thread Robert Haas
Here we go again. Following Tom's advice to not insert crocks in add_path(), I've instead introduced a noopjoin path type which ignores its inner side. This could possibly be simplified to just a "noop" path that doesn't even include an outer side, but the way I've done it here doesn't really cos