Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Alvaro Herrera <[EMAIL PROTECTED]> writes: >> Hmm. Well, it showed the multiple incorrect uses of 0 as NULL in >> dllist.c and other places, > Incidentally, while it may not be conformant to your style guidelines, use of > the constant 0 compared to or as

Re: [HACKERS] [PORTS] 8.0.0rc4 / OpenBSD 3.6 / amd64 success

2005-01-15 Thread Peter Eisentraut
Andy Warner wrote: > I'm not sure what form success reports are supposed to take. > I glanced at the website and didn't see anything obvious, but > I didn't dig too hard. See http://archives.postgresql.org/pgsql-hackers/2004-12/msg00314.php for the information we would like to see. Also, cross-p

Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Andrew Dunstan
Tom Lane wrote: Greg Stark <[EMAIL PROTECTED]> writes: Alvaro Herrera <[EMAIL PROTECTED]> writes: Hmm. Well, it showed the multiple incorrect uses of 0 as NULL in dllist.c and other places, Incidentally, while it may not be conformant to your style guidelines, use of the consta

Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Alvaro Herrera
On Sat, Jan 15, 2005 at 08:31:42AM -0500, Andrew Dunstan wrote: > Tom Lane wrote: > >Something that I don't have a real strong feeling about is > > if (ptr != NULL) > >versus > > if (ptr) > >I've been known to write both. Can anyone mount a good readability > >argument for one over the o

Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > if (ptr) > > Can anyone mount a good readability argument for one over the other? My argument in favour of "if (ptr)" as well as "if (integer)" and "if (!ptr)" is simply that all else being equal the shorter expression is clearer. Forcing the reader t

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
On Fri, 14 Jan 2005, Tom Lane wrote: "Marc G. Fournier" <[EMAIL PROTECTED]> writes: 'k, this is looking promising ... but I'm a bit confused on the TOAST tables ... I can't match on 'relname', since they aren't the same ... the old has, for instance: pg_toast_5773565 while the new has: pg_toast_

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid 16396

2005-01-15 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > Is there something in the 'table file' itself that is holding that relid? Oh, drat, you're right --- TOAST pointer datums contain the OID of the toast file they are pointing to. So any value wide enough to be pushed out-of-line is going to have a

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
On Sat, 15 Jan 2005, Tom Lane wrote: "Marc G. Fournier" <[EMAIL PROTECTED]> writes: Is there something in the 'table file' itself that is holding that relid? Oh, drat, you're right --- TOAST pointer datums contain the OID of the toast file they are pointing to. So any value wide enough to be pushe

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid 16396

2005-01-15 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > can I force the reuse of an OID? for instance, if I were to get the > map'ngs for those toast files, and then 'drop' the old database (I've got > several backups of it already), can I insert those records into pg_class, > with the proper OID? I

Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Bruno Wolff III
On Sat, Jan 15, 2005 at 10:44:48 -0500, Greg Stark <[EMAIL PROTECTED]> wrote: > > > What I miss most in both C and Java is the lispish ability to write > expressions like: > > foo = bar() || baz() || qux(); Are you sure that C doesn't guarenty short circuit evaluation? I don't have my C refe

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
On Sat, 15 Jan 2005, Tom Lane wrote: "Marc G. Fournier" <[EMAIL PROTECTED]> writes: can I force the reuse of an OID? for instance, if I were to get the map'ngs for those toast files, and then 'drop' the old database (I've got several backups of it already), can I insert those records into pg_class

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid 16396

2005-01-15 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > Hrmmm ... how about if I pg_dump --oids pg_class, make the modes and then > reload it as opg_class, shut down the database server and move opg_class > over pg_class, after making the required modifications to opg_class? Good idea. Give it a shot.

Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Tom Lane
Bruno Wolff III <[EMAIL PROTECTED]> writes: > Greg Stark <[EMAIL PROTECTED]> wrote: >> What I miss most in both C and Java is the lispish ability to write >> expressions like: >> >> foo = bar() || baz() || qux(); > Are you sure that C doesn't guarenty short circuit evaluation? > I don't have my

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid 16396

2005-01-15 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > backend> reindex pg_class; > ERROR: syntax error at or near "pg_class" at character 9 "reindex table pg_class", I think. And you'll probably need to be doing this in a backend started with -P command line option. regards,

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
On Sat, 15 Jan 2005, Tom Lane wrote: "Marc G. Fournier" <[EMAIL PROTECTED]> writes: Hrmmm ... how about if I pg_dump --oids pg_class, make the modes and then reload it as opg_class, shut down the database server and move opg_class over pg_class, after making the required modifications to opg_class?

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid 16396

2005-01-15 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > belay that one ... my error, wasn't doin ghte reindex right ... fixed the > pg_class issue, but still have one with the email table itself in > multi-user: > restore=# select * from email; > ERROR: catalog is missing 3 attribute(s) for relid 5773

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
belay that one ... my error, wasn't doin ghte reindex right ... fixed the pg_class issue, but still have one with the email table itself in multi-user: restore=# select * from email; ERROR: catalog is missing 3 attribute(s) for relid 5773277 but, have an idea I'm going to try one that one ... O

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
nope ... still get it ... I can do a 'select' from the -O -P backend (what I refer to as single user mode), but not from a normal start up (ie. not pg_dumpable) ... # select * from email; ERROR: catalog is missing 3 attribute(s) for relid 5773277 'k, in pg_attribute, I find the following for t

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
On Sat, 15 Jan 2005, Tom Lane wrote: "Marc G. Fournier" <[EMAIL PROTECTED]> writes: belay that one ... my error, wasn't doin ghte reindex right ... fixed the pg_class issue, but still have one with the email table itself in multi-user: restore=# select * from email; ERROR: catalog is missing 3 at

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid 16396

2005-01-15 Thread Tom Lane
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > which there are more then 3 attributes ... but, of course, there is > nothing for the one I just manually added to pg_class ... should this just > be duplicated for 5773277? No, just do update pg_attribute set attrelid = 5773277 where attr

[HACKERS] WAL logging of heap_mark4update

2005-01-15 Thread Alvaro Herrera
Hackers, In access/heap/heapam.c, in heap_mark4update(), there's a comment that states /* * XLOG stuff: no logging is required as long as we have no * savepoints. For savepoints private log could be used... */ Is this still true in light of 8.0's savepoints? I

Re: [HACKERS] FATAL: catalog is missing 1 attribute(s) for relid

2005-01-15 Thread Marc G. Fournier
On Sat, 15 Jan 2005, Tom Lane wrote: "Marc G. Fournier" <[EMAIL PROTECTED]> writes: which there are more then 3 attributes ... but, of course, there is nothing for the one I just manually added to pg_class ... should this just be duplicated for 5773277? No, just do update pg_attribute set a

Re: [HACKERS] WAL logging of heap_mark4update

2005-01-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Hackers, > In access/heap/heapam.c, in heap_mark4update(), there's a comment that > states > /* >* XLOG stuff: no logging is required as long as we have no >* savepoints. For savepoints private log could be used... >*/ > I

[HACKERS] Encodings and docs

2005-01-15 Thread Bruce Momjian
Is this open item complete? * synchonize supported encodings and docs -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.

Re: [HACKERS] sparse (static analyzer) report

2005-01-15 Thread Tommi Mäkitalo
Am Samstag, 15. Januar 2005 21:38 schrieb Bruno Wolff III: > On Sat, Jan 15, 2005 at 10:44:48 -0500, > > Greg Stark <[EMAIL PROTECTED]> wrote: > > What I miss most in both C and Java is the lispish ability to write > > expressions like: > > > > foo = bar() || baz() || qux(); > > Are you sure tha

Re: [HACKERS] Encodings and docs

2005-01-15 Thread Tom Lane
Bruce Momjian writes: > Is this open item complete? > * synchonize supported encodings and docs Seems to be. As far as I can tell from looking in the archives, the question came up when we added WIN1250 to the set of allowed server encodings. But it is now shown in both tables in section