Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows in 8.1

2005-12-06 Thread Nicolai Tufar
2005/12/6, Nicolai Tufar <[EMAIL PROTECTED]>: > > > > IIRC last time I tried this it didn't work too well ;-( I will have > > another go. I think it's the best way to go. > > Very well, I will try to put up a patch to implement it in a couple of days. Oh boy, it is already fixed. Sorry folks, my e

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows in 8.1

2005-12-06 Thread Nicolai Tufar
2005/12/4, Andrew Dunstan <[EMAIL PROTECTED]>: > Tom said: > > >Would it work to modify c.h so that it #include's libintl.h, then #undefs > >these macros, then #includes port.h to define 'em the way we want? > >Some or all of this might need to be #ifdef WIN32, but that seems like > >a reasonably n

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under

2005-12-03 Thread Tom Lane
Bruce Momjian writes: > (See the quoted text under the posted text as well.) Basically, > libintl.h on Win32 replaces *printf calls with its own versions, and > does it using macros, _just_ like we do. This of course causes > conflicts and the system fails to compile. The _fix_ was to disable >

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under

2005-12-03 Thread Bruce Momjian
Nicolai Tufar wrote: > Greetings, > > I thought it will be as simple as changing Makefile, the issue seem to be > much more complicated. Unfortunately I have no PostgreSQL building > environment handy and will not be able to look at it until the end of next > week because I am moving my house :( B