Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I modified pg_regress.c to use just the return code to determine if the > diff worked, but I added in a WIN32-specific test for the file size. I > think that is the cleanest solution. Attached. It really needs a comment, along the lines of /*

Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-28 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> The cases that I think we most need to defend against are >>> (A) diff program not found > In summary, on MinGW, files differ or 'diff' not found, returns 1. If > one of the files to be compared does not exist, it returns 2. And of

Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-28 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > I checked on MinGW and system() just returns the value returned by the > > > application. There isn't any special two-values-in-one layering like is > > > done on Unix for wait() and the return value from sy

Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-28 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I checked on MinGW and system() just returns the value returned by the > > application. There isn't any special two-values-in-one layering like is > > done on Unix for wait() and the return value from system(). It seems if > > the ch

Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-28 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I checked on MinGW and system() just returns the value returned by the > application. There isn't any special two-values-in-one layering like is > done on Unix for wait() and the return value from system(). It seems if > the child dies from a signal, th