Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-20 Thread Bruce Momjian
Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > Tom Lane writes: > >> Hmm. Looks like we need a wholesale revision of command tags, indeed. > > > We would need to do: > > > ALTER -> ALTER > > DROP -> DROP > > CREATE -> CREATE > > Those look reasonable, and we already do

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-20 Thread Tom Lane
Fernando Nasser <[EMAIL PROTECTED]> writes: > Yes, I am supposed to see if I can fix this and get rid of the "into" > field in SelectStmt at the same time. Right Tom? Yeah, we had talked about that ... but I'm not sure it's worth the trouble. I don't see any clean way for the SELECT grammar rul

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-20 Thread Fernando Nasser
Tom Lane wrote: > > > It also seems to me that CREATE TABLE AS should not print "SELECT". I > > thought Fernando Nasser had fixed that. > > No, I think it's still on his to-do list (we didn't like his first > proposed patch for it). > Yes, I am supposed to see if I can fix this and get rid of

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-20 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Tom Lane writes: >> Hmm. Looks like we need a wholesale revision of command tags, indeed. > We would need to do: > ALTER -> ALTER > DROP -> DROP > CREATE -> CREATE > Those look reasonable, and we already do that in some cases. These seem oka

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-20 Thread Peter Eisentraut
Tom Lane writes: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > >> What's standard about it? > > > ISO/IEC 9075-2:1999 clause 19.1 general rule 1 c) to be exact. ;-) > > Hmm. Looks like we need a wholesale revision of command tags, indeed. > At least if we want to consider command tags to be t

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: >> What's standard about it? > ISO/IEC 9075-2:1999 clause 19.1 general rule 1 c) to be exact. ;-) Hmm. Looks like we need a wholesale revision of command tags, indeed. At least if we want to consider command tags to be the data that satisfies this sp

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Peter Eisentraut
Tom Lane writes: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Peter Eisentraut wrote: > >> There is a standard for this. CREATE DOMAIN shows CREATE DOMAIN. > > > OK, CVS changed to emit CREATE DOMAIN. > > What's standard about it? ISO/IEC 9075-2:1999 clause 19.1 general rule 1 c) to be exact

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Peter Eisentraut wrote: > >> There is a standard for this. CREATE DOMAIN shows CREATE DOMAIN. > > > OK, CVS changed to emit CREATE DOMAIN. > > What's standard about it? I count 9 existing statements that use > "CREATE", vs 4 that

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> There is a standard for this. CREATE DOMAIN shows CREATE DOMAIN. > OK, CVS changed to emit CREATE DOMAIN. What's standard about it? I count 9 existing statements that use "CREATE", vs 4 that use "CREATE xxx". (And of those

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Bruce Momjian
Thomas Lockhart wrote: > ... > > I have applied the following new patch. It moves DROP DATABASE as you > > suggested, and fixes the CREATE TABLE tag to show just CREATE and not > > CREATE DOMAIN. Actually, CREATE DOMAIN should output just DOMAIN too,

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > I have applied the following new patch. It moves DROP DATABASE as you > > suggested, and fixes the CREATE TABLE tag to show just CREATE and not > > CREATE DOMAIN. Actually, CREATE DOMAIN should output just DOMAIN too, > > unless someone can

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Peter Eisentraut
Bruce Momjian writes: > I have applied the following new patch. It moves DROP DATABASE as you > suggested, and fixes the CREATE TABLE tag to show just CREATE and not > CREATE DOMAIN. Actually, CREATE DOMAIN should output just DOMAIN too, > unless someone can tell my why that is not consistent.

Re: [PATCHES] [HACKERS] Fixes gram.y

2002-03-19 Thread Thomas Lockhart
... > I have applied the following new patch. It moves DROP DATABASE as you > suggested, and fixes the CREATE TABLE tag to show just CREATE and not > CREATE DOMAIN. Actually, CREATE DOMAIN should output just DOMAIN too, > unless someone can tell my why that is not consistent. Consistant or not