Re: [REVIEW] (was Re: [HACKERS] usermap regexp support)

2008-11-28 Thread Magnus Hagander
Gianni Ciolli wrote: > On Tue, Nov 11, 2008 at 02:59:01PM +0100, Magnus Hagander wrote: >> Gianni Ciolli wrote: >>> WARNING: detected write past chunk end in Postmaster 0x9b13650 >> Yes, that's a stupid bug: > (...) >> Attached is an updated version of the patch that fixes this. > > Hi Magn

[REVIEW] (was Re: [HACKERS] usermap regexp support)

2008-11-25 Thread Gianni Ciolli
On Tue, Nov 11, 2008 at 02:59:01PM +0100, Magnus Hagander wrote: > Gianni Ciolli wrote: > > WARNING: detected write past chunk end in Postmaster 0x9b13650 > > Yes, that's a stupid bug: (...) > Attached is an updated version of the patch that fixes this. Hi Magnus, please find below the re

Re: [HACKERS] usermap regexp support

2008-11-11 Thread Magnus Hagander
Gianni Ciolli wrote: > On Tue, Oct 28, 2008 at 08:59:53PM +0100, Magnus Hagander wrote: >> The attached patch tries to implement regexp support in the usermaps >> (pg_ident.conf). > > Hi Magnus, > > I am currently reviewing your patch. Hi! Thanks for the review! > I found out that the executi

Re: [HACKERS] usermap regexp support

2008-11-05 Thread Gianni Ciolli
On Tue, Oct 28, 2008 at 08:59:53PM +0100, Magnus Hagander wrote: > The attached patch tries to implement regexp support in the usermaps > (pg_ident.conf). Hi Magnus, I am currently reviewing your patch. I found out that the execution of pfree(regexp_pgrole); (there's only one such line i