Re: [HACKERS] smgrsettransient mechanism is full of bugs

2012-10-16 Thread Alvaro Herrera
Tom Lane wrote: > After further review, I have become convinced that in fact it's > completely broken and needs to be redone from scratch. The temp-file > marking at the fd.c level can easily get out of sync with the marking > at the smgr level, and that marking isn't too consistent with reality

Re: [HACKERS] smgrsettransient mechanism is full of bugs

2012-10-15 Thread Tom Lane
I wrote: > I got a bit suspicious of the transient-file mechanism introduced in > commit fba105b1099f4f5fa7283bb17cba6fed2baa8d0c after noticing that > ... > I believe that we probably ought to revert this mechanism entirely, and > build a new implementation based on these concepts: > * An SMgrRela