Re: [HACKERS] rfc: add pg_dump options to dump output

2008-07-15 Thread Bruce Momjian
Is this a TODO item? --- Greg Smith wrote: > On Tue, 3 Jun 2008, Tom Lane wrote: > > > Well, the stuff included into the dump by pg_dump -v is informative, > > too. But we stopped doing that by default because of complaint

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-04 Thread Euler Taveira de Oliveira
Robert Treat wrote: If you are calling pg_dump with different flags, it seems likely your breaking diff equality anyway so I'm not sure how valid that is. What about different users? Different connection options will result in the same file but it breaks diff-dump tools. I don't see the point o

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-04 Thread Greg Smith
On Tue, 3 Jun 2008, Tom Lane wrote: Well, the stuff included into the dump by pg_dump -v is informative, too. But we stopped doing that by default because of complaints. I remain unconvinced that this proposal won't suffer the same fate. I think it would be reasonable to only include the list

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-04 Thread Decibel!
On Mon, Jun 02, 2008 at 02:06:57PM -0700, Josh Berkus wrote: > Robert, > > > Anyone see any issues with this? Should there be other information taken > > into account? Does this need to be an option itself, or can we just do > > it in all cases? > > +1 to do it in all cases. +1. I've definitely

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-03 Thread Tom Lane
James William Pye <[EMAIL PROTECTED]> writes: > On Tue, Jun 03, 2008 at 01:17:43AM -0400, Tom Lane wrote: >> but mainly I don't see the point. > It's informative, no? Well, the stuff included into the dump by pg_dump -v is informative, too. But we stopped doing that by default because of complai

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-03 Thread Robert Treat
On Tuesday 03 June 2008 01:17:43 Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > Anyone see any issues with this? > I'm a bit worried about breaking diff-equality of matching dumps, If you are calling pg_dump with different flags, it seems likely your breaking diff equality anyway

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-03 Thread James William Pye
On Tue, Jun 03, 2008 at 01:17:43AM -0400, Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > I would like to add the flags given to pg_dump into the output of the > > pg_dump > > file. +1, FWIW > > Anyone see any issues with this? > > I'm a bit worried about breaking diff-equality o

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-02 Thread Tom Lane
Robert Treat <[EMAIL PROTECTED]> writes: > I would like to add the flags given to pg_dump into the output of the pg_dump > file. Why? What is the value of this added complication? > Anyone see any issues with this? I'm a bit worried about breaking diff-equality of matching dumps, but mainly I d

Re: [HACKERS] rfc: add pg_dump options to dump output

2008-06-02 Thread Josh Berkus
Robert, > Anyone see any issues with this? Should there be other information taken > into account? Does this need to be an option itself, or can we just do > it in all cases? +1 to do it in all cases. -- --Josh Josh Berkus PostgreSQL @ Sun San Francisco -- Sent via pgsql-hackers mailing list