Re: [HACKERS] reviewers needed!

2011-01-16 Thread Robert Haas
On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson wrote: > I reviewed a couple patched, and I added my review to the commitfest page. > > If I find a problem, its obvious I should mark the patch as "returned with > feedback". Only if it's got sufficiently serious flaws that getting it committed during

Re: [HACKERS] reviewers needed!

2011-01-16 Thread Euler Taveira de Oliveira
Em 16-01-2011 16:30, Andy Colson escreveu: I reviewed a couple patched, and I added my review to the commitfest page. If I find a problem, its obvious I should mark the patch as "returned with feedback". But what if I'm happy with it? I'm not a hacker so cannot do C code review, should I leave

Re: [HACKERS] reviewers needed!

2011-01-16 Thread Andy Colson
I reviewed a couple patched, and I added my review to the commitfest page. If I find a problem, its obvious I should mark the patch as "returned with feedback". But what if I'm happy with it? I'm not a hacker so cannot do C code review, should I leave it alone? Mark it as "ready for committ

Re: [HACKERS] reviewers needed!

2011-01-14 Thread Robert Haas
On Thu, Jan 13, 2011 at 4:54 PM, Robert Haas wrote: > On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas wrote: >> [ abject plea for reviewers ] > > [ second abject please for reviewers ] OK, I believe I've sent an off-list email to everyone who volunteered to review and asked me to assign them a patc

Re: [HACKERS] reviewers needed!

2011-01-13 Thread Josh Berkus
> So far I have 6 people who have volunteered to be round-robin > reviewers, and 7 people who are listed as reviewers on the CF site > already. That leaves 45 patches without a reviewer, plus whatever > comes in in the next day or so. This is not going to work unless a > lot more people pitch in

Re: [HACKERS] reviewers needed!

2011-01-13 Thread Robert Haas
On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas wrote: > [ abject plea for reviewers ] So far I have 6 people who have volunteered to be round-robin reviewers, and 7 people who are listed as reviewers on the CF site already. That leaves 45 patches without a reviewer, plus whatever comes in in the n