Re: [HACKERS] relative_path() seems overly complicated and buggy

2004-11-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Bruce Momjian wrote: >> Tom Lane wrote: >>> What I'd like to do is simplify it to just check for exact equality >>> up through the last directory separator in bin_path. Any objections? >> >> If you can simplify it, feel free. I found that code much mo

Re: [HACKERS] relative_path() seems overly complicated and buggy

2004-11-06 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > There's at least one bug in path.c's relative_path(): it will think > > "/foo/a/b" is equal to "/foo/ab" because it skips directory separators > > independently in the two strings. The code is sufficiently complex that > > I have little faith in it not ha

Re: [HACKERS] relative_path() seems overly complicated and buggy

2004-11-06 Thread Bruce Momjian
Tom Lane wrote: > There's at least one bug in path.c's relative_path(): it will think > "/foo/a/b" is equal to "/foo/ab" because it skips directory separators > independently in the two strings. The code is sufficiently complex that > I have little faith in it not having any other bugs, either. >