Re: [HACKERS] psql completion for ids in multibyte string

2016-03-10 Thread Kyotaro HORIGUCHI
Hello, At Mon, 7 Mar 2016 12:34:15 -0500, Robert Haas wrote in > >> Fix pushed. > > > > Thank you for committing this. I can see only one commit for this > > in the repository but I believe it is the fixed one. > > It was OK in master, but the back-branches had problems. See > 369c0b090808129

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-07 Thread Robert Haas
On Sun, Mar 6, 2016 at 11:24 PM, Kyotaro HORIGUCHI wrote: > At Fri, 4 Mar 2016 12:30:17 -0500, Robert Haas wrote > in >> >>> I committed this and back-patched this but (1) I avoided changing the >> >>> other functions for now and (2) I gave both the byte length and the >> >>> character length n

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-06 Thread Kyotaro HORIGUCHI
At Fri, 4 Mar 2016 12:30:17 -0500, Robert Haas wrote in > >>> I committed this and back-patched this but (1) I avoided changing the > >>> other functions for now and (2) I gave both the byte length and the > >>> character length new names to avoid confusion. > >> > >> These tweaks appear to have

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-04 Thread Robert Haas
On Fri, Mar 4, 2016 at 12:08 PM, Robert Haas wrote: > On Fri, Mar 4, 2016 at 12:02 PM, Alvaro Herrera > wrote: >> Robert Haas wrote: >>> On Wed, Mar 2, 2016 at 8:07 PM, Kyotaro HORIGUCHI >>> wrote: >>> > Hello, thank you for the comments. >>> >> I think we should leave string_length as it is and

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-04 Thread Alvaro Herrera
Robert Haas wrote: > On Wed, Mar 2, 2016 at 8:07 PM, Kyotaro HORIGUCHI > wrote: > > Hello, thank you for the comments. > >> I think we should leave string_length as it is and use a new variable > >> for character-based length, as in the attached. > > > > Basically agreed but I like byte_length for

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-04 Thread Robert Haas
On Fri, Mar 4, 2016 at 12:02 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> On Wed, Mar 2, 2016 at 8:07 PM, Kyotaro HORIGUCHI >> wrote: >> > Hello, thank you for the comments. >> >> I think we should leave string_length as it is and use a new variable >> >> for character-based length, as in th

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-04 Thread Robert Haas
On Wed, Mar 2, 2016 at 8:07 PM, Kyotaro HORIGUCHI wrote: > Hello, thank you for the comments. >> I think we should leave string_length as it is and use a new variable >> for character-based length, as in the attached. > > Basically agreed but I like byte_length for the previous > string_length and

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-02 Thread Thomas Munro
On Thu, Mar 3, 2016 at 2:07 PM, Kyotaro HORIGUCHI wrote: > Hello, thank you for the comments. > > At Wed, 2 Mar 2016 10:10:55 +1300, Thomas Munro > wrote in > >> On Wed, Mar 2, 2016 at 7:54 AM, Robert Haas wrote: >> > On Mon, Feb 29, 2016 at 6:32 PM, Thomas Munro >> > wrote: >> >> On Fri, Fe

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-02 Thread Kyotaro HORIGUCHI
Hello, thank you for the comments. At Wed, 2 Mar 2016 10:10:55 +1300, Thomas Munro wrote in > On Wed, Mar 2, 2016 at 7:54 AM, Robert Haas wrote: > > On Mon, Feb 29, 2016 at 6:32 PM, Thomas Munro > > wrote: > >> On Fri, Feb 26, 2016 at 6:34 PM, Kyotaro HORIGUCHI > >> wrote: > >>> Hello, this

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-01 Thread Thomas Munro
On Wed, Mar 2, 2016 at 7:54 AM, Robert Haas wrote: > On Mon, Feb 29, 2016 at 6:32 PM, Thomas Munro > wrote: >> On Fri, Feb 26, 2016 at 6:34 PM, Kyotaro HORIGUCHI >> wrote: >>> Hello, this is the second patch plitted out. This allows >>> multibyte names to be completed in psql. >>> >>> At Fri, 06

Re: [HACKERS] psql completion for ids in multibyte string

2016-03-01 Thread Robert Haas
On Mon, Feb 29, 2016 at 6:32 PM, Thomas Munro wrote: > On Fri, Feb 26, 2016 at 6:34 PM, Kyotaro HORIGUCHI > wrote: >> Hello, this is the second patch plitted out. This allows >> multibyte names to be completed in psql. >> >> At Fri, 06 Nov 2015 11:47:17 +0900 (Tokyo Standard Time), Kyotaro HORIGU

Re: [HACKERS] psql completion for ids in multibyte string

2016-02-29 Thread Thomas Munro
On Fri, Feb 26, 2016 at 6:34 PM, Kyotaro HORIGUCHI wrote: > Hello, this is the second patch plitted out. This allows > multibyte names to be completed in psql. > > At Fri, 06 Nov 2015 11:47:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > wrote in > <20151106.114717.170526268.horiguchi.kyot.

Re: [HACKERS] psql completion for ids in multibyte string

2016-02-25 Thread Kyotaro HORIGUCHI
Hello, this is the second patch plitted out. This allows multibyte names to be completed in psql. At Fri, 06 Nov 2015 11:47:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20151106.114717.170526268.horiguchi.kyot...@lab.ntt.co.jp> > At Thu, 5 Nov 2015 18:32:59 +0900, Amit Langote >

Re: [HACKERS] psql completion for ids in multibyte string

2015-11-05 Thread Kyotaro HORIGUCHI
Hi. Thank you for the comments. The revised version is attaced. - A typo is fixed in the comment for PQmblen(). - Do the same fix to PQdsplen(). At Thu, 5 Nov 2015 18:32:59 +0900, Amit Langote wrote in <563b224b.3020...@lab.ntt.co.jp> > On 2015/11/05 18:10, Kyotaro HORIGUCHI wrote: > > Hel

Re: [HACKERS] psql completion for ids in multibyte string

2015-11-05 Thread Amit Langote
Horiguchi-san, On 2015/11/05 18:10, Kyotaro HORIGUCHI wrote: > Hello. I don't know whether this is a bug fix or improvement, Would it be 50-50? :-) ... > > During the investigation into this issue, I found a mistake in > the comment for PQmblen. It give the byte length of the character > at t