Re: [HACKERS] pltcl: sentence improvement

2015-09-16 Thread Tom Lane
Alvaro Herrera writes: > I agree a full rewrite is sensible, but that particular wording looks > slightly odd to me. I would either have added an "an", or pluralized > the subject, so either > "trigger's return list must have an even number of elements" > or > "trigger's return lists must have

Re: [HACKERS] pltcl: sentence improvement

2015-09-16 Thread Alvaro Herrera
Tom Lane wrote: > Also, if we're going to change this message at all, I'm inclined to > rewrite it completely, because it doesn't really follow the style > guidelines. How about "trigger's return list must have even number of > elements"? I agree a full rewrite is sensible, but that particular w

Re: [HACKERS] pltcl: sentence improvement

2015-09-16 Thread Tom Lane
Euler Taveira writes: > On 16-09-2015 10:57, Tom Lane wrote: >> Also, if we're going to change this message at all, I'm inclined to >> rewrite it completely, because it doesn't really follow the style >> guidelines. How about "trigger's return list must have even number of >> elements"? > Works

Re: [HACKERS] pltcl: sentence improvement

2015-09-16 Thread Euler Taveira
On 16-09-2015 10:57, Tom Lane wrote: Euler Taveira writes: This simple patch improves a sentence. Spotted while working on translation. I concur that spelling out "#" as "number" is an improvement, but I'm curious which backend error you think this matches? It is sort of... utils/adt/json.

Re: [HACKERS] pltcl: sentence improvement

2015-09-16 Thread Tom Lane
Euler Taveira writes: > This simple patch improves a sentence. Spotted while working on translation. I concur that spelling out "#" as "number" is an improvement, but I'm curious which backend error you think this matches? Also, if we're going to change this message at all, I'm inclined to rewri