Re: [HACKERS] pgstat_reset_remove_files ignores its argument

2013-08-19 Thread Alvaro Herrera
Jeff Janes escribió: > No, you are right, I too realized I missed a couple more spots. Your > patch looks just like the one I eventually arrived at, before I got > distracted thinking about how to implement the regex > /^(global|db_\d+)\.stat$/ in C and forgot to post a correction. > > Is the re

Re: [HACKERS] pgstat_reset_remove_files ignores its argument

2013-08-19 Thread Jeff Janes
On Fri, Aug 16, 2013 at 12:38 PM, Robert Haas wrote: > On Wed, Aug 14, 2013 at 12:13 AM, Jeff Janes wrote: >> in 9.3 and 9.4, pgstat_reset_remove_files uses the global variable >> pgstat_stat_directory rather than the argument it is passed, "directory". >> On crash recovery, this means the tmp di

Re: [HACKERS] pgstat_reset_remove_files ignores its argument

2013-08-16 Thread Tomas Vondra
On 16.8.2013 21:38, Robert Haas wrote: > On Wed, Aug 14, 2013 at 12:13 AM, Jeff Janes > wrote: >> in 9.3 and 9.4, pgstat_reset_remove_files uses the global variable >> pgstat_stat_directory rather than the argument it is passed, >> "directory". On crash recovery, this means the tmp directory gets

Re: [HACKERS] pgstat_reset_remove_files ignores its argument

2013-08-16 Thread Robert Haas
On Wed, Aug 14, 2013 at 12:13 AM, Jeff Janes wrote: > in 9.3 and 9.4, pgstat_reset_remove_files uses the global variable > pgstat_stat_directory rather than the argument it is passed, "directory". > On crash recovery, this means the tmp directory gets cleared twice and the > permanent pg_stat does