On Thu, Sep 28, 2017 at 10:36 PM, Pavan Deolasee
wrote:
> Well, I think it's a very legitimate test, not for testing performance, but
> testing crash recovery and I use it very often. This particular test was run
> to catch another bug which will be reported separately.
Yeah, I use pgbench for st
Committed and back-patched to v10. I have to say I'm kind of
surprised that the comment removed by this patch got committed in the
first place. It's got a ??? in it and isn't very grammatical either.
ISTM that I reviewed the initial patch.
AFAICR I agreed with the comment that whether it wa
On Fri, Sep 29, 2017 at 1:39 AM, Pavan Deolasee
wrote:
> Looks good to me.
Committed and back-patched to v10. I have to say I'm kind of
surprised that the comment removed by this patch got committed in the
first place. It's got a ??? in it and isn't very grammatical either.
--
Robert Haas
Ent
- Run pgbench -c 10 -T 100
- Stop postgres with -m immediate
That is a strange test to run, but it would be better if the behavior was
not that one.
Well, I think it's a very legitimate test, not for testing performance, but
testing crash recovery and I use it very often.
Ok, interesting.
On Fri, Sep 29, 2017 at 1:03 AM, Fabien COELHO wrote:
>
> The commit that introduced this code is 12788ae49e1933f463bc. So I amn
>>> copying Heikki.
>>>
>>
>> AFAICR the commit was mostly a heavy restructuring of previous
>> unmaintainable spaghetti code. I'm not sure the problem was not there
>>
On Fri, Sep 29, 2017 at 12:22 AM, Fabien COELHO wrote:
>
> While running some tests, I encountered a situation where pgbench gets
>> stuck in an infinite loop, consuming 100% cpu. The setup was:
>>
>> - Start postgres server from the master branch
>> - Initialise pgbench
>> - Run pgbench -c 10 -T
The commit that introduced this code is 12788ae49e1933f463bc. So I amn
copying Heikki.
AFAICR the commit was mostly a heavy restructuring of previous unmaintainable
spaghetti code. I'm not sure the problem was not there before under one form
or another.
I agree that it should error out & s
While running some tests, I encountered a situation where pgbench gets
stuck in an infinite loop, consuming 100% cpu. The setup was:
- Start postgres server from the master branch
- Initialise pgbench
- Run pgbench -c 10 -T 100
- Stop postgres with -m immediate
That is a strange test to run,
