[ pgbench-enum-meta-2.patch ]
Pushed with some trivial cosmetic adjustments (pgindent changed
it more than I did).
Ok. Thanks.
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-ha
Fabien COELHO writes:
> [ pgbench-enum-meta-2.patch ]
Pushed with some trivial cosmetic adjustments (pgindent changed
it more than I did).
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
On Thu, 2 Nov 2017 17:50:52 +0100 (CET)
Fabien COELHO wrote:
> Updated version attached.
. Here is the patch. Sorry for the noise.
Everything alright. Patch is ready for commiter.
--
Aleksandr Parfenov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
--
Sent via
Updated version attached.
. Here is the patch. Sorry for the noise.
--
Fabien.diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 5d8a01c..6bd3e52 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -373,11 +373,21 @@ typedef enum QueryMode
static Q
The only thing I'm not quite sure about is a comment "which meta command
...". Maybe it's better to write it without question word, something
like "meta command identifier..."?
Ok. I agree.
Updated version attached. I also added a const on a function parameter.
Just a note about the motivat
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hi,
Looks good to me.
The only thing I'm not quite sure abo
2017-09-23 5:45 GMT+02:00 Fabien COELHO :
>
> Minor code enhancement.
>
> While having a look at adding if/elif/else/endif to pgbench, and given the
> current gset/cset added meta commands in cf queue, it occured to me that
> repeated string comparisons to check for the various meta commands is
>
