On Tuesday, June 25, 2013, Robert Haas wrote:
> On Thu, Jun 20, 2013 at 1:46 PM, Jeff Janes
> >
> wrote:
> > I've fixed a conflict, and I've removed extraneous semicolons from the C.
> >
> > I've left in the fixing of some existing bad indenting in the existing
> code,
> > which is not strictly r
OK, I like this idea a lot, but I have a question. Right now, to use
this, you have to supply the startup SQL on the command line. And
that could definitely be useful. But ISTM that you might also want to
take the startup SQL from a file, and indeed you might well want to
include metacommands
On Thu, Jun 20, 2013 at 1:46 PM, Jeff Janes wrote:
> I've fixed a conflict, and I've removed extraneous semicolons from the C.
>
> I've left in the fixing of some existing bad indenting in the existing code,
> which is not strictly related to my change.
OK, I like this idea a lot, but I have a qu
I've fixed a conflict, and I've removed extraneous semicolons from the C.
I've left in the fixing of some existing bad indenting in the existing
code, which is not strictly related to my change.
There are still unrelated changes : spacing on -c and -t options' help.
The "pgindent" command is
On Sun, Jun 16, 2013 at 9:42 PM, Jeff Janes wrote:
> On Thu, May 2, 2013 at 11:25 AM, Fabien COELHO wrote:
>
>>
>>
> Thanks for doing the review. I'm not sure what things to go change
> without further feedback/discussion, except point 4. I'll wait a day to
> see if I get more feedback on the
On Thu, May 2, 2013 at 11:25 AM, Fabien COELHO wrote:
>
> I've just done a quick review of the source, as I've been hacking in
> pgbench myself.
>
> I think that the feature makes sense.
>
> About the details of the patch:
>
> (1) Some changes in the patch are unrelated to the purpose of the patc
On 02/11/2013 07:27 AM, Jeff Janes wrote:
> I created doBenchMarkConnect() to segregate bench-marking connections from
> utility connections. At first I thought of adding the startup code to only
> the normal path and leaving support for -C in the wind, but decided that
> was just lazy.
That soun
I've just done a quick review of the source, as I've been hacking in
pgbench myself.
I think that the feature makes sense.
About the details of the patch:
(1) Some changes in the patch are unrelated to the purpose of the patch
(e.g. spacing changes, error message...), and should be removed?
On Sun, Feb 10, 2013 at 3:27 PM, Jeff Janes wrote:
...
> Will add to commitfest-next.
>
> Cheers,
>
> Jeff
>
I realized the original patch was broken for multithreaded use due to an
errant "static".
Also, I've cleaned up some carelessness in where I did the copy-and-paste
for parameter parsin
On 10 February 2013 23:27, Jeff Janes wrote:
> While looking at some proposed patches and pondering some questions on
> performance, I realized I desperately needed ways to run benchmarks with
> different settings without needing to edit postgresql.conf and
> restart/reload the server each time.
10 matches
Mail list logo
