Re: [HACKERS] pg_upgrade: quote directory names in delete_old_cluster script

2015-05-11 Thread Bruce Momjian
On Wed, Apr 29, 2015 at 10:52:45PM -0400, Bruce Momjian wrote: > On Mon, Feb 16, 2015 at 05:03:45PM -0500, Bruce Momjian wrote: > > > All of our makefiles use single quotes, so effectively the only > > > character we don't support in directory paths is the single quote itself. > > > > This seems t

Re: [HACKERS] pg_upgrade: quote directory names in delete_old_cluster script

2015-04-30 Thread Bruce Momjian
On Wed, Apr 29, 2015 at 11:59:26PM -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > > I have developed the attached patch to use platform-specific quoting of > > path names. > > Part of me wonders about initdb's existing DIR_SEP and QUOTE_PATH > definitions ... seems messy to reinvent thes

Re: [HACKERS] pg_upgrade: quote directory names in delete_old_cluster script

2015-04-30 Thread Alvaro Herrera
Bruce Momjian wrote: > I have developed the attached patch to use platform-specific quoting of > path names. Part of me wonders about initdb's existing DIR_SEP and QUOTE_PATH definitions ... seems messy to reinvent these things all over again. -- Álvaro Herrerahttp://www.2ndQuad

Re: [HACKERS] pg_upgrade: quote directory names in delete_old_cluster script

2015-04-29 Thread Bruce Momjian
On Mon, Feb 16, 2015 at 05:03:45PM -0500, Bruce Momjian wrote: > > All of our makefiles use single quotes, so effectively the only > > character we don't support in directory paths is the single quote itself. > > This seems to say that Windows batch files don't have any special > meaning for singl