Re: [HACKERS] pg_restore --clean vs. large object

2009-07-21 Thread Tom Lane
Itagaki Takahiro writes: > The attached is a patch to execute lo_unlink() before lo_create() > in pg_restore. Applied with corrections --- you had failed to ensure that pg_dump and pg_restore produce the same output. I also took the opportunity to schema-qualify the calls of lo_xxx functions, ju

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-21 Thread Tom Lane
Itagaki Takahiro writes: > Jaime Casanova wrote: >> i think this one could be applied, just as is... there is no need for >> docs, because the issue being fixed is not documented... maybe that >> should be in doc of older releases? > Sure, it was an undocumented behavior. Should we need to add d

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-20 Thread Itagaki Takahiro
Jaime Casanova wrote: > i think this one could be applied, just as is... there is no need for > docs, because the issue being fixed is not documented... maybe that > should be in doc of older releases? Sure, it was an undocumented behavior. Should we need to add details of this patch to documen

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-17 Thread Jaime Casanova
On Mon, May 18, 2009 at 3:10 AM, Itagaki Takahiro wrote: > > The attached is a patch to execute lo_unlink() before lo_create() > in pg_restore. the patch applies almost cleanly (there are only minor and superfluos hunks), compiles... it works as expected... this patch makes me wonder why we dump