Re: [HACKERS] pg_recvlogical --endpos

2017-01-04 Thread Simon Riggs
On 4 January 2017 at 13:37, Craig Ringer wrote: >> Moved to next CF with "needs review" state. > > Here's an updated series. It's on top of the entry > https://commitfest.postgresql.org/12/883/ for PostgresNode TAP test > enhancements. > > It corresponds exactly to patches [2,3,4] in the logical d

Re: [HACKERS] pg_recvlogical --endpos

2017-01-04 Thread Craig Ringer
> Moved to next CF with "needs review" state. Here's an updated series. It's on top of the entry https://commitfest.postgresql.org/12/883/ for PostgresNode TAP test enhancements. It corresponds exactly to patches [2,3,4] in the logical decoding on standby post at https://www.postgresql.org/messag

Re: [HACKERS] pg_recvlogical --endpos

2016-12-01 Thread Haribabu Kommi
On Wed, Nov 30, 2016 at 4:26 PM, Okano, Naoki wrote: > > On Wednesday, November 30, 2016 10:34 AM Craig Ringer wrote: > >On 30 November 2016 at 09:18, Okano, Naoki > > > wrote: > >> > >> On November 29, 2016 at 5:03 PM Craig Ringer wrote: > >>> Would it be better rephrased as "--endpos can only

Re: [HACKERS] pg_recvlogical --endpos

2016-11-29 Thread Okano, Naoki
On Wednesday, November 30, 2016 10:34 AM Craig Ringer wrote: >On 30 November 2016 at 09:18, Okano, Naoki > wrote: >> >> On November 29, 2016 at 5:03 PM Craig Ringer wrote: >>> Would it be better rephrased as "--endpos can only be used with --start" ? >> OK. I think this phrase is better than the

Re: [HACKERS] pg_recvlogical --endpos

2016-11-29 Thread Craig Ringer
On 30 November 2016 at 09:18, Okano, Naoki wrote: > > On November 29, 2016 at 5:03 PM Craig Ringer wrote: >> Would it be better rephrased as "--endpos can only be used with --start" ? > OK. I think this phrase is better than the previous phrase. > >>> The patch should allow --endpos to work with -

Re: [HACKERS] pg_recvlogical --endpos

2016-11-29 Thread Okano, Naoki
On November 29, 2016 at 5:03 PM Craig Ringer wrote: > Would it be better rephrased as "--endpos can only be used with --start" ? OK. I think this phrase is better than the previous phrase. >> The patch should allow --endpos to work with --create-slot. > > How? It doesn't make sense with --create

Re: [HACKERS] pg_recvlogical --endpos

2016-11-29 Thread Craig Ringer
On 22 November 2016 at 16:52, Okano, Naoki wrote: > On Monday, November 21, 2016 1:08 PM Craig Ringer wrote: >> I've updated the patch for this. It's already posted on the logical >> decoding timeline following thread, so I'll avoid repeating it here. >> >> https://www.postgresql.org/message-id/CA

Re: [HACKERS] pg_recvlogical --endpos

2016-11-22 Thread Okano, Naoki
On Monday, November 21, 2016 1:08 PM Craig Ringer wrote: > I've updated the patch for this. It's already posted on the logical > decoding timeline following thread, so I'll avoid repeating it here. > > https://www.postgresql.org/message-id/CAMsr%2BYGd5dv3zPNch6BU4UXX49NJDC9m3-Y%3DV5q%3DTNcE9QgSaQ%

Re: [HACKERS] pg_recvlogical --endpos

2016-11-20 Thread Craig Ringer
On 19 November 2016 at 10:04, Euler Taveira wrote: > On 01-09-2016 01:41, Craig Ringer wrote: >> Here's a rebased version of my pg_recvlogical --endpos patch from the >> 9.5 series, updated to incoroprate Álvaro's changes. >> > I should review this patch in the other commitfest but was swamped wit

Re: [HACKERS] pg_recvlogical --endpos

2016-11-18 Thread Euler Taveira
On 01-09-2016 01:41, Craig Ringer wrote: > Here's a rebased version of my pg_recvlogical --endpos patch from the > 9.5 series, updated to incoroprate Álvaro's changes. > I should review this patch in the other commitfest but was swamped with work. The patch is almost ready but I have some points.