Re: [HACKERS] pg_dump: Simplify internal archive version handling

2016-10-25 Thread Peter Eisentraut
On 10/13/16 9:13 AM, Tom Lane wrote: > Peter Eisentraut writes: >> I propose the attached patch to clean up some redundancy and confusion >> in pg_dump. > > Looks sane, though I'd suggest coding the access macros with shifts > not multiplies/divides. Done. > Since these numbers are purely inter

Re: [HACKERS] pg_dump: Simplify internal archive version handling

2016-10-13 Thread Tom Lane
Peter Eisentraut writes: > I propose the attached patch to clean up some redundancy and confusion > in pg_dump. Looks sane, though I'd suggest coding the access macros with shifts not multiplies/divides. Since these numbers are purely internal and not stored in this form in the file, I wonder wh