On Wed, Oct 26, 2016 at 2:00 AM, Magnus Hagander wrote:
> Thanks, applied and pushed.
Thanks.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Oct 25, 2016 at 2:52 PM, Michael Paquier
wrote:
> On Tue, Oct 25, 2016 at 7:12 PM, Magnus Hagander
> wrote:
> > On Mon, Oct 24, 2016 at 7:46 AM, Michael Paquier <
> michael.paqu...@gmail.com>
> > wrote:
> >>
> >> On Sun, Oct 23, 2016 at 10:28 PM, Magnus Hagander
> >> wrote:
> >> + if
On Tue, Oct 25, 2016 at 7:12 PM, Magnus Hagander wrote:
> On Mon, Oct 24, 2016 at 7:46 AM, Michael Paquier
> wrote:
>>
>> On Sun, Oct 23, 2016 at 10:28 PM, Magnus Hagander
>> wrote:
>> + if (format == 'p')
>> + stream.walmethod = CreateWalDirectoryMethod(param->xlog, do_sync);
>> + els
On Mon, Oct 24, 2016 at 7:46 AM, Michael Paquier
wrote:
> On Sun, Oct 23, 2016 at 10:28 PM, Magnus Hagander
> wrote:
> > It also broke the tests and invalidated some documentation. But it was
> easy
> > enough to fix.
> >
> > I've now applied this, so next time you get to do the merging :P Jokin
On Sun, Oct 23, 2016 at 10:28 PM, Magnus Hagander wrote:
> It also broke the tests and invalidated some documentation. But it was easy
> enough to fix.
>
> I've now applied this, so next time you get to do the merging :P Joking
> aside, please review and let me know if you can spot something I mes
On Mon, Oct 24, 2016 at 1:38 PM, Andres Freund wrote:
> On 2016-10-17 14:37:05 +0900, Michael Paquier wrote:
>> 2) Add an option to pg_xlogdump to be able to output its output to a
>> file. That would be awkward to rely on grabbing the output data from a
>> pipe... On Windows particularly. Thinkin
On 2016-10-17 14:37:05 +0900, Michael Paquier wrote:
> 2) Add an option to pg_xlogdump to be able to output its output to a
> file. That would be awkward to rely on grabbing the output data from a
> pipe... On Windows particularly. Thinking about it, would that
> actually be useful to others? That'
On Sun, Oct 23, 2016 at 10:52 PM, Michael Paquier
wrote:
> On Sun, Oct 23, 2016 at 10:30 PM, Magnus Hagander wrote:
>> I think both of those would be worthwhile. Just for the testability in
>> itself, but such a flag to pg_xlogdump would probably be useful in other
>> cases as well, beyond just t
On Sun, Oct 23, 2016 at 10:30 PM, Magnus Hagander wrote:
> On Mon, Oct 17, 2016 at 7:37 AM, Michael Paquier
> wrote:
>> > But independent of this patch, actually putting that test in for non-tar
>> > mode would probably not be a bad idea -- if that breaks, it's likely
>> > both
>> > break, after
On Mon, Oct 17, 2016 at 7:37 AM, Michael Paquier
wrote:
> On Sat, Oct 15, 2016 at 8:51 AM, Magnus Hagander
> wrote:
> > Fixed.
>
> Ok, I had a extra look on the patch:
> + The transactionn log files are written to a separate file
> +called pg_xlog.tar.
> +
> s/tr
On Fri, Oct 21, 2016 at 2:02 PM, Michael Paquier
wrote:
> On Mon, Oct 17, 2016 at 2:37 PM, Michael Paquier
> wrote:
> > Except that it looks in pretty good to me, so I am switching that as
> > ready for committer.
>
> + /*
> +* Create pg_xlog/archive_status (and thus pg_xlog) so we
On Mon, Oct 17, 2016 at 2:37 PM, Michael Paquier
wrote:
> Except that it looks in pretty good to me, so I am switching that as
> ready for committer.
+ /*
+* Create pg_xlog/archive_status (and thus pg_xlog) so we can write to
+* basedir/pg_xlog as the directory entry in the
On Sat, Oct 15, 2016 at 8:51 AM, Magnus Hagander wrote:
> Fixed.
Ok, I had a extra look on the patch:
+ The transactionn log files are written to a separate file
+called pg_xlog.tar.
+
s/transactionn/transaction/, and the markup should be on its own line.
+ if
On Tue, Oct 4, 2016 at 12:05 AM, Michael Paquier
wrote:
> (Squashing two emails into one)
>
> On Fri, Sep 30, 2016 at 11:16 PM, Magnus Hagander
> wrote:
> > And here's yet another version, now rebased on top of the fsync and
> nosync
> > changes that got applied.
>
> My fault :p
>
Yes, definite
(Squashing two emails into one)
On Fri, Sep 30, 2016 at 11:16 PM, Magnus Hagander wrote:
> And here's yet another version, now rebased on top of the fsync and nosync
> changes that got applied.
My fault :p
> In particular, this conflicted with pretty much every single change from the
> fsync pa
On Thu, Sep 29, 2016 at 12:44 PM, Magnus Hagander
wrote:
> On Mon, Sep 5, 2016 at 10:01 AM, Michael Paquier <
> michael.paqu...@gmail.com> wrote:
>
>> On Sat, Sep 3, 2016 at 10:35 PM, Magnus Hagander
>> wrote:
>> > Ugh. That would be nice to have, but I think that's outside the scope of
>> > thi
On Mon, Sep 5, 2016 at 10:01 AM, Michael Paquier
wrote:
> On Sat, Sep 3, 2016 at 10:35 PM, Magnus Hagander
> wrote:
> > Ugh. That would be nice to have, but I think that's outside the scope of
> > this patch.
>
> A test for this patch that could have value would be to use
> pg_basebackup -X stre
On Sep 28, 2016 19:11, "Robert Haas" wrote:
>
> On Mon, Sep 5, 2016 at 4:01 AM, Michael Paquier
> wrote:
> > [ review comments ]
>
> This thread has been sitting idle for more than 3 weeks, so I'm
> marking it "Returned with Feedback" in the CommitFest application.
> Magnus, Michael's latest roun
On Mon, Sep 5, 2016 at 4:01 AM, Michael Paquier
wrote:
> [ review comments ]
This thread has been sitting idle for more than 3 weeks, so I'm
marking it "Returned with Feedback" in the CommitFest application.
Magnus, Michael's latest round of comments seem pretty trivial, so
perhaps you want to ju
On Sat, Sep 3, 2016 at 10:35 PM, Magnus Hagander wrote:
> Ugh. That would be nice to have, but I think that's outside the scope of
> this patch.
A test for this patch that could have value would be to use
pg_basebackup -X stream -Ft, then untar pg_xlog.tar and look at the
size of the segments. If
On Thu, Sep 1, 2016 at 2:39 PM, Michael Paquier
wrote:
> On Thu, Sep 1, 2016 at 5:13 PM, Magnus Hagander
> wrote:
> > We don't seem to check for similar issues as the one just found in the
> > existing tests though, do we? As in, we don't actually verify that the
> xlog
> > files being streamed
On Thu, Sep 1, 2016 at 5:13 PM, Magnus Hagander wrote:
> We don't seem to check for similar issues as the one just found in the
> existing tests though, do we? As in, we don't actually verify that the xlog
> files being streamed are 16Mb? (Or for that matter that the tarfile emitted
> by -Ft is ac
On Thu, Sep 1, 2016 at 9:43 AM, Michael Paquier
wrote:
> On Thu, Sep 1, 2016 at 4:41 PM, Magnus Hagander
> wrote:
> > That's definitely not intended - it's supposed to be 16Mb. And it
> actually
> > writes 16Mb to the tarfile, it's the extraction that doesn't see them.
> That
> > also means that
On Thu, Sep 1, 2016 at 4:41 PM, Magnus Hagander wrote:
> That's definitely not intended - it's supposed to be 16Mb. And it actually
> writes 16Mb to the tarfile, it's the extraction that doesn't see them. That
> also means that if you get more than one member of the tarfile at this
> point, it wil
On Thu, Sep 1, 2016 at 9:19 AM, Michael Paquier
wrote:
> On Thu, Sep 1, 2016 at 6:58 AM, Magnus Hagander
> wrote:
> > Attached patch adds support for -X stream to work with .tar and .tar.gz
> file
> > formats.
>
> Nice.
>
> > If tar mode is specified, a separate pg_xlog.tar (or .tar.gz) file is
On Thu, Sep 1, 2016 at 6:58 AM, Magnus Hagander wrote:
> Attached patch adds support for -X stream to work with .tar and .tar.gz file
> formats.
Nice.
> If tar mode is specified, a separate pg_xlog.tar (or .tar.gz) file is
> created and the data is streamed into it. Regular mode is (should not)
26 matches
Mail list logo
