On Thu, Feb 10, 2011 at 10:40 AM, Steve Singer wrote:
> On 11-02-10 10:32 AM, Robert Haas wrote:
>> I was assuming those changes were sufficiently trivial that they could
>> be made at commit-time, especially if Peter is committing it himself.
>> Of course if he'd like a re-review, he can always p
On 11-02-10 10:32 AM, Robert Haas wrote:
I was assuming those changes were sufficiently trivial that they could
be made at commit-time, especially if Peter is committing it himself.
Of course if he'd like a re-review, he can always post an updated
patch, but I just thought that was overly pedant
On Thu, Feb 10, 2011 at 10:22 AM, Steve Singer wrote:
> On 11-02-10 10:13 AM, Robert Haas wrote:
>>
>> On Tue, Feb 1, 2011 at 1:33 PM, Robert Haas wrote:
>>>
>>> On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut wrote:
On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
>
> H
On 11-02-10 10:13 AM, Robert Haas wrote:
On Tue, Feb 1, 2011 at 1:33 PM, Robert Haas wrote:
On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut wrote:
On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
However if I connect with a line in pg_hba that matches on an IP
network then my client_h
On Tue, Feb 1, 2011 at 1:33 PM, Robert Haas wrote:
> On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut wrote:
>> On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
>>> However if I connect with a line in pg_hba that matches on an IP
>>> network then my client_hostname is always null unless log
On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut wrote:
> On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
>> However if I connect with a line in pg_hba that matches on an IP
>> network then my client_hostname is always null unless log_hostname is
>> set to true. This is consistent with the
On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
> However if I connect with a line in pg_hba that matches on an IP
> network then my client_hostname is always null unless log_hostname is
> set to true. This is consistent with the behavior you describe but I
> think the average user will fin
On Sun, Jan 30, 2011 at 4:30 PM, Peter Eisentraut wrote:
> On sön, 2011-01-30 at 15:03 -0500, Robert Haas wrote:
>> On Tue, Jan 18, 2011 at 7:24 PM, Steve Singer
>> wrote:
>> > If my connection is authorized through a line in pg_hba that uses
>> > client_hostname then the column shows what I expe
On sön, 2011-01-30 at 15:03 -0500, Robert Haas wrote:
> On Tue, Jan 18, 2011 at 7:24 PM, Steve Singer
> wrote:
> > If my connection is authorized through a line in pg_hba that uses
> > client_hostname then the column shows what I expect even with
> log_hostname
> > set to off.
> >
> > However if I
On Tue, Jan 18, 2011 at 7:24 PM, Steve Singer wrote:
> If my connection is authorized through a line in pg_hba that uses
> client_hostname then the column shows what I expect even with log_hostname
> set to off.
>
> However if I connect with a line in pg_hba that matches on an IP network
> then my
Excerpts from Steve Singer's message of mar ene 18 21:24:25 -0300 2011:
> Coding Review
> -
>
> As Alvaro pointed out BackendStatusShmemSize should be updated.
>
> To answer his question about why clientaddr works: clientaddr is a
> SockAddr which is a structure not a pointer so th
Here is my review for this patch
Submission Review
-Patch applies cleanly
-Patch does not include documentation changes. At a minimum: update the
table that lists what pg_stat_activity and pg_stat_replication includes
in monitoring.sgml but I propose more below.
-No tests
Excerpts from Peter Eisentraut's message of sáb ene 15 13:15:45 -0300 2011:
> Here is a patch that adds a client_hostname field to pg_stat_activity.
> It takes the hostname if it is available either by having log_hostname
> set or if the pg_hba.conf processing resolved it. So I think for most
> p
On tor, 2010-12-23 at 22:21 +0100, Magnus Hagander wrote:
> On Thu, Dec 23, 2010 at 22:09, Peter Eisentraut wrote:
> > Somehow I fantasized that log_hostname would also turn
> > pg_stat_activity.client_addr into names instead of IP addresses. It
> > doesn't, but perhaps it should? It would be ni
On Thu, Dec 23, 2010 at 22:09, Peter Eisentraut wrote:
> Somehow I fantasized that log_hostname would also turn
> pg_stat_activity.client_addr into names instead of IP addresses. It
> doesn't, but perhaps it should? It would be nice to be able to
> configure an IP-address free setup. Or would i
15 matches
Mail list logo
