Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Peter Eisentraut
On 9/26/12 10:07 AM, Tom Lane wrote: > I can't get excited about this either. This isn't the first, or the > last, change that add-on modules can expect to have to make to track > newer Postgres versions. If we allow Peter's complaint to become the > new project policy, we'll never be able to mak

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of miƩ sep 26 11:18:51 -0300 2012: > On 9/26/12 10:07 AM, Tom Lane wrote: > > I can't get excited about this either. This isn't the first, or the > > last, change that add-on modules can expect to have to make to track > > newer Postgres versions. If we al

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Tom Lane
"Albe Laurenz" writes: > Hitoshi Harada wrote: >> But it's only add #include "access/htup_details.h"? I'd not argue >> it's harmful unless I missed your point. > I guess the point is that you need an #ifdef if you want a module > to be able to build with both 9.3 and lower versions. I can't get

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of mar sep 25 21:30:59 -0300 2012: > I haven't followed the details of the htup header reorganization, but I > have noticed that a number of external extension modules will be broken > because of the move of GETSTRUCT() and to a lesser extent > heap_getattr(

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Michael Paquier
On Wed, Sep 26, 2012 at 4:14 PM, Albe Laurenz wrote: > Hitoshi Harada wrote: > > On Tue, Sep 25, 2012 at 5:30 PM, Peter Eisentraut > wrote: > >> I haven't followed the details of the htup header reorganization, but > I > >> have noticed that a number of external extension modules will be > broken

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-26 Thread Albe Laurenz
Hitoshi Harada wrote: > On Tue, Sep 25, 2012 at 5:30 PM, Peter Eisentraut wrote: >> I haven't followed the details of the htup header reorganization, but I >> have noticed that a number of external extension modules will be broken >> because of the move of GETSTRUCT() and to a lesser extent >> hea

Re: [HACKERS] htup header reorganization breaks many extension modules

2012-09-25 Thread Hitoshi Harada
On Tue, Sep 25, 2012 at 5:30 PM, Peter Eisentraut wrote: > I haven't followed the details of the htup header reorganization, but I > have noticed that a number of external extension modules will be broken > because of the move of GETSTRUCT() and to a lesser extent > heap_getattr(). Of course some