On Thu, Mar 9, 2017 at 11:44 PM, Robert Haas wrote:
> On Thu, Mar 9, 2017 at 1:19 AM, Ashutosh Bapat
> wrote:
At least we need to update the documentation.
>>>
>>> Got a proposal?
>>
>> How about something like attached?
>
> Committed with some revisions.
Thanks.
--
Best Wishes,
Ashutosh B
On Thu, Mar 9, 2017 at 1:19 AM, Ashutosh Bapat
wrote:
>>> At least we need to update the documentation.
>>
>> Got a proposal?
>
> How about something like attached?
Committed with some revisions.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Se
>
>> I didn't do anything about Ashutosh's comment that we could use ALTER
>> FOREIGN TABLE rather than ALTER TABLE someplace; that didn't seem
>> critical.
>
> Attached is a patch to fix that, just in case.
Thanks. Looks good to me.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Po
>
>> At least we need to update the documentation.
>
> Got a proposal?
How about something like attached?
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
attach_part_constraint_doc.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (p
On 2017/03/09 1:28, Robert Haas wrote:
> On Tue, Feb 21, 2017 at 8:40 PM, Amit Langote
> wrote:
>> Ashutosh Bapat pointed out [0] that regression tests are missing for the
>> foreign partition DDL commands. Attached patch takes care of that.
>
> Committed.
Thanks.
> I didn't do anything about
On Tue, Feb 21, 2017 at 8:40 PM, Amit Langote
wrote:
> Ashutosh Bapat pointed out [0] that regression tests are missing for the
> foreign partition DDL commands. Attached patch takes care of that.
Committed.
I didn't do anything about Ashutosh's comment that we could use ALTER
FOREIGN TABLE rat
On Tue, Mar 7, 2017 at 11:18 PM, Ashutosh Bapat
wrote:
>> I agree that we could do that, but what value would it have? It just
>> forces the user to spend two SQL commands doing what could otherwise
>> be done in one.
>
> I don't think it's going to be two commands always. A user who wants
> to a
On Wed, Mar 8, 2017 at 7:36 AM, Robert Haas wrote:
> On Tue, Mar 7, 2017 at 7:14 AM, Ashutosh Bapat
> wrote:
>> Hi Amit,
>> Thanks for adding testcases. Overall the testcases look good.
>>
>> The testcase is using ALTER TABLE to modify foreign table schema.
>> Though this works, I think a better
On Tue, Mar 7, 2017 at 7:14 AM, Ashutosh Bapat
wrote:
> Hi Amit,
> Thanks for adding testcases. Overall the testcases look good.
>
> The testcase is using ALTER TABLE to modify foreign table schema.
> Though this works, I think a better option is to use ALTER FOREIGN
> TABLE.
>
> Something not rel
Hi Amit,
Thanks for adding testcases. Overall the testcases look good.
The testcase is using ALTER TABLE to modify foreign table schema.
Though this works, I think a better option is to use ALTER FOREIGN
TABLE.
Something not related to this patch but
-- no attach partition validation occurs for f
On 2017/02/22 13:26, Ashutosh Bapat wrote:
> Please add this to the upcoming commitfest.
Done.
Thanks,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Please add this to the upcoming commitfest.
On Wed, Feb 22, 2017 at 7:10 AM, Amit Langote
wrote:
> Ashutosh Bapat pointed out [0] that regression tests are missing for the
> foreign partition DDL commands. Attached patch takes care of that.
>
> Thanks,
> Amit
>
> [0]
> https://www.postgresql.org
12 matches
Mail list logo