Re: [HACKERS] commit_delay, siblings

2005-07-01 Thread Tatsuo Ishii
Hi, > Simon Riggs <[EMAIL PROTECTED]> writes: > > Group commit is a well-documented technique for improving performance, > > The issue here is not "is group commit a good idea in the abstract?". > It is "is the commit_delay implementation of the idea worth a dime?" > ... and the evidence we have

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Simon Riggs
On Wed, 2005-06-29 at 10:16 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > Group commit is a well-documented technique for improving performance, > > The issue here is not "is group commit a good idea in the abstract?". > It is "is the commit_delay implementation of the idea

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Kenneth Marshall
On Wed, Jun 29, 2005 at 08:14:36AM +0100, Simon Riggs wrote: > > Group commit is a well-documented technique for improving performance, > but the gains only show themselves on very busy systems. It is possible > in earlier testing any apparent value was actually hidden by the > BufMgrLock issues w

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > Group commit is a well-documented technique for improving performance, The issue here is not "is group commit a good idea in the abstract?". It is "is the commit_delay implementation of the idea worth a dime?" ... and the evidence we have all points to the

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Bruce Momjian
Simon Riggs wrote: > On Wed, 2005-06-22 at 11:11 -0700, Josh Berkus wrote: > > Hans, Tom, > > > > > We have done extensive testing some time ago. > > > We could not see any difference on any platform we have tested (AIX, > > > Linux, Solaris). I don't think that there is one at all - at least not

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Michael Paesold
Simon Riggs wrote: Group commit is a well-documented technique for improving performance, but the gains only show themselves on very busy systems. It is possible in earlier testing any apparent value was actually hidden by the BufMgrLock issues we have now resolved in 8.1. We now see XLogInsert a

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Simon Riggs
On Wed, 2005-06-22 at 11:11 -0700, Josh Berkus wrote: > Hans, Tom, > > > We have done extensive testing some time ago. > > We could not see any difference on any platform we have tested (AIX, > > Linux, Solaris). I don't think that there is one at all - at least not > > on common systems. > > Ke

Re: [HACKERS] commit_delay, siblings

2005-06-28 Thread Josh Berkus
Tom, Incidentally, I have tests in the queue. It's just that the STP has been very unreliable for the last month so I've not been able to get definitive test results. More important than commit_*, is, of course the WAL/CRC stuff for checkpoint cost, which I'm also getting impatient to test.

Re: [HACKERS] commit_delay, siblings

2005-06-28 Thread Alvaro Herrera
On Tue, Jun 28, 2005 at 10:35:43AM -0400, Tom Lane wrote: > Tatsuo Ishii <[EMAIL PROTECTED]> writes: > >>> If we yank them ( and I agree) I think we have to do it before feature > >>> freeze. > >> > >> I believe that we have consensus to yank them. Hans says that he did > >> extensive testing b

Re: [HACKERS] commit_delay, siblings

2005-06-28 Thread Tom Lane
Tatsuo Ishii <[EMAIL PROTECTED]> writes: >>> If we yank them ( and I agree) I think we have to do it before feature >>> freeze. >> >> I believe that we have consensus to yank them. Hans says that he did >> extensive testing back as far as 7.4 and the options had no effect. > My opinion is, we'

Re: [HACKERS] commit_delay, siblings

2005-06-28 Thread Tatsuo Ishii
> > > Just a warning, because I might bring it up after feature freeze. > > > > If we yank them ( and I agree) I think we have to do it before feature > > freeze. > > I believe that we have consensus to yank them. Hans says that he did > extensive testing back as far as 7.4 and the options had

Re: [HACKERS] commit_delay, siblings

2005-06-28 Thread Josh Berkus
Bruce, > > Just a warning, because I might bring it up after feature freeze. > > If we yank them ( and I agree) I think we have to do it before feature > freeze. I believe that we have consensus to yank them. Hans says that he did extensive testing back as far as 7.4 and the options had no eff

Re: [HACKERS] commit_delay, siblings

2005-06-27 Thread Bruce Momjian
Josh Berkus wrote: > Hackers: > > I've been trying to get a test result for 8.1 that shows that we can > eliminate > commit_delay and commit_siblings, as I believe that these settings no longer > have any real effect on performance. However, the checkpointing performance > issues have so far

Re: [HACKERS] commit_delay, siblings

2005-06-23 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> writes > > > together with some kind of IPC to waken backends once xlog was flushed > past the point they needed. (Designing that is the hard part.) > I think we could use ProcSendSignal()/ProcWaitForSignal() mechanism to cope with the problem, because they won't l

Re: [HACKERS] commit_delay, siblings

2005-06-22 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > Would commit_delay/commit_siblings helps or we need a > background xlog writer and notify us the completion of xlogflush is better > (so we don't compete for this lock)? The existing bgwriter already does a certain amount of xlog flushing (since it mus

Re: [HACKERS] commit_delay, siblings

2005-06-22 Thread Qingqing Zhou
"Josh Berkus" writes > Hackers: > > I've been trying to get a test result for 8.1 that shows that we can eliminate > commit_delay and commit_siblings, as I believe that these settings no longer > have any real effect on performance. However, the checkpointing performance > issues have so far pre

Re: [HACKERS] commit_delay, siblings

2005-06-22 Thread Greg Stark
Hans-Jürgen Schönig <[EMAIL PROTECTED]> writes: > > The theory is good, but useful values for commit_delay would probably be > > under a millisecond, and there isn't any portable way to sleep for such > > short periods. Just because there's no "portable" way to be sure it'll work doesn't mean th

Re: [HACKERS] commit_delay, siblings

2005-06-22 Thread Josh Berkus
Hans, Tom, > We have done extensive testing some time ago. > We could not see any difference on any platform we have tested (AIX, > Linux, Solaris). I don't think that there is one at all - at least not > on common systems. Keen then. Any objections to removing the GUC? We desperately need mea

Re: [HACKERS] commit_delay, siblings

2005-06-22 Thread Hans-Jürgen Schönig
Tom Lane wrote: Josh Berkus writes: I've been trying to get a test result for 8.1 that shows that we can eliminate commit_delay and commit_siblings, as I believe that these settings no longer have any real effect on performance. I don't think they ever did :-(. The theory is good, but use

Re: [HACKERS] commit_delay, siblings

2005-06-22 Thread Tom Lane
Josh Berkus writes: > I've been trying to get a test result for 8.1 that shows that we can > eliminate > commit_delay and commit_siblings, as I believe that these settings no longer > have any real effect on performance. I don't think they ever did :-(. The theory is good, but useful values f