Re: [HACKERS] alter server for foreign table

2017-09-30 Thread Tom Lane
Andrew Dunstan writes: > I assume the proposal is to allow changing to a different server using > the same FDW. I can see all sorts of odd things happening if we allow > changing to a server of a different FDW. As long as we check that the table's FDW options are acceptable to the new FDW, where'

Re: [HACKERS] alter server for foreign table

2017-09-30 Thread konstantin knizhnik
On Sep 30, 2017, at 10:58 PM, Andrew Dunstan wrote: > > > On 09/30/2017 05:14 AM, Derry Hamilton wrote: >> Just to say, yes, this would be handy. I've been using a variant of >> that hack on reporting servers, while migrating systems from >> proprietary databases. It behaves quite gracefully w

Re: [HACKERS] alter server for foreign table

2017-09-30 Thread Nico Williams
On Sat, Sep 30, 2017 at 03:58:04PM -0400, Andrew Dunstan wrote: > On 09/30/2017 05:14 AM, Derry Hamilton wrote: > > Just to say, yes, this would be handy. I've been using a variant of > > that hack on reporting servers, while migrating systems from > > proprietary databases.  It behaves quite grace

Re: [HACKERS] alter server for foreign table

2017-09-30 Thread Andrew Dunstan
On 09/30/2017 05:14 AM, Derry Hamilton wrote: > Just to say, yes, this would be handy. I've been using a variant of > that hack on reporting servers, while migrating systems from > proprietary databases.  It behaves quite gracefully when there are > incompatible options, and it fixes up properly

Re: [HACKERS] alter server for foreign table

2017-09-30 Thread Derry Hamilton
Just to say, yes, this would be handy. I've been using a variant of that hack on reporting servers, while migrating systems from proprietary databases. It behaves quite gracefully when there are incompatible options, and it fixes up properly with DROPs as the first options. Derry

Re: [HACKERS] alter server for foreign table

2017-09-29 Thread Nico Williams
On Fri, Sep 29, 2017 at 10:19:03PM +0200, David Fetter wrote: > On Fri, Sep 29, 2017 at 01:47:59PM -0400, Tom Lane wrote: > > Konstantin Knizhnik writes: > > > According to Postgresql documentation it is not possible to alter server > > > for foreign table: > > > https://www.postgresql.org/docs/1

Re: [HACKERS] alter server for foreign table

2017-09-29 Thread David Fetter
On Fri, Sep 29, 2017 at 01:47:59PM -0400, Tom Lane wrote: > Konstantin Knizhnik writes: > > According to Postgresql documentation it is not possible to alter server > > for foreign table: > > https://www.postgresql.org/docs/10/static/sql-alterforeigntable.html > > Hmm, we'd have to check if the

Re: [HACKERS] alter server for foreign table

2017-09-29 Thread Tom Lane
Konstantin Knizhnik writes: > According to Postgresql documentation it is not possible to alter server > for foreign table: > https://www.postgresql.org/docs/10/static/sql-alterforeigntable.html Hmm, we'd have to check if the table's options were legal for the new FDW, but in principle we could