Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Boszormenyi Zoltan
2013-01-02 17:22 keltezéssel, Tom Lane írta: Boszormenyi Zoltan writes: 2013-01-02 16:52 keltezéssel, Heikki Linnakangas írta: IMHO this doesn't belong into libpq, the interface is fine as it is. It's the caller's responsibility to set the pointer to NULL after PQclear(), same as it's the ca

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Dmitriy Igrishin
2013/1/2 Heikki Linnakangas > On 02.01.2013 17:27, Marko Kreen wrote: > >> On Wed, Jan 2, 2013 at 5:11 PM, Boszormenyi Zoltan >> wrote: >> >>> 2012-12-11 16:09 keltezéssel, Simon Riggs írta: >>> >>> On 11 December 2012 12:18, Boszormenyi Zoltan wrote: Such mechanism already exist -

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Tom Lane
Boszormenyi Zoltan writes: > 2013-01-02 16:52 keltezéssel, Heikki Linnakangas írta: >> IMHO this doesn't belong into libpq, the interface is fine as it is. It's >> the caller's >> responsibility to set the pointer to NULL after PQclear(), same as it's the >> caller's >> responsibility to set a

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Boszormenyi Zoltan
2013-01-02 16:52 keltezéssel, Heikki Linnakangas írta: On 02.01.2013 17:27, Marko Kreen wrote: On Wed, Jan 2, 2013 at 5:11 PM, Boszormenyi Zoltan wrote: 2012-12-11 16:09 keltezéssel, Simon Riggs írta: On 11 December 2012 12:18, Boszormenyi Zoltan wrote: Such mechanism already exist - you

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Boszormenyi Zoltan
2013-01-02 16:27 keltezéssel, Marko Kreen írta: On Wed, Jan 2, 2013 at 5:11 PM, Boszormenyi Zoltan wrote: 2012-12-11 16:09 keltezéssel, Simon Riggs írta: On 11 December 2012 12:18, Boszormenyi Zoltan wrote: Such mechanism already exist - you just need to set your PGresult pointer to NULL a

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Heikki Linnakangas
On 02.01.2013 17:27, Marko Kreen wrote: On Wed, Jan 2, 2013 at 5:11 PM, Boszormenyi Zoltan wrote: 2012-12-11 16:09 keltezéssel, Simon Riggs írta: On 11 December 2012 12:18, Boszormenyi Zoltan wrote: Such mechanism already exist - you just need to set your PGresult pointer to NULL after eac

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Marko Kreen
On Wed, Jan 2, 2013 at 5:11 PM, Boszormenyi Zoltan wrote: > 2012-12-11 16:09 keltezéssel, Simon Riggs írta: > >> On 11 December 2012 12:18, Boszormenyi Zoltan wrote: >> > Such mechanism already exist - you just need to set > your PGresult pointer to NULL after each PQclear(). So

Re: [HACKERS] allowing multiple PQclear() calls

2013-01-02 Thread Boszormenyi Zoltan
2012-12-11 16:09 keltezéssel, Simon Riggs írta: On 11 December 2012 12:18, Boszormenyi Zoltan wrote: Such mechanism already exist - you just need to set your PGresult pointer to NULL after each PQclear(). So why doesn't PQclear() do that? Because then PQclear() would need a ** not a *. Do y

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Simon Riggs
On 11 December 2012 12:18, Boszormenyi Zoltan wrote: >>> Such mechanism already exist - you just need to set >>> your PGresult pointer to NULL after each PQclear(). >> >> So why doesn't PQclear() do that? > > > Because then PQclear() would need a ** not a *. Do you want its > interface changed fo

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Daniele Varrazzo
On Tue, Dec 11, 2012 at 12:43 PM, Josh Kupershmidt wrote: > Ah, well. I guess using a macro like: > > #define SafeClear(res) do {PQclear(res); res = NULL;} while (0); > > will suffice for me. Psycopg uses: #define IFCLEARPGRES(pgres) if (pgres) {PQclear(pgres); pgres = NULL;} -- Daniele --

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Josh Kupershmidt
On Tue, Dec 11, 2012 at 5:18 AM, Boszormenyi Zoltan wrote: > 2012-12-11 12:45 keltezéssel, Simon Riggs írta: > >> On 11 December 2012 10:39, Marko Kreen wrote: >>> >>> On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt >>> wrote: Would it be crazy to add an "already_freed" flag to the p

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Boszormenyi Zoltan
2012-12-11 12:45 keltezéssel, Simon Riggs írta: On 11 December 2012 10:39, Marko Kreen wrote: On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt wrote: Would it be crazy to add an "already_freed" flag to the pg_result struct which PQclear() would set, or some equivalent safety mechanism, to av

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Simon Riggs
On 11 December 2012 10:39, Marko Kreen wrote: > On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt wrote: >> Would it be crazy to add an "already_freed" flag to the pg_result >> struct which PQclear() would set, or some equivalent safety mechanism, >> to avoid this hassle for users? > > Such mecha

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Marko Kreen
On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt wrote: > Would it be crazy to add an "already_freed" flag to the pg_result > struct which PQclear() would set, or some equivalent safety mechanism, > to avoid this hassle for users? Such mechanism already exist - you just need to set your PGresult

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-10 Thread Tom Lane
Josh Kupershmidt writes: > Would it be crazy to add an "already_freed" flag to the pg_result > struct which PQclear() would set, or some equivalent safety mechanism, > to avoid this hassle for users? Yes, it would. Once the memory has been freed, malloc() is at liberty to give it out for some ot