Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > On Tue, Feb 13, 2007 at 05:23:56PM +0100, Peter Eisentraut wrote: >> It turns out that gcc warns about it anyway. Does anyone have some sort >> of clever recipe to catch warnings more easily than by carefully >> reading the make output or manually gr

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Bruce Momjian
Peter Eisentraut wrote: > Tom Lane wrote: > > Magnus Hagander <[EMAIL PROTECTED]> writes: > > > From what I can tell, this is because the Assert() puts code (the > > > do {} loop) *before* the declaration of StringInfoData buf, which > > > is not permitted. > > > > This will fail on every ANSI-C co

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Magnus Hagander
On Tue, Feb 13, 2007 at 05:23:56PM +0100, Peter Eisentraut wrote: > Tom Lane wrote: > > Magnus Hagander <[EMAIL PROTECTED]> writes: > > > From what I can tell, this is because the Assert() puts code (the > > > do {} loop) *before* the declaration of StringInfoData buf, which > > > is not permitted.

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Peter Eisentraut
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > From what I can tell, this is because the Assert() puts code (the > > do {} loop) *before* the declaration of StringInfoData buf, which > > is not permitted. > > This will fail on every ANSI-C compiler, not just vc. Please fix. We

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Alvaro Herrera
Magnus Hagander wrote: > The latest set of XML changes (I think latest, at least fairly recent) > broke the win32vc build with asserts enabled. The line: > Assert(fully_escaped || !escape_period); > > From what I can tell, this is because the Assert() puts code (the do {} > loop) *before* th

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Magnus Hagander
On Tue, Feb 13, 2007 at 10:50:30AM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > From what I can tell, this is because the Assert() puts code (the do {} > > loop) *before* the declaration of StringInfoData buf, which is not > > permitted. > > This will fail on every ANSI

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > From what I can tell, this is because the Assert() puts code (the do {} > loop) *before* the declaration of StringInfoData buf, which is not > permitted. This will fail on every ANSI-C compiler, not just vc. Please fix. regard

Re: [HACKERS] XML changes broke assert-enabled vcbuild

2007-02-13 Thread Magnus Hagander
On Tue, Feb 13, 2007 at 04:29:16PM +0100, Magnus Hagander wrote: > The latest set of XML changes (I think latest, at least fairly recent) > broke the win32vc build with asserts enabled. The line: > Assert(fully_escaped || !escape_period); > > From what I can tell, this is because the Assert(