Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-05-17 Thread Zdenek Kotala
Josh Berkus napsal(a): Zdenek, Unfortunately, this approach does not work between layout 3 and 4. It works only for heap on platfrom with maxallign=4. The main problem is that PageHeader has been extended to 24 bytes and it requires reindexing, TOAST chunk resizing, converted tuples does not f

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-05-17 Thread Josh Berkus
Zdenek, > Unfortunately, this approach does not work between layout 3 and 4. It > works only for heap on platfrom with maxallign=4. > > The main problem is that PageHeader has been extended to 24 bytes and it > requires reindexing, TOAST chunk resizing, converted tuples does not fit > on page on p

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-05-17 Thread Zdenek Kotala
Zdenek Kotala napsal(a): How it works: When PLC module is loaded, then for each page which does not have native page version conversion routine is called. Buffer is mark as a dirty and upgraded page is inserted into WAL. Unfortunately, this approach does not work between layout 3 and 4.

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-16 Thread Zdenek Kotala
Heikki Linnakangas napsal(a): Zdenek Kotala wrote: Heikki Linnakangas napsal(a): I would suggest starting with putting some serious effort into pg_migrator. This page layout conversion is actually pretty trivial compared to all that, and even more so if you can get the page layout conversion

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Heikki Linnakangas
Zdenek Kotala wrote: Heikki Linnakangas napsal(a): I would suggest starting with putting some serious effort into pg_migrator. This page layout conversion is actually pretty trivial compared to all that, and even more so if you can get the page layout conversion working in pg_migrator first.

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Zdenek Kotala
Tom Lane napsal(a): Heikki Linnakangas <[EMAIL PROTECTED]> writes: Zdenek Kotala wrote: I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. I agree it's an important piece of the puzzle, but not the most complicated one by far. In fac

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Zdenek Kotala
Thanks for your comment. See my comments inline: Heikki Linnakangas napsal(a): Zdenek Kotala wrote: I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. I agree it's an important piece of the puzzle, but not the most complicated one by f

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Zdenek Kotala wrote: >> I attached patch which implemented page layout converter (PLC) hook. It >> is base stone for in-place upgrade. > I agree it's an important piece of the puzzle, but not the most > complicated one by far. In fact, it's not ev

Re: [HACKERS] WIP: Pg_upgrade - page layout converter (PLC) hook

2008-04-15 Thread Heikki Linnakangas
Zdenek Kotala wrote: I attached patch which implemented page layout converter (PLC) hook. It is base stone for in-place upgrade. I agree it's an important piece of the puzzle, but not the most complicated one by far. How will you deal with catalog changes for example? I'm going to assume that